chore(cypress): Try to analyze failures

Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>

Author: DerDreschner

build/psalm-baseline.xml

@@ -2209,6 +2209,7 @@
       <code><![CDATA[unlink]]></code>
       <code><![CDATA[unlockFile]]></code>
       <code><![CDATA[unlockFile]]></code>
+      <code><![CDATA[unlockFile]]></code>
     </InternalMethod>
   </file>
   <file src="apps/files_versions/lib/Versions/LegacyVersionsBackend.php">

cypress/e2e/files/FilesUtils.ts

@@ -230,15 +230,13 @@ export function moveFile(fileName: string, dirPath: string) {
 				.findByRole('button', { name: 'All files' })
 				.should('be.visible')
 				.click()
-			// [picker-diag] log the exact button texts to see the root label
-			cy.get('button').then(($b) => cy.task('log', '[picker-diag] move buttons=' + JSON.stringify(Array.from($b).map((x) => (x as HTMLElement).textContent)), { log: false }))
 			// Click move. Match the confirm button EXACTLY as "Move": the picker
 			// labels it "Move to {folder}" while inside a folder and only "Move"
 			// once it has navigated to the home root. A loose `contains('Move')`
 			// would match the stale "Move to {folder}" button before the "All
 			// files" navigation above has landed, moving the file into the wrong
 			// folder. The exact match makes cypress wait for the root button.
-			cy.contains('button', /^\s*Move\s*$/).should('be.visible').click()
+			cy.contains('button', /^Move\s*$/).should('be.visible').click()
 		} else if (dirPath === '.') {
 			// click move
 			cy.contains('button', 'Copy').should('be.visible').click()
@@ -276,16 +274,14 @@ export function copyFile(fileName: string, dirPath: string) {
 				.findByRole('button', { name: 'All files' })
 				.should('be.visible')
 				.click()
-			// [picker-diag] log the exact button texts to see the root label
-			cy.get('button').then(($b) => cy.task('log', '[picker-diag] copy buttons=' + JSON.stringify(Array.from($b).map((x) => (x as HTMLElement).textContent)), { log: false }))
 			// Click copy. Match the confirm button EXACTLY as "Copy": the picker
 			// labels it "Copy to {folder}" while inside a folder and only "Copy"
 			// once it has navigated to the home root. A loose `contains('Copy')`
 			// would match the stale "Copy to {folder}" button before the "All
 			// files" navigation above has landed, copying the file into the wrong
 			// folder (deduplicated as "… (1)"). The exact match makes cypress
 			// wait for the root button.
-			cy.contains('button', /^\s*Copy\s*$/).should('be.visible').click()
+			cy.contains('button', /^Copy\s*$/).should('be.visible').click()
 		} else if (dirPath === '.') {
 			// click copy
 			cy.contains('button', 'Copy').should('be.visible').click()

cypress/e2e/files_versions/login_flake_repro.cy.ts

@@ -13,8 +13,8 @@
  *        --spec cypress/e2e/files_versions/login_flake_repro.cy.ts
  */
 
-import { setupTestSharedFileFromUser, uploadThreeVersions } from './filesVersionsUtils.ts'
 import { randomString } from '../../support/utils/randomString.ts'
+import { setupTestSharedFileFromUser, uploadThreeVersions } from './filesVersionsUtils.ts'
 
 describe('[login-diag] login flake repro', () => {
 	const folderName = 'shared_folder'

cypress/e2e/files_versions/menu_verify.cy.ts

@@ -0,0 +1,48 @@
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ *
+ * [menu-verify] THROWAWAY probe. Does a plain single open-click on a file-row
+ * actions toggle get LOST on a slow (0.2 CPU) runner? A lost click leaves
+ * aria-expanded="false" and the menu never opens — which the raised
+ * defaultCommandTimeout cannot fix (it would just wait the full timeout on a
+ * menu that will never open). This is what the openActionsMenu re-click poll
+ * exists to handle. If aria-expanded stays "false" here, the poll is still
+ * needed even with the timeout raise.
+ */
+
+import { getActionButtonForFile } from '../files/FilesUtils.ts'
+
+describe('[menu-verify] single-click actions-menu open', () => {
+	it('detects lost open-clicks (no re-click)', () => {
+		const files = Array.from({ length: 12 }, (_, i) => `mv${i}.txt`)
+		cy.createRandomUser().then((user) => {
+			files.forEach((f) => cy.uploadContent(user, new Blob([f], { type: 'text/plain' }), 'text/plain', `/${f}`))
+			cy.login(user)
+			cy.visit('/apps/files')
+
+			const lost: string[] = []
+			cy.wrap(files).each((f: string) => {
+				getActionButtonForFile(f).scrollIntoView()
+				// A single, plain click — exactly what master's helper did before
+				// the openActionsMenu re-click poll was added.
+				getActionButtonForFile(f).click({ force: true })
+				// Give the click's handler ample time to fire (1s is plenty on any
+				// runner if the click actually registered), then inspect the toggle.
+				// eslint-disable-next-line cypress/no-unnecessary-waiting
+				cy.wait(1000)
+				getActionButtonForFile(f).then(($t) => {
+					const exp = $t.attr('aria-expanded')
+					cy.task('log', `[menu-verify] ${f}: aria-expanded=${exp} 1s after single click`)
+					if (exp !== 'true') {
+						lost.push(f)
+					}
+				})
+				// Reset for the next file (close the menu if it did open).
+				cy.get('body').type('{esc}')
+			}).then(() => {
+				cy.task('log', `[menu-verify] LOST OPEN-CLICKS: ${lost.length}/${files.length} -> [${lost.join(', ')}]`)
+			})
+		})
+	})
+})