Skip to content

Commit 61afbaa

Browse files
committed
chore: remove deprecated global libraries
- `clipboard` => just use native `navigator.clipboard` - `davclient.js` => use `webdav` or `@nextcloud/files` - `moment` => use `@nextcloud/moment` or better native `Intl.DateTimeFormat` or `Temporal` API - `underscore` => just use moder ES2015+ syntax Adjusted core (remove usage of `_`) to be able to fully drop those libraries as dependencies (except `moment` which we still use in some legacy apps). Now that `davclient.js` is gone we also can re-enable the `Validate package-lock.json` step on CI. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1 parent 368f338 commit 61afbaa

6 files changed

Lines changed: 40 additions & 358 deletions

File tree

.github/workflows/npm-build.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,11 @@ jobs:
7575
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
7676
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
7777

78-
# This does not work on server as we have some git dependencies that "npm-package-lock-add-resolved" cannot handle
79-
# - name: Validate package-lock.json # See https://github.com/npm/cli/issues/4460
80-
# run: |
81-
# npm i -g npm-package-lock-add-resolved@1.1.4
82-
# npm-package-lock-add-resolved
83-
# git --no-pager diff --exit-code
78+
- name: Validate package-lock.json # See https://github.com/npm/cli/issues/4460
79+
run: |
80+
npm i -g npm-package-lock-add-resolved@1.1.4
81+
npm-package-lock-add-resolved
82+
git --no-pager diff --exit-code
8483
8584
- name: Install dependencies & build
8685
env:

0 commit comments

Comments
 (0)