Merge pull request #63161 from bahman026/fix/noid/files-external-ftp-empty-port

fix(ftp): handle empty port parameter and ensure strictly numeric ports

Author: provokateurin

apps/files_external/lib/Lib/Storage/FTP.php

@@ -49,7 +49,8 @@ public function __construct(array $parameters) {
 				$this->secure = false;
 			}
 			$this->root = isset($parameters['root']) ? '/' . ltrim($parameters['root']) : '/';
-			$this->port = $parameters['port'] ?? 21;
+			$parsedPort = $parameters['port'] ?? null;
+			$this->port = is_numeric($parsedPort) ? (int)$parsedPort : 21;
 			$this->utf8Mode = isset($parameters['utf8']) && $parameters['utf8'];
 		} else {
 			throw new \Exception('Creating ' . self::class . ' storage failed, required parameters not set');

apps/files_external/tests/FtpTest.php

@@ -0,0 +1,40 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Files_External\Tests;
+
+use OCA\Files_External\Lib\Storage\FTP;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Test\TestCase;
+
+class FtpTest extends TestCase {
+	public static function portProvider(): array {
+		$parameters = [
+			'host' => 'somehost',
+			'user' => 'someuser',
+			'password' => 'somepassword',
+		];
+
+		return [
+			'no port given' => [$parameters, 21],
+			'empty port' => [array_merge($parameters, ['port' => '']), 21],
+			'null port' => [array_merge($parameters, ['port' => null]), 21],
+			'non numeric port' => [array_merge($parameters, ['port' => 'ftp']), 21],
+			'numeric string port' => [array_merge($parameters, ['port' => '2121']), 2121],
+			'integer port' => [array_merge($parameters, ['port' => 2121]), 2121],
+		];
+	}
+
+	#[DataProvider('portProvider')]
+	public function testPort(array $parameters, int $expectedPort): void {
+		$instance = new FTP($parameters);
+
+		$this->assertSame($expectedPort, self::invokePrivate($instance, 'port'));
+	}
+}