Skip to content

Commit 4cba8a6

Browse files
fix: make unified filter chip accessible
Signed-off-by: Kristian Zendato <kristian.zendato@nextcloud.com>
1 parent cbdff85 commit 4cba8a6

20 files changed

Lines changed: 125 additions & 175 deletions

core/src/components/UnifiedSearch/SearchFilterChip.vue

Lines changed: 0 additions & 113 deletions
This file was deleted.

core/src/components/UnifiedSearch/UnifiedSearchModal.vue

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -135,12 +135,12 @@
135135
</NcCheckboxRadioSwitch>
136136
</div>
137137
<div class="unified-search-modal__filters-applied">
138-
<FilterChip
138+
<NcChip
139139
v-for="filter in filters"
140140
:key="filter.id"
141141
:text="filter.name ?? filter.text"
142-
pretext=""
143-
@delete="removeFilter(filter)">
142+
:aria-label-close="t('core', 'Remove filter: {text}', { text: filter.name ?? filter.text })"
143+
@close="removeFilter(filter)">
144144
<template #icon>
145145
<NcAvatar
146146
v-if="filter.type === 'person'"
@@ -150,9 +150,13 @@
150150
hideStatus
151151
:hideFavorite="false" />
152152
<IconCalendarBlankOutline v-else-if="filter.type === 'date'" />
153-
<img v-else :src="filter.icon" alt="">
153+
<img
154+
v-else
155+
:src="filter.icon"
156+
class="unified-search-modal__filter-icon"
157+
alt="">
154158
</template>
155-
</FilterChip>
159+
</NcChip>
156160
</div>
157161
</div>
158162

@@ -255,6 +259,7 @@ import NcActions from '@nextcloud/vue/components/NcActions'
255259
import NcAvatar from '@nextcloud/vue/components/NcAvatar'
256260
import NcButton from '@nextcloud/vue/components/NcButton'
257261
import NcCheckboxRadioSwitch from '@nextcloud/vue/components/NcCheckboxRadioSwitch'
262+
import NcChip from '@nextcloud/vue/components/NcChip'
258263
import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent'
259264
import NcTextField from '@nextcloud/vue/components/NcTextField'
260265
import IconAccountMultipleOutline from 'vue-material-design-icons/AccountMultipleOutline.vue'
@@ -267,7 +272,6 @@ import IconMagnify from 'vue-material-design-icons/Magnify.vue'
267272
import IconShapeOutline from 'vue-material-design-icons/ShapeOutline.vue'
268273
import CustomDateRangeModal from './CustomDateRangeModal.vue'
269274
import SearchableList from './SearchableList.vue'
270-
import FilterChip from './SearchFilterChip.vue'
271275
import SearchResult from './SearchResult.vue'
272276
import { useUnifiedSearch } from '../../composables/useUnifiedSearch.ts'
273277
import { unifiedSearchLogger } from '../../logger.js'
@@ -293,11 +297,11 @@ export default defineComponent({
293297
IconShapeOutline,
294298
295299
CustomDateRangeModal,
296-
FilterChip,
297300
NcActions,
298301
NcActionButton,
299302
NcAvatar,
300303
NcButton,
304+
NcChip,
301305
NcEmptyContent,
302306
NcCheckboxRadioSwitch,
303307
NcTextField,
@@ -1439,6 +1443,14 @@ export default defineComponent({
14391443
padding-top: 4px;
14401444
display: flex;
14411445
flex-wrap: wrap;
1446+
gap: var(--default-grid-baseline);
1447+
}
1448+
1449+
&__filter-icon {
1450+
width: 20px;
1451+
height: 20px;
1452+
object-fit: contain;
1453+
filter: var(--background-invert-if-bright);
14421454
}
14431455
14441456
&__no-content {

core/src/tests/components/SearchFilterChip.spec.ts

Lines changed: 0 additions & 39 deletions
This file was deleted.

dist/1598-1598.js

Lines changed: 0 additions & 2 deletions
This file was deleted.

dist/1598-1598.js.map

Lines changed: 0 additions & 1 deletion
This file was deleted.

dist/1598-1598.js.map.license

Lines changed: 0 additions & 1 deletion
This file was deleted.

dist/6692-6692.js

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/6692-6692.js.map

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/6692-6692.js.map.license

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
6692-6692.js.license

0 commit comments

Comments
 (0)