fix: clarify trashbin expiration CLI help

Fixes #45418

Author: mvanhorn

apps/files_trashbin/lib/Command/ExpireTrash.php

@@ -35,11 +35,12 @@ protected function configure(): void {
 		parent::configure();
 		$this
 			->setName('trashbin:expire')
-			->setDescription('Expires the users trashbin')
+			->setDescription('Delete eligible trashbin entries according to the configured retention and space policy')
+			->setHelp('Processes deleted files according to the configured trashbin retention and space policy. This does not disable the trashbin or unconditionally empty it.')
 			->addArgument(
 				'user_id',
 				InputArgument::OPTIONAL | InputArgument::IS_ARRAY,
-				'expires the trashbin of the given user(s), if no user is given the trash for all users will be expired'
+				'Limit processing to the given user ID(s); if no user ID is given, all users are processed'
 			);
 	}
 

apps/files_trashbin/tests/Command/ExpireTrashTest.php

@@ -66,6 +66,28 @@ protected function tearDown(): void {
 		parent::tearDown();
 	}
 
+	public function testCommandMetadata(): void {
+		$command = new ExpireTrash(
+			Server::get(IUserManager::class),
+			$this->expiration,
+			Server::get(SetupManager::class),
+			Server::get(IRootFolder::class),
+		);
+
+		$this->assertSame(
+			'Delete eligible trashbin entries according to the configured retention and space policy',
+			$command->getDescription(),
+		);
+		$this->assertSame(
+			'Processes deleted files according to the configured trashbin retention and space policy. This does not disable the trashbin or unconditionally empty it.',
+			$command->getHelp(),
+		);
+		$this->assertSame(
+			'Limit processing to the given user ID(s); if no user ID is given, all users are processed',
+			$command->getDefinition()->getArgument('user_id')->getDescription(),
+		);
+	}
+
 	#[DataProvider(methodName: 'retentionObligationProvider')]
 	public function testRetentionObligation(string $obligation, string $quota, int $elapsed, int $fileSize, bool $shouldExpire): void {
 		$this->config->setSystemValues(['trashbin_retention_obligation' => $obligation]);