feat(share): make ShareReviewEntry timestamps explicit and add canManage

Replace the time/timestamp string-int duo with a required
lastModifiedTimestamp, turn expiration into an expiration timestamp, rename
password to hasPassword and model the manage capability as a dedicated flag
so the permissions field fits int-mask-of<Constants::PERMISSION_*>.

Assisted-by: Claude Code:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Author: AndyScherzinger

lib/public/Share/ShareReview/ShareReviewEntry.php

@@ -10,6 +10,8 @@
 namespace OCP\Share\ShareReview;
 
 use OCP\AppFramework\Attribute\Consumable;
+use OCP\Constants;
+use OCP\Share\IShare;
 
 /**
  * Holds a single app-managed share as exposed to a share-review app through
@@ -25,16 +27,22 @@ final class ShareReviewEntry {
 	 * @param string $object Name or title of the shared object, such as a
 	 *                       file path or report name.
 	 * @param string $initiator User ID of the initiator.
-	 * @param int $type {@see \OCP\Share\IShare} type of the share.
+	 * @param IShare::TYPE_* $type {@see \OCP\Share\IShare} type of the share.
 	 * @param string $recipient User ID of the owner or the token of a link.
-	 * @param int $permissions Permissions level of the share.
-	 * @param string $time Creation time of the share.
+	 * @param int $lastModifiedTimestamp Unix timestamp of the share's creation
+	 *                                   or last modification, whichever is
+	 *                                   later; used for sorting and for the
+	 *                                   new-since-last-review filter. Pass 0
+	 *                                   if the app tracks neither.
+	 * @param int-mask-of<Constants::PERMISSION_*> $permissions Permissions level of the share.
 	 * @param string $action Optional deletion identifier override. An empty
 	 *                       string means $id is used.
-	 * @param int|null $timestamp Optional creation Unix timestamp, used for sorting.
-	 * @param bool $password Whether the share is password protected. Never
-	 *                       the password itself.
-	 * @param string|null $expiration Optional expiration date displayed for the share.
+	 * @param bool $hasPassword Whether the share is password protected. Never
+	 *                          the password itself.
+	 * @param bool $canManage Whether the recipient can administer the shared
+	 *                        object and its sharing.
+	 * @param int|null $expirationTimestamp Optional expiration Unix timestamp
+	 *                                      of the share.
 	 * @param string|null $parent Optional identifier of the parent share.
 	 *
 	 * @since 34.0.2
@@ -45,12 +53,12 @@ public function __construct(
 		public readonly string $initiator,
 		public readonly int $type,
 		public readonly string $recipient,
+		public readonly int $lastModifiedTimestamp,
 		public readonly int $permissions = 1,
-		public readonly string $time = '1970-01-01 01:00:00',
 		public readonly string $action = '',
-		public readonly ?int $timestamp = null,
-		public readonly bool $password = false,
-		public readonly ?string $expiration = null,
+		public readonly bool $hasPassword = false,
+		public readonly bool $canManage = false,
+		public readonly ?int $expirationTimestamp = null,
 		public readonly ?string $parent = null,
 	) {
 	}

tests/lib/Share20/ShareReview/ShareReviewEntryTest.php

@@ -22,12 +22,12 @@ public function testHoldsAllFields(): void {
 			initiator: 'alice',
 			type: IShare::TYPE_USER,
 			recipient: 'bob',
+			lastModifiedTimestamp: 1783764000,
 			permissions: 31,
-			time: '2026-07-07 12:00:00',
 			action: 'board-share-42',
-			timestamp: 1783764000,
-			password: true,
-			expiration: '2026-08-01',
+			hasPassword: true,
+			canManage: true,
+			expirationTimestamp: 1785837600,
 			parent: '23',
 		);
 
@@ -36,12 +36,12 @@ public function testHoldsAllFields(): void {
 		$this->assertSame('alice', $entry->initiator);
 		$this->assertSame(IShare::TYPE_USER, $entry->type);
 		$this->assertSame('bob', $entry->recipient);
+		$this->assertSame(1783764000, $entry->lastModifiedTimestamp);
 		$this->assertSame(31, $entry->permissions);
-		$this->assertSame('2026-07-07 12:00:00', $entry->time);
 		$this->assertSame('board-share-42', $entry->action);
-		$this->assertSame(1783764000, $entry->timestamp);
-		$this->assertTrue($entry->password);
-		$this->assertSame('2026-08-01', $entry->expiration);
+		$this->assertTrue($entry->hasPassword);
+		$this->assertTrue($entry->canManage);
+		$this->assertSame(1785837600, $entry->expirationTimestamp);
 		$this->assertSame('23', $entry->parent);
 	}
 
@@ -52,14 +52,15 @@ public function testDefaults(): void {
 			initiator: 'alice',
 			type: IShare::TYPE_LINK,
 			recipient: 'sToKeN',
+			lastModifiedTimestamp: 0,
 		);
 
+		$this->assertSame(0, $entry->lastModifiedTimestamp);
 		$this->assertSame(1, $entry->permissions);
-		$this->assertSame('1970-01-01 01:00:00', $entry->time);
 		$this->assertSame('', $entry->action);
-		$this->assertNull($entry->timestamp);
-		$this->assertFalse($entry->password);
-		$this->assertNull($entry->expiration);
+		$this->assertFalse($entry->hasPassword);
+		$this->assertFalse($entry->canManage);
+		$this->assertNull($entry->expirationTimestamp);
 		$this->assertNull($entry->parent);
 	}
 }