fix(dashboard): make tests also work at night

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Author: susnux

apps/dashboard/src/DashboardApp.vue

@@ -234,28 +234,28 @@ export default {
 			const good = {
 				morning: {
 					generic: t('dashboard', 'Good morning'),
-					withName: t('dashboard', 'Good morning, {name}', { name: this.displayName }, undefined, { escape: false }),
+					withName: t('dashboard', 'Good morning, {name}', { name: this.displayName }, { escape: false }),
 				},
 
 				afternoon: {
 					generic: t('dashboard', 'Good afternoon'),
-					withName: t('dashboard', 'Good afternoon, {name}', { name: this.displayName }, undefined, { escape: false }),
+					withName: t('dashboard', 'Good afternoon, {name}', { name: this.displayName }, { escape: false }),
 				},
 
 				evening: {
 					generic: t('dashboard', 'Good evening'),
-					withName: t('dashboard', 'Good evening, {name}', { name: this.displayName }, undefined, { escape: false }),
+					withName: t('dashboard', 'Good evening, {name}', { name: this.displayName }, { escape: false }),
 				},
 
 				night: {
 					// Don't use "Good night" as it's not a greeting
-					generic: t('dashboard', 'Hello'),
-					withName: t('dashboard', 'Hello, {name}', { name: this.displayName }, undefined, { escape: false }),
+					generic: t('dashboard', 'Hello') /* TRANSLATORS: Greeting to be used at night (in English there is no specific greeting, think of it like "good morning") */,
+					withName: t('dashboard', 'Hello, {name}', { name: this.displayName }, { escape: false }) /* TRANSLATORS: Greeting to be used at night (in English there is no specific greeting, think of it like "Good morning, J. Doe" but at night) */,
 				},
 
 				birthday: {
 					generic: t('dashboard', 'Happy birthday 🥳🤩🎂🎉'),
-					withName: t('dashboard', 'Happy birthday, {name} 🥳🤩🎂🎉', { name: this.displayName }, undefined, { escape: false }),
+					withName: t('dashboard', 'Happy birthday, {name} 🥳🤩🎂🎉', { name: this.displayName }, { escape: false }),
 				},
 			}
 

tests/playwright/e2e/dashboard/widget-performance.spec.ts

@@ -27,7 +27,7 @@ test('dashboard: only loads the data of enabled widgets', async ({ page, user })
 
 	const loaded = page.waitForResponse((r) => WIDGET_ITEMS_API.test(r.url()))
 	await page.goto('apps/dashboard')
-	await expect(page.getByRole('heading', { name: /Good (morning|afternoon|evening|night)/ })).toBeVisible()
+	await expect(page.getByRole('heading', { name: /(Good (morning|afternoon|evening)|Hello)/ })).toBeVisible()
 	await loaded
 
 	// Give any further (unwanted) widget request time to be fired …