test: try to un-flaky cypress

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Author: susnux

cypress.config.ts

@@ -8,7 +8,7 @@ import { configureNextcloud, docker, getContainer, getContainerName, runExec, ru
 import { defineConfig } from 'cypress'
 import cypressSplit from 'cypress-split'
 import vitePreprocessor from 'cypress-vite'
-import { existsSync, rmdirSync } from 'node:fs'
+import { existsSync, rmSync } from 'node:fs'
 import { dirname, join, resolve } from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { nodePolyfills } from 'vite-plugin-node-polyfills'
@@ -27,7 +27,7 @@ export default defineConfig({
 
 	// Tries again when in run mode (cypress run) e.g. on CI
 	retries: {
-		runMode: 3,
+		runMode: 5,
 		// do not retry in `cypress open`
 		openMode: 0,
 	},
@@ -82,11 +82,11 @@ export default defineConfig({
 				deleteFolder(path: string) {
 					try {
 						if (existsSync(path)) {
-							rmdirSync(path, { maxRetries: 10, recursive: true })
+							rmSync(path, { maxRetries: 10, recursive: true })
 						}
 						return null
 					} catch (error) {
-						throw Error(`Error while deleting ${path}. Original error: ${error}`)
+						throw Error(`Error while deleting ${path}. Original error: ${error}`, { cause: error })
 					}
 				},
 			})

cypress/e2e/files/FilesUtils.ts

@@ -35,11 +35,18 @@ export function getActionEntryForFileId(fileid: number, actionId: string) {
  * @param actionId
  */
 export function getActionEntryForFile(file: string, actionId: string) {
-	return getActionButtonForFile(file)
+	getActionButtonForFile(file)
+		.as('actionButton')
+	cy.get('@actionButton')
 		.should('have.attr', 'aria-controls')
-		.then((menuId) => cy.get(`#${menuId}`)
-			.should('exist')
-			.find(`[data-cy-files-list-row-action="${CSS.escape(actionId)}"]`))
+	return cy.get('@actionButton')
+		.then((menuId) => {
+			cy.get(`#${menuId}`)
+				.should('exist')
+				.as('actionMenu')
+			return cy.get('@actionMenu')
+				.find(`[data-cy-files-list-row-action="${CSS.escape(actionId)}"]`)
+		})
 }
 
 /**
@@ -89,6 +96,8 @@ export function triggerActionForFile(filename: string, actionId: string) {
 	getActionButtonForFile(filename)
 		.click({ force: true }) // force to avoid issues with overlaying file list header
 	getActionEntryForFile(filename, actionId)
+		.as('actionEntry')
+	cy.get('@actionEntry')
 		.find('button')
 		.should('be.visible')
 		.click()