fix(core): add rate limit and extract people menu types

Assisted-by: Cursor:Composer
Co-authored-by: Cursor <cursoragent@cursor.com>

Author: kristian-zendato

core/Controller/ContactsMenuController.php

@@ -13,6 +13,7 @@
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\Attribute\FrontpageRoute;
 use OCP\AppFramework\Http\Attribute\NoAdminRequired;
+use OCP\AppFramework\Http\Attribute\UserRateLimit;
 use OCP\AppFramework\Http\JSONResponse;
 use OCP\Contacts\ContactsMenu\IEntry;
 use OCP\ICacheFactory;
@@ -85,6 +86,7 @@ public function getTeams(): array {
 	 * @throws Exception
 	 */
 	#[NoAdminRequired]
+	#[UserRateLimit(limit: 30, period: 300)]
 	#[FrontpageRoute(verb: 'GET', url: '/contactsmenu/preview-avatars')]
 	public function previewAvatars(?string $teamId = null): array {
 		$user = $this->userSession->getUser();

core/src/tests/views/ContactsMenu.spec.ts

@@ -3,6 +3,8 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
+import type { IPreviewUser } from '../../types/contactsMenu.ts'
+
 import { cleanup, findAllByRole, render } from '@testing-library/vue'
 import { afterEach, describe, expect, it, vi } from 'vitest'
 import ContactsMenu from '../../views/ContactsMenu.vue'
@@ -19,15 +21,10 @@ vi.mock('@nextcloud/auth', () => ({
 
 afterEach(cleanup)
 
-function mockDefaultGets(previewUsers: Array<{ uid: string, fullName: string, isUser?: boolean }> = []) {
+function mockDefaultGets(previewUsers: IPreviewUser[] = []) {
 	axios.get.mockImplementation(async (url: string) => {
 		if (String(url).includes('/contactsmenu/preview-avatars')) {
-			return {
-				data: previewUsers.map((user) => ({
-					isUser: true,
-					...user,
-				})),
-			}
+			return { data: previewUsers }
 		}
 		return { data: [] }
 	})

core/src/types/contactsMenu.ts

@@ -0,0 +1,10 @@
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+export interface IPreviewUser {
+	uid: string
+	fullName: string
+	isUser: boolean
+}

core/src/views/ContactsMenu.vue

@@ -4,6 +4,8 @@
 -->
 
 <script setup lang="ts">
+import type { IPreviewUser } from '../types/contactsMenu.ts'
+
 import { mdiAccountGroupOutline, mdiContacts, mdiMagnify } from '@mdi/js'
 import { getCurrentUser } from '@nextcloud/auth'
 import axios from '@nextcloud/axios'
@@ -24,12 +26,6 @@ import NcTextField from '@nextcloud/vue/components/NcTextField'
 import ContactMenuEntry from '../components/ContactsMenu/ContactMenuEntry.vue'
 import logger from '../logger.js'
 
-interface IPreviewUser {
-	uid: string
-	fullName: string
-	isUser: boolean
-}
-
 const storage = getBuilder('core:contacts')
 	.persist(true)
 	.clearOnLogout(true)