Merge pull request #62155 from nextcloud/backport/61858/stable31

[stable31] test: fix HEIC tests

Author: AndyScherzinger

.github/workflows/phpunit-sqlite.yml

@@ -90,6 +90,21 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Enable HEIC support in ImageMagick
+        run: |
+          # The HEIC preview tests need ImageMagick to actually decode HEIC files.
+          # GitHub-hosted runners register the HEIC coder (so the tests are not
+          # skipped) but decoding fails because the libheif delegate is missing
+          # and/or the coder is blocked by ImageMagick's security policy. Install
+          # the delegate and allow the HEIC/HEIF/AVIF coders so decoding succeeds.
+          sudo apt-get update
+          sudo apt-get install -y --no-install-recommends libheif1 libheif-dev
+          for policy in /etc/ImageMagick-{6,7}/policy.xml; do
+            if [ -f "$policy" ]; then
+              sudo sed -i -E 's/rights="none" pattern="(HEIC|HEIF|AVIF)"/rights="read|write" pattern="\1"/g' "$policy"
+            fi
+          done
+
       - name: Set up dependencies
         run: composer i
 

tests/lib/Preview/HEICTest.php

@@ -6,6 +6,8 @@
 
 namespace Test\Preview;
 
+use OC\Preview\HEIC;
+
 /**
  * Class BitmapTest
  *
@@ -17,14 +19,27 @@ class HEICTest extends Provider {
 	protected function setUp(): void {
 		if (!in_array('HEIC', \Imagick::queryFormats('HEI*'))) {
 			$this->markTestSkipped('ImageMagick is not HEIC aware. Skipping tests');
-		} else {
-			parent::setUp();
+		}
+
+		$fileName = 'testimage.heic';
+		$sourcePath = \OC::$SERVERROOT . '/tests/data/' . $fileName;
 
-			$fileName = 'testimage.heic';
-			$this->imgPath = $this->prepareTestFile($fileName, \OC::$SERVERROOT . '/tests/data/' . $fileName);
-			$this->width = 1680;
-			$this->height = 1050;
-			$this->provider = new \OC\Preview\HEIC;
+		// queryFormats() only reports that the HEIC coder is registered, not that
+		// ImageMagick can actually decode a HEIC file: the libheif delegate may be
+		// missing or the coder may be disabled by ImageMagick's policy.xml. In that
+		// case decoding throws, the provider returns null and the tests fail instead
+		// of being skipped. Verify a real decode before running the tests.
+		try {
+			(new \Imagick())->readImage($sourcePath . '[0]');
+		} catch (\ImagickException $e) {
+			$this->markTestSkipped('ImageMagick cannot decode HEIC in this environment: ' . $e->getMessage() . '. Skipping tests');
 		}
+
+		parent::setUp();
+
+		$this->imgPath = $this->prepareTestFile($fileName, $sourcePath);
+		$this->width = 1680;
+		$this->height = 1050;
+		$this->provider = new HEIC;
 	}
 }