fix: only store dav pagination if there are more items than requested

Signed-off-by: Robin Appelman <robin@icewind.nl>

Author: icewind1991

apps/dav/lib/Paginate/PaginatePlugin.php

@@ -59,17 +59,21 @@ public function onMultiStatus(&$fileProperties): void {
 			$offset = (int)$request->getHeader(self::PAGINATE_OFFSET_HEADER);
 
 			$copyIterator = new LimitedCopyIterator($fileProperties, $pageSize, $offset);
-			// wrap the iterator with another that renders XML, this way we
-			// cache XML, but we keep the first $pageSize elements as objects
-			// to use for the response of the first page.
-			$rendererGenerator = $this->getXmlRendererGenerator($copyIterator);
-			['token' => $token, 'count' => $count] = $this->cache->store($url, $rendererGenerator);
+
+			if ($copyIterator->hasOthers()) {
+				// wrap the iterator with another that renders XML, this way we
+				// cache XML, but we keep the first $pageSize elements as objects
+				// to use for the response of the first page.
+				$rendererGenerator = $this->getXmlRendererGenerator($copyIterator);
+				['token' => $token, 'count' => $count] = $this->cache->store($url, $rendererGenerator);
+
+				$this->server->httpResponse->addHeader(self::PAGINATE_HEADER, 'true');
+				$this->server->httpResponse->addHeader(self::PAGINATE_TOKEN_HEADER, $token);
+				$this->server->httpResponse->addHeader(self::PAGINATE_TOTAL_HEADER, (string)$count);
+				$request->setHeader(self::PAGINATE_TOKEN_HEADER, $token);
+			}
 
 			$fileProperties = $copyIterator->getRequestedItems();
-			$this->server->httpResponse->addHeader(self::PAGINATE_HEADER, 'true');
-			$this->server->httpResponse->addHeader(self::PAGINATE_TOKEN_HEADER, $token);
-			$this->server->httpResponse->addHeader(self::PAGINATE_TOTAL_HEADER, (string)$count);
-			$request->setHeader(self::PAGINATE_TOKEN_HEADER, $token);
 		}
 	}