feat(lookup): search for local account only via lookupserver

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Author: ArtificialOwl

core/AppInfo/ConfigLexicon.php

@@ -28,6 +28,7 @@ class ConfigLexicon implements ILexicon {
 	public const SHARE_LINK_EXPIRE_DATE_ENFORCED = 'shareapi_enforce_expire_date';
 	public const USER_LANGUAGE = 'lang';
 	public const OCM_DISCOVERY_ENABLED = 'ocm_discovery_enabled';
+	public const LOOKUP_LOCAL_ACCOUNT_SEARCH = 'lus_local_account_search';
 
 	public const USER_LOCALE = 'locale';
 	public const USER_TIMEZONE = 'timezone';
@@ -93,6 +94,7 @@ public function getAppConfigs(): array {
 			),
 			new Entry(self::LASTCRON_TIMESTAMP, ValueType::INT, 0, 'timestamp of last cron execution'),
 			new Entry(self::OCM_DISCOVERY_ENABLED, ValueType::BOOL, true, 'enable/disable OCM'),
+			new Entry(self::LOOKUP_LOCAL_ACCOUNT_SEARCH, ValueType::BOOL, false, 'use lookup result only when searching for local account'),
 			new Entry(self::UNIFIED_SEARCH_MIN_SEARCH_LENGTH, ValueType::INT, 1, 'Minimum search length to trigger the request', rename: 'unified-search.min-search-length'),
 			new Entry(self::UNIFIED_SEARCH_MAX_RESULTS_PER_REQUEST, ValueType::INT, 25, 'Maximum results returned per search request', rename: 'unified-search.max-results-per-request'),
 			new Entry(

lib/private/Collaboration/Collaborators/LookupPlugin.php

@@ -7,13 +7,15 @@
 
 namespace OC\Collaboration\Collaborators;
 
+use OC\Core\AppInfo\ConfigLexicon;
 use OCA\Federation\TrustedServers;
 use OCP\Collaboration\Collaborators\ISearchPlugin;
 use OCP\Collaboration\Collaborators\ISearchResult;
 use OCP\Collaboration\Collaborators\SearchResultType;
 use OCP\Federation\ICloudIdManager;
 use OCP\GlobalScale\IConfig as GlobalScaleConfig;
 use OCP\Http\Client\IClientService;
+use OCP\IAppConfig;
 use OCP\IConfig;
 use OCP\IUserSession;
 use OCP\Share\IShare;
@@ -24,6 +26,7 @@ class LookupPlugin implements ISearchPlugin {
 	private string $currentUserRemote;
 
 	public function __construct(
+		private readonly IAppConfig $appConfig,
 		private readonly IConfig $config,
 		private readonly IClientService $clientService,
 		IUserSession $userSession,
@@ -77,7 +80,7 @@ public function search($search, $limit, $offset, ISearchResult $searchResult): b
 					]);
 					continue;
 				}
-				if ($this->currentUserRemote === $remote) {
+				if ($this->currentUserRemote === $remote && !$this->appConfig->getValueBool('core', ConfigLexicon::LOOKUP_LOCAL_ACCOUNT_SEARCH)) {
 					continue;
 				}
 				$name = $lookup['name']['value'] ?? '';

lib/private/Collaboration/Collaborators/Search.php

@@ -7,11 +7,13 @@
 
 namespace OC\Collaboration\Collaborators;
 
+use OC\Core\AppInfo\ConfigLexicon;
 use OCP\AppFramework\QueryException;
 use OCP\Collaboration\Collaborators\ISearch;
 use OCP\Collaboration\Collaborators\ISearchPlugin;
 use OCP\Collaboration\Collaborators\ISearchResult;
 use OCP\Collaboration\Collaborators\SearchResultType;
+use OCP\IAppConfig;
 use OCP\IContainer;
 use OCP\Share\IShare;
 
@@ -20,6 +22,7 @@ class Search implements ISearch {
 
 	public function __construct(
 		private IContainer $container,
+		private readonly IAppConfig $appConfig,
 	) {
 	}
 
@@ -47,6 +50,9 @@ public function search($search, array $shareTypes, $lookup, $limit, $offset): ar
 			foreach ($this->pluginList[$type] as $plugin) {
 				/** @var ISearchPlugin $searchPlugin */
 				$searchPlugin = $this->container->resolve($plugin);
+				if ($searchPlugin instanceof UserPlugin && $lookup && $this->appConfig->getValueBool('core', ConfigLexicon::LOOKUP_LOCAL_ACCOUNT_SEARCH)) {
+					continue;
+				}
 				$hasMoreResults = $searchPlugin->search($search, $limit, $offset, $searchResult) || $hasMoreResults;
 			}
 		}

lib/private/Server.php

@@ -1038,7 +1038,7 @@ public function __construct(
 		$this->registerAlias(\OCP\Share\IManager::class, \OC\Share20\Manager::class);
 
 		$this->registerService(ISearch::class, function (Server $c): ISearch {
-			$instance = new Search($c);
+			$instance = new Search($c, $c->get(IAppConfig::class));
 
 			// register default plugins
 			$instance->registerPlugin(['shareType' => 'SHARE_TYPE_USER', 'class' => UserPlugin::class]);

tests/lib/Collaboration/Collaborators/LookupPluginTest.php

@@ -19,6 +19,7 @@
 use OCP\Http\Client\IClient;
 use OCP\Http\Client\IClientService;
 use OCP\Http\Client\IResponse;
+use OCP\IAppConfig;
 use OCP\IConfig;
 use OCP\IUser;
 use OCP\IUserSession;
@@ -29,6 +30,7 @@
 
 class LookupPluginTest extends TestCase {
 	protected IConfig&MockObject $config;
+	protected IAppConfig&MockObject $appConfig;
 	protected GlobalScaleConfig&MockObject $globalScaleConfig;
 	protected IClientService&MockObject $clientService;
 	protected IUserSession&MockObject $userSession;
@@ -44,6 +46,7 @@ protected function setUp(): void {
 		$this->cloudIdManager = $this->createMock(ICloudIdManager::class);
 		$this->config = $this->createMock(IConfig::class);
 		$this->globalScaleConfig = $this->createMock(GlobalScaleConfig::class);
+		$this->appConfig = $this->createMock(IAppConfig::class);
 		$this->logger = $this->createMock(LoggerInterface::class);
 		$this->clientService = $this->createMock(IClientService::class);
 		$cloudId = $this->createMock(ICloudId::class);
@@ -66,6 +69,7 @@ protected function setUp(): void {
 
 		$this->plugin = new LookupPlugin(
 			$this->config,
+			$this->appConfig,
 			$this->clientService,
 			$this->userSession,
 			$this->cloudIdManager,

tests/lib/Collaboration/Collaborators/SearchResultTest.php

@@ -11,22 +11,24 @@
 use OC\Collaboration\Collaborators\SearchResult;
 use OCP\Collaboration\Collaborators\ISearch;
 use OCP\Collaboration\Collaborators\SearchResultType;
+use OCP\IAppConfig;
 use OCP\IContainer;
+use PHPUnit\Framework\MockObject\MockObject;
 use Test\TestCase;
 
 class SearchResultTest extends TestCase {
-	/** @var IContainer|\PHPUnit\Framework\MockObject\MockObject */
-	protected $container;
-	/** @var ISearch */
-	protected $search;
+	protected IContainer&MockObject $container;
+	protected IAppConfig&MockObject $appConfig;
+	protected ISearch $search;
 
 	#[\Override]
 	protected function setUp(): void {
 		parent::setUp();
 
 		$this->container = $this->createMock(IContainer::class);
+		$this->appConfig = $this->createMock(IAppConfig::class);
 
-		$this->search = new Search($this->container);
+		$this->search = new Search($this->container, $this->appConfig);
 	}
 
 	public static function dataAddResultSet(): array {

tests/lib/Collaboration/Collaborators/SearchTest.php

@@ -12,23 +12,25 @@
 use OCP\Collaboration\Collaborators\ISearch;
 use OCP\Collaboration\Collaborators\ISearchPlugin;
 use OCP\Collaboration\Collaborators\SearchResultType;
+use OCP\IAppConfig;
 use OCP\IContainer;
 use OCP\Share\IShare;
+use PHPUnit\Framework\MockObject\MockObject;
 use Test\TestCase;
 
 class SearchTest extends TestCase {
-	/** @var IContainer|\PHPUnit\Framework\MockObject\MockObject */
-	protected $container;
-	/** @var ISearch */
-	protected $search;
+	protected IContainer&MockObject $container;
+	protected IAppConfig&MockObject $appConfig;
+	protected ISearch $search;
 
 	#[\Override]
 	protected function setUp(): void {
 		parent::setUp();
 
 		$this->container = $this->createMock(IContainer::class);
+		$this->appConfig = $this->createMock(IAppConfig::class);
 
-		$this->search = new Search($this->container);
+		$this->search = new Search($this->container, $this->appConfig);
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('dataSearchSharees')]