fix(Share20): Only set random token if no token is set

Signed-off-by: provokateurin <kate@provokateurin.de>

Author: provokateurin

apps/sharebymail/lib/ShareByMailProvider.php

@@ -224,7 +224,9 @@ protected function publishActivity(string $subject, array $parameters, string $a
 	 * @throws \Exception
 	 */
 	protected function createMailShare(IShare $share): string {
-		$share->setToken($this->generateToken());
+		if ($share->getToken() === '') {
+			$share->setToken($this->generateToken());
+		}
 		return $this->addShareToDB(
 			$share->getNodeId(),
 			$share->getNodeType(),

apps/sharebymail/tests/ShareByMailProviderTest.php

@@ -670,7 +670,7 @@ public function testCreateFailed(): void {
 	}
 
 	public function testCreateMailShare(): void {
-		$this->share->expects($this->any())->method('getToken')->willReturn('token');
+		$this->share->expects($this->any())->method('getToken')->willReturn('');
 		$this->share->expects($this->once())->method('setToken')->with('token');
 		$this->share->expects($this->any())->method('getSharedBy')->willReturn('validby@valid.com');
 		$this->share->expects($this->any())->method('getSharedWith')->willReturn('validwith@valid.com');

lib/private/Share20/Manager.php

@@ -567,9 +567,11 @@ public function createShare(IShare $share): IShare {
 				|| $share->getShareType() === IShare::TYPE_EMAIL) {
 				$this->setLinkParent($share);
 
-				$token = $this->generateToken();
-				// Set the unique token
-				$share->setToken($token);
+				if ($share->getToken() === '') {
+					$token = $this->generateToken();
+					// Set the unique token
+					$share->setToken($token);
+				}
 
 				// Verify the expiration date
 				$share = $this->validateExpirationDateLink($share);

lib/private/Share20/Share.php

@@ -60,7 +60,7 @@ class Share implements IShare {
 	/** @var bool */
 	private $sendPasswordByTalk = false;
 	/** @var string */
-	private $token;
+	private $token = '';
 	private ?int $parent = null;
 	/** @var string */
 	private $target;