fix(files_trashbin): remove failed move metadata for file owner

When moving a shared file to the trash fails after its metadata row has been inserted, the failure-cleanup path calls `deleteTrashRow()` with the deleting user.

The row was inserted for the file owner, so this leaves orphaned `files_trash` metadata whenever the owner and deleting user differ.

Doesn't impact success path; just the rollback path.

This change uses `$owner` for the cleanup call, ensuring the inserted metadata row is removed.

Signed-off-by: Josh <josh.t.richards@gmail.com>

Author: joshtrichards

apps/files_trashbin/lib/Trashbin.php

@@ -391,7 +391,9 @@ public static function move2trash($file_path, $ownerOnly = false) {
 					'timestamp' => $timestamp,
 				]
 			);
-			self::deleteTrashRow($user, $filename, $timestamp);
+			// The metadata row belongs to the owner, even when another user initiated
+			// the deletion.
+			self::deleteTrashRow($owner, $filename, $timestamp);
 			if ($trashStorage->file_exists($trashInternalPath)) {
 				if ($trashStorage->is_dir($trashInternalPath)) {
 					$trashStorage->rmdir($trashInternalPath);