fix: address review comments, rename a constant, use a unused constant

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Author: julien-nc

lib/AppInfo/Application.php

@@ -53,7 +53,7 @@ class Application extends App implements IBootstrap {
 		'onyx', 'nova', 'sage', 'shimmer', 'verse'
 	];
 	public const DEFAULT_SUBTITLE_FORMAT = 'srt';
-	public const DEFAULT_SUBTITLE_FORMATS = [
+	public const SUPPORTED_SUBTITLE_FORMATS = [
 		'srt', 'vtt'
 	];
 	public const DEFAULT_DEFAULT_IMAGE_SIZE = '1024x1024';

lib/Service/OpenAiAPIService.php

@@ -930,7 +930,7 @@ public function transcribe(
 
 		$response = $this->request($userId, $endpoint, $params, 'POST', $contentType, serviceType: Application::SERVICE_TYPE_STT);
 
-		if (in_array($responseFormat, Application::DEFAULT_SUBTITLE_FORMATS)) {
+		if (in_array($responseFormat, Application::SUPPORTED_SUBTITLE_FORMATS)) {
 			if (!isset($response['body'])) {
 				$this->logger->warning('Audio subtitling error: ' . json_encode($response));
 				throw new Exception($this->l10n->t('Unknown audio subtitling error'), Http::STATUS_INTERNAL_SERVER_ERROR);

lib/TaskProcessing/AudioToTextSubtitlesProvider.php

@@ -90,7 +90,7 @@ public function getOptionalInputShapeEnumValues(): array {
 	public function getOptionalInputShapeDefaults(): array {
 		return [
 			'language' => 'default',
-			'format' => 'srt',
+			'format' => Application::DEFAULT_SUBTITLE_FORMAT,
 		];
 	}