diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml
index f9f7dc7e..039fa327 100644
--- a/.github/workflows/integration.yml
+++ b/.github/workflows/integration.yml
@@ -26,6 +26,7 @@ jobs:
php-versions: ['8.1']
databases: ['sqlite', 'mysql', 'pgsql']
server-versions: ['stable30']
+ richdocuments-versions: ['stable30']
primary-storage: ['local', 'minio']
name: php${{ matrix.php-versions }}-${{ matrix.databases }}-${{ matrix.server-versions }}-${{ matrix.primary-storage}}
@@ -74,6 +75,14 @@ jobs:
persist-credentials: false
path: apps/${{ env.APP_NAME }}
+ - name: Checkout app (richdocuments)
+ uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+ with:
+ persist-credentials: false
+ path: apps/richdocuments
+ repository: nextcloud/richdocuments
+ ref: ${{ matrix.richdocuments-versions }}
+
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
with:
@@ -91,6 +100,14 @@ jobs:
working-directory: apps/${{ env.APP_NAME }}
run: composer i --no-dev
+ - name: Set up behat dependencies
+ working-directory: apps/${{ env.APP_NAME }}/tests/Integration
+ run: composer i
+
+ - name: Set up dependencies (richdocuments)
+ working-directory: apps/richdocuments
+ run: composer i --no-dev
+
- name: Set up Nextcloud for S3 primary storage
if: matrix.primary-storage == 'minio'
run: |
diff --git a/.github/workflows/phpunit-mariadb.yml b/.github/workflows/phpunit-mariadb.yml
index d3cc10d2..2616d8e4 100644
--- a/.github/workflows/phpunit-mariadb.yml
+++ b/.github/workflows/phpunit-mariadb.yml
@@ -68,21 +68,23 @@ jobs:
matrix:
php-versions: ${{ fromJson(needs.matrix.outputs.php-version) }}
server-versions: ${{ fromJson(needs.matrix.outputs.server-max) }}
- mariadb-versions: ['10.6', '10.11']
+ mariadb-versions: ['10.6', '11.4']
+ richdocuments-versions: ['stable30']
name: MariaDB ${{ matrix.mariadb-versions }} PHP ${{ matrix.php-versions }} Nextcloud ${{ matrix.server-versions }}
services:
mariadb:
- image: ghcr.io/nextcloud/continuous-integration-mariadb-${{ matrix.mariadb-versions }}:latest
+ image: ghcr.io/nextcloud/continuous-integration-mariadb-${{ matrix.mariadb-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 4444:3306/tcp
env:
- MYSQL_ROOT_PASSWORD: rootpassword
- options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 5
+ MARIADB_ROOT_PASSWORD: rootpassword
+ options: --health-cmd="mariadb-admin ping" --health-interval 5s --health-timeout 2s --health-retries 5
steps:
- name: Set app env
+ if: ${{ env.APP_NAME == '' }}
run: |
# Split and keep last
echo "APP_NAME=${GITHUB_REPOSITORY##*/}" >> $GITHUB_ENV
@@ -99,8 +101,16 @@ jobs:
with:
path: apps/${{ env.APP_NAME }}
+ - name: Checkout app (richdocuments)
+ uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+ with:
+ persist-credentials: false
+ path: apps/richdocuments
+ repository: nextcloud/richdocuments
+ ref: ${{ matrix.richdocuments-versions }}
+
- name: Set up php ${{ matrix.php-versions }}
- uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
+ uses: shivammathur/setup-php@0f7f1d08e3e32076e51cae65eb0b0c871405b16e # v2.34.1
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
@@ -127,6 +137,10 @@ jobs:
working-directory: apps/${{ env.APP_NAME }}
run: composer i
+ - name: Set up dependencies (richdocuments)
+ working-directory: apps/richdocuments
+ run: composer i --no-dev
+
- name: Set up Nextcloud
env:
DB_PORT: 4444
diff --git a/.github/workflows/phpunit-mysql.yml b/.github/workflows/phpunit-mysql.yml
index c0f4c69b..81565adb 100644
--- a/.github/workflows/phpunit-mysql.yml
+++ b/.github/workflows/phpunit-mysql.yml
@@ -30,7 +30,7 @@ jobs:
id: versions
uses: icewind1991/nextcloud-version-matrix@58becf3b4bb6dc6cef677b15e2fd8e7d48c0908f # v1.3.1
with:
- matrix: '{"mysql-versions": ["8.4"]}'
+ matrix: '{"mysql-versions": ["8.4"], "richdocuments-versions": ["stable30"]}'
changes:
runs-on: ubuntu-latest-low
@@ -97,6 +97,14 @@ jobs:
with:
path: apps/${{ env.APP_NAME }}
+ - name: Checkout app (richdocuments)
+ uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+ with:
+ persist-credentials: false
+ path: apps/richdocuments
+ repository: nextcloud/richdocuments
+ ref: ${{ matrix.richdocuments-versions }}
+
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
with:
@@ -125,6 +133,10 @@ jobs:
working-directory: apps/${{ env.APP_NAME }}
run: composer i
+ - name: Set up dependencies (richdocuments)
+ working-directory: apps/richdocuments
+ run: composer i --no-dev
+
- name: Set up Nextcloud
env:
DB_PORT: 4444
diff --git a/.github/workflows/phpunit-oci.yml b/.github/workflows/phpunit-oci.yml
index d03beb9d..f4d32bc5 100644
--- a/.github/workflows/phpunit-oci.yml
+++ b/.github/workflows/phpunit-oci.yml
@@ -68,6 +68,7 @@ jobs:
matrix:
php-versions: ${{ fromJson(needs.matrix.outputs.php-version) }}
server-versions: ${{ fromJson(needs.matrix.outputs.server-max) }}
+ richdocuments-versions: ['stable30']
name: OCI PHP ${{ matrix.php-versions }} Nextcloud ${{ matrix.server-versions }}
@@ -110,6 +111,14 @@ jobs:
with:
path: apps/${{ env.APP_NAME }}
+ - name: Checkout app (richdocuments)
+ uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+ with:
+ persist-credentials: false
+ path: apps/richdocuments
+ repository: nextcloud/richdocuments
+ ref: ${{ matrix.richdocuments-versions }}
+
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
with:
@@ -133,6 +142,10 @@ jobs:
working-directory: apps/${{ env.APP_NAME }}
run: composer i
+ - name: Set up dependencies (richdocuments)
+ working-directory: apps/richdocuments
+ run: composer i --no-dev
+
- name: Set up Nextcloud
env:
DB_PORT: 1521
diff --git a/.github/workflows/phpunit-pgsql.yml b/.github/workflows/phpunit-pgsql.yml
index 2a23e02e..6e1f32a4 100644
--- a/.github/workflows/phpunit-pgsql.yml
+++ b/.github/workflows/phpunit-pgsql.yml
@@ -68,6 +68,7 @@ jobs:
matrix:
php-versions: ${{ fromJson(needs.matrix.outputs.php-version) }}
server-versions: ${{ fromJson(needs.matrix.outputs.server-max) }}
+ richdocuments-versions: ['stable30']
name: PostgreSQL PHP ${{ matrix.php-versions }} Nextcloud ${{ matrix.server-versions }}
@@ -100,6 +101,14 @@ jobs:
with:
path: apps/${{ env.APP_NAME }}
+ - name: Checkout app (richdocuments)
+ uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+ with:
+ persist-credentials: false
+ path: apps/richdocuments
+ repository: nextcloud/richdocuments
+ ref: ${{ matrix.richdocuments-versions }}
+
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
with:
@@ -123,6 +132,10 @@ jobs:
working-directory: apps/${{ env.APP_NAME }}
run: composer i
+ - name: Set up dependencies (richdocuments)
+ working-directory: apps/richdocuments
+ run: composer i --no-dev
+
- name: Set up Nextcloud
env:
DB_PORT: 4444
diff --git a/.github/workflows/phpunit-sqlite.yml b/.github/workflows/phpunit-sqlite.yml
index be9e3324..7e751e18 100644
--- a/.github/workflows/phpunit-sqlite.yml
+++ b/.github/workflows/phpunit-sqlite.yml
@@ -68,6 +68,7 @@ jobs:
matrix:
php-versions: ${{ fromJson(needs.matrix.outputs.php-version) }}
server-versions: ${{ fromJson(needs.matrix.outputs.server-max) }}
+ richdocuments-versions: ['stable30']
name: SQLite PHP ${{ matrix.php-versions }} Nextcloud ${{ matrix.server-versions }}
@@ -89,6 +90,14 @@ jobs:
with:
path: apps/${{ env.APP_NAME }}
+ - name: Checkout app (richdocuments)
+ uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+ with:
+ persist-credentials: false
+ path: apps/richdocuments
+ repository: nextcloud/richdocuments
+ ref: ${{ matrix.richdocuments-versions }}
+
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
with:
@@ -112,6 +121,10 @@ jobs:
working-directory: apps/${{ env.APP_NAME }}
run: composer i
+ - name: Set up dependencies (richdocuments)
+ working-directory: apps/richdocuments
+ run: composer i --no-dev
+
- name: Set up Nextcloud
env:
DB_PORT: 4444
diff --git a/lib/AppInfo/Application.php b/lib/AppInfo/Application.php
index 50ded6f6..a061e246 100644
--- a/lib/AppInfo/Application.php
+++ b/lib/AppInfo/Application.php
@@ -17,6 +17,7 @@
use OCP\AppFramework\Bootstrap\IBootContext;
use OCP\AppFramework\Bootstrap\IBootstrap;
use OCP\AppFramework\Bootstrap\IRegistrationContext;
+use OCP\Files\Mount\IMountPoint;
use OCP\Files\Storage\IStorage;
use OCP\Util;
use OCP\WorkflowEngine\Events\RegisterOperationsEvent;
@@ -40,13 +41,14 @@ public function addStorageWrapper(): void {
* @param IStorage $storage
* @return StorageWrapper|IStorage
*/
- public function addStorageWrapperCallback($mountPoint, IStorage $storage) {
+ public function addStorageWrapperCallback($mountPoint, IStorage $storage, IMountPoint $mount) {
if (!OC::$CLI && $mountPoint !== '/') {
/** @var Operation $operation */
$operation = $this->getContainer()->get(Operation::class);
return new StorageWrapper([
'storage' => $storage,
'mountPoint' => $mountPoint,
+ 'mount' => $mount,
'operation' => $operation,
]);
}
diff --git a/lib/CacheWrapper.php b/lib/CacheWrapper.php
index b0c3b45a..8ed22666 100644
--- a/lib/CacheWrapper.php
+++ b/lib/CacheWrapper.php
@@ -9,20 +9,24 @@
namespace OCA\FilesAccessControl;
use OC\Files\Cache\Wrapper\CacheWrapper as Wrapper;
+use OC\Files\Storage\Wrapper\Jail;
use OCP\Constants;
use OCP\Files\Cache\ICache;
use OCP\Files\ForbiddenException;
+use OCP\Files\Mount\IMountPoint;
use OCP\Files\Storage\IStorage;
class CacheWrapper extends Wrapper {
protected readonly int $mask;
+ protected readonly ?IStorage $storage;
public function __construct(
ICache $cache,
- protected readonly IStorage $storage,
+ protected readonly IMountPoint $mountPoint,
protected readonly Operation $operation,
) {
parent::__construct($cache);
+ $this->storage = $mountPoint->getStorage();
$this->mask = Constants::PERMISSION_ALL
& ~Constants::PERMISSION_READ
& ~Constants::PERMISSION_CREATE
@@ -33,7 +37,14 @@ public function __construct(
protected function formatCacheEntry($entry) {
if (isset($entry['path']) && isset($entry['permissions'])) {
try {
- $this->operation->checkFileAccess($this->storage, $entry['path'], $entry['mimetype'] === 'httpd/unix-directory', $entry);
+ $storage = $this->storage;
+ $path = $entry['path'];
+ if ($storage?->instanceOfStorage(Jail::class)) {
+ /** @var Jail $storage */
+ $jailedPath = $storage->getJailedPath($path);
+ $path = $jailedPath ?? $path;
+ }
+ $this->operation->checkFileAccess($path, $this->mountPoint, $entry['mimetype'] === 'httpd/unix-directory', $entry);
} catch (ForbiddenException) {
$entry['permissions'] &= $this->mask;
}
diff --git a/lib/Operation.php b/lib/Operation.php
index c849a872..717ad74d 100644
--- a/lib/Operation.php
+++ b/lib/Operation.php
@@ -18,8 +18,8 @@
use OCP\Files\ForbiddenException;
use OCP\Files\IRootFolder;
use OCP\Files\Mount\IMountManager;
+use OCP\Files\Mount\IMountPoint;
use OCP\Files\Node;
-use OCP\Files\NotFoundException;
use OCP\Files\Storage\IStorage;
use OCP\IL10N;
use OCP\IURLGenerator;
@@ -28,7 +28,6 @@
use OCP\WorkflowEngine\IRuleMatcher;
use OCP\WorkflowEngine\ISpecificOperation;
use Psr\Log\LoggerInterface;
-use ReflectionClass;
use UnexpectedValueException;
class Operation implements IComplexOperation, ISpecificOperation {
@@ -49,20 +48,24 @@ public function __construct(
* @param array|ICacheEntry|null $cacheEntry
* @throws ForbiddenException
*/
- public function checkFileAccess(IStorage $storage, string $path, bool $isDir = false, $cacheEntry = null): void {
- if (!$this->isBlockablePath($storage, $path) || $this->isCreatingSkeletonFiles() || $this->nestingLevel !== 0) {
+ public function checkFileAccess(string $path, IMountPoint $mountPoint, bool $isDir, $cacheEntry = null): void {
+ if (!$this->isBlockablePath($mountPoint, $path) || $this->isCreatingSkeletonFiles() || $this->nestingLevel !== 0) {
// Allow creating skeletons and theming
// https://github.com/nextcloud/files_accesscontrol/issues/5
// https://github.com/nextcloud/files_accesscontrol/issues/12
return;
}
+ $storage = $mountPoint->getStorage();
+ if ($storage === null) {
+ return;
+ }
$this->nestingLevel++;
$filePath = $this->translatePath($storage, $path);
$ruleMatcher = $this->manager->getRuleMatcher();
$ruleMatcher->setFileInfo($storage, $filePath, $isDir);
- $node = $this->getNode($storage, $path, $cacheEntry);
+ $node = $this->getNode($path, $mountPoint, $cacheEntry);
if ($node !== null) {
$ruleMatcher->setEntitySubject($this->fileEntity, $node);
}
@@ -79,24 +82,8 @@ public function checkFileAccess(IStorage $storage, string $path, bool $isDir = f
}
}
- protected function isBlockablePath(IStorage $storage, string $path): bool {
- if (property_exists($storage, 'mountPoint')) {
- $hasMountPoint = $storage instanceof StorageWrapper;
- if (!$hasMountPoint) {
- $ref = new ReflectionClass($storage);
- $prop = $ref->getProperty('mountPoint');
- $hasMountPoint = $prop->isPublic();
- }
-
- if ($hasMountPoint) {
- /** @var StorageWrapper $storage */
- $fullPath = $storage->mountPoint . ltrim($path, '/');
- } else {
- $fullPath = $path;
- }
- } else {
- $fullPath = $path;
- }
+ protected function isBlockablePath(IMountPoint $mountPoint, string $path): bool {
+ $fullPath = $mountPoint->getMountPoint() . ltrim($path, '/');
if (substr_count($fullPath, '/') < 3) {
return false;
@@ -288,41 +275,22 @@ public function onEvent(string $eventName, Event $event, IRuleMatcher $ruleMatch
// Noop
}
- /**
- * @param array|ICacheEntry|null $cacheEntry
- */
- private function getNode(IStorage $storage, string $path, $cacheEntry = null): ?Node {
- $mountPoint = null;
- $mounts = $this->mountManager->findByStorageId($storage->getId());
- foreach ($mounts as $mount) {
- // we don't want to root mount;
- if (strlen($mount->getMountPoint()) > 2) {
- $mountPoint = $mount;
- break;
- }
+ private function getNode(string $path, IMountPoint $mountPoint, ICacheEntry|array|null $cacheEntry = null): ?Node {
+ $fullPath = $mountPoint->getMountPoint() . $path;
+ if (!$cacheEntry) {
+ $cacheEntry = $mountPoint->getStorage()?->getCache()->get($path);
}
-
- if (!$mountPoint) {
+ if (!$cacheEntry) {
return null;
}
- $fullPath = $mountPoint->getMountPoint() . $path;
- if ($cacheEntry) {
- // todo: LazyNode?
- $info = new FileInfo($fullPath, $mountPoint->getStorage(), $path, $cacheEntry, $mountPoint);
- $isDir = $info->getType() === \OCP\Files\FileInfo::TYPE_FOLDER;
- $view = new View('');
- if ($isDir) {
- return new Folder($this->rootFolder, $view, $path, $info);
- } else {
- return new \OC\Files\Node\File($this->rootFolder, $view, $path, $info);
- }
- } else {
- try {
- return $this->rootFolder->get($fullPath);
- } catch (NotFoundException $e) {
- return null;
- }
+ // todo: LazyNode?
+ $info = new FileInfo($fullPath, $mountPoint->getStorage(), $path, $cacheEntry, $mountPoint);
+ $isDir = $info->getType() === \OCP\Files\FileInfo::TYPE_FOLDER;
+ $view = new View('');
+ if ($isDir) {
+ return new Folder($this->rootFolder, $view, $path, $info);
}
+ return new \OC\Files\Node\File($this->rootFolder, $view, $path, $info);
}
}
diff --git a/lib/StorageWrapper.php b/lib/StorageWrapper.php
index 1093eac7..15a471e4 100644
--- a/lib/StorageWrapper.php
+++ b/lib/StorageWrapper.php
@@ -8,11 +8,12 @@
namespace OCA\FilesAccessControl;
-use OC\Files\Cache\Cache;
use OC\Files\Storage\Storage;
use OC\Files\Storage\Wrapper\Wrapper;
use OCP\Constants;
+use OCP\Files\Cache\ICache;
use OCP\Files\ForbiddenException;
+use OCP\Files\Mount\IMountPoint;
use OCP\Files\Storage\IStorage;
use OCP\Files\Storage\IWriteStreamStorage;
@@ -20,6 +21,7 @@ class StorageWrapper extends Wrapper implements IWriteStreamStorage {
protected readonly Operation $operation;
public readonly string $mountPoint;
protected readonly int $mask;
+ protected readonly IMountPoint $mount;
/**
* @param array $parameters
@@ -28,6 +30,7 @@ public function __construct($parameters) {
parent::__construct($parameters);
$this->operation = $parameters['operation'];
$this->mountPoint = $parameters['mountPoint'];
+ $this->mount = $parameters['mount'];
$this->mask = Constants::PERMISSION_ALL
& ~Constants::PERMISSION_READ
@@ -40,7 +43,7 @@ public function __construct($parameters) {
* @throws ForbiddenException
*/
protected function checkFileAccess(string $path, ?bool $isDir = null): void {
- $this->operation->checkFileAccess($this, $path, is_bool($isDir) ? $isDir : $this->is_dir($path));
+ $this->operation->checkFileAccess($path, $this->mount, is_bool($isDir) ? $isDir : $this->is_dir($path));
}
/*
@@ -144,7 +147,7 @@ public function getPermissions($path) {
* see http://php.net/manual/en/function.file_get_contents.php
*
* @param string $path
- * @return string
+ * @return string|false
* @throws ForbiddenException
*/
public function file_get_contents($path) {
@@ -156,8 +159,8 @@ public function file_get_contents($path) {
* see http://php.net/manual/en/function.file_put_contents.php
*
* @param string $path
- * @param string $data
- * @return bool
+ * @param mixed $data
+ * @return int|float|false
* @throws ForbiddenException
*/
public function file_put_contents($path, $data) {
@@ -212,7 +215,7 @@ public function copy($path1, $path2) {
*
* @param string $path
* @param string $mode
- * @return resource
+ * @return resource|bool
* @throws ForbiddenException
*/
public function fopen($path, $mode) {
@@ -239,14 +242,14 @@ public function touch($path, $mtime = null) {
*
* @param string $path
* @param Storage (optional) the storage to pass to the cache
- * @return Cache
+ * @return ICache
*/
public function getCache($path = '', $storage = null) {
if (!$storage) {
$storage = $this;
}
$cache = $this->storage->getCache($path, $storage);
- return new CacheWrapper($cache, $storage, $this->operation);
+ return new CacheWrapper($cache, $this->mount, $this->operation);
}
/**
@@ -255,7 +258,7 @@ public function getCache($path = '', $storage = null) {
* For now the returned array can hold the parameter url - in future more attributes might follow.
*
* @param string $path
- * @return array
+ * @return array|bool
* @throws ForbiddenException
*/
public function getDirectDownload($path) {
@@ -303,7 +306,7 @@ public function writeStream(string $path, $stream, ?int $size = null): int {
$this->checkFileAccess($path, false);
}
- $result = $this->storage->writeStream($path, $stream, $size);
+ $result = parent::writeStream($path, $stream, $size);
if (!$this->isPartFile($path)) {
return $result;
}
@@ -323,4 +326,8 @@ private function isPartFile(string $path): bool {
$extension = pathinfo($path, PATHINFO_EXTENSION);
return $extension === 'part';
}
+
+ public function getMount(): IMountPoint {
+ return $this->mount;
+ }
}
diff --git a/psalm.xml b/psalm.xml
index 4e5bf0bb..82e912be 100644
--- a/psalm.xml
+++ b/psalm.xml
@@ -26,6 +26,10 @@
+
+
+
+
diff --git a/tests/Integration/features/bootstrap/FeatureContext.php b/tests/Integration/features/bootstrap/FeatureContext.php
index 41e87c81..be307711 100644
--- a/tests/Integration/features/bootstrap/FeatureContext.php
+++ b/tests/Integration/features/bootstrap/FeatureContext.php
@@ -45,6 +45,8 @@ class FeatureContext implements Context {
protected string $tagId = '';
protected array $createdUsers = [];
+ protected array $changedConfigs = [];
+
/**
* FeatureContext constructor.
*/
@@ -61,6 +63,12 @@ public function cleanUpBetweenTests() {
$this->setCurrentUser('admin');
$this->sendingTo('DELETE', '/apps/files_accesscontrol_testing');
$this->assertStatusCode($this->response, 200);
+
+ foreach ($this->changedConfigs as $appId => $configs) {
+ foreach ($configs as $config) {
+ $this->sendingTo('DELETE', '/apps/provisioning_api/api/v1/config/apps/' . $appId . '/' . $config);
+ }
+ }
}
/**
@@ -133,6 +141,20 @@ public function userSharesFile(string $sharer, string $file, string $sharee): vo
]);
}
+ /**
+ * @Given /^user "([^"]*)" shares file "([^"]*)" publicly$/
+ */
+ public function userSharesFilePublicly(string $sharer, string $file): void {
+ $this->setCurrentUser($sharer);
+ $this->sendingToWith('POST', '/apps/files_sharing/api/v1/shares', [
+ 'path' => $file,
+ 'permissions' => 19,
+ 'shareType' => 3,
+ ]);
+ $responseBody = json_decode($this->response->getBody()->getContents(), true, flags: JSON_THROW_ON_ERROR);
+ $this->lastShareData = $responseBody['ocs']['data'];
+ }
+
// ChecksumsContext
/**
* @Then The webdav response should have a status code :statusCode
@@ -150,6 +172,18 @@ public function theWebdavResponseShouldHaveAStatusCode($statusCode) {
}
}
+
+ #[\Behat\Step\Given('the following :appId app config is set')]
+ public function setAppConfig(string $appId, TableNode $formData): void {
+ $this->setCurrentUser('admin');
+ foreach ($formData->getRows() as $row) {
+ $this->sendingToWith('POST', '/apps/provisioning_api/api/v1/config/apps/' . $appId . '/' . $row[0], [
+ 'value' => $row[1],
+ ]);
+ $this->changedConfigs[$appId][] = $row[0];
+ }
+ }
+
/**
* User management
*/
diff --git a/tests/Integration/features/bootstrap/WebDav.php b/tests/Integration/features/bootstrap/WebDav.php
index ac1976d9..715a8b8e 100644
--- a/tests/Integration/features/bootstrap/WebDav.php
+++ b/tests/Integration/features/bootstrap/WebDav.php
@@ -19,6 +19,7 @@ trait WebDav {
/** @var int */
private $storedFileID = null;
private array $trashedFiles = [];
+ protected array $lastShareData = [];
/**
* @Given /^using dav path "([^"]*)"$/
@@ -140,17 +141,21 @@ public function downloadFileWithRange($fileSource, $range) {
* @param string $range
*/
public function downloadPublicFileWithRange($range) {
- $token = $this->lastShareData->data->token;
- $fullUrl = $this->baseUrl . "public.php/webdav";
+ $token = $this->lastShareData['token'];
+ $fullUrl = $this->baseUrl . 'public.php/webdav';
$client = new GClient();
$options = [];
- $options['auth'] = [$token, ""];
+ $options['auth'] = [$token, ''];
$options['headers'] = [
'Range' => $range
];
- $this->response = $client->request("GET", $fullUrl, $options);
+ try {
+ $this->response = $client->request('GET', $fullUrl, $options);
+ } catch (\GuzzleHttp\Exception\ClientException $e) {
+ $this->response = $e->getResponse();
+ }
}
/**
@@ -158,8 +163,8 @@ public function downloadPublicFileWithRange($range) {
* @param string $range
*/
public function downloadPublicFileInsideAFolderWithRange($path, $range) {
- $token = $this->lastShareData->data->token;
- $fullUrl = $this->baseUrl . "public.php/webdav" . "$path";
+ $token = $this->lastShareData['token'];
+ $fullUrl = $this->baseUrl . 'public.php/webdav' . "$path";
$client = new GClient();
$options = [
@@ -167,9 +172,13 @@ public function downloadPublicFileInsideAFolderWithRange($path, $range) {
'Range' => $range
]
];
- $options['auth'] = [$token, ""];
+ $options['auth'] = [$token, ''];
- $this->response = $client->request("GET", $fullUrl, $options);
+ try {
+ $this->response = $client->request('GET', $fullUrl, $options);
+ } catch (\GuzzleHttp\Exception\ClientException $e) {
+ $this->response = $e->getResponse();
+ }
}
/**
@@ -189,8 +198,13 @@ public function downloadedContentShouldBe($content) {
*/
public function checkPropForFile($file, $prefix, $prop, $value) {
$elementList = $this->propfindFile($this->currentUser, $file, "<$prefix:$prop/>");
- $property = $elementList['/'.$this->getDavFilesPath($this->currentUser).$file][200]["{DAV:}$prop"];
- Assert::assertEquals($property, $value);
+ if ($prefix === 'oc') {
+ $prefix = '{http://owncloud.org/ns}';
+ } else {
+ $prefix = '{DAV:}';
+ }
+ $property = $elementList['/' . $this->getDavFilesPath($this->currentUser) . $file][200]["$prefix$prop"];
+ Assert::assertEquals($value, $property);
}
/**
diff --git a/tests/Integration/features/mimetypes.feature b/tests/Integration/features/mimetypes.feature
index 63049fd5..dc05adf6 100644
--- a/tests/Integration/features/mimetypes.feature
+++ b/tests/Integration/features/mimetypes.feature
@@ -5,7 +5,7 @@
Given as user "test1"
And using new dav path
- Scenario: Can properly block path detected mimetypes for application/javscript
+ Scenario: Can properly block path detected mimetypes for application/javascript
And user "admin" creates global flow with 200
| name | Admin flow |
| class | OCA\FilesAccessControl\Operation |
diff --git a/tests/Integration/features/sharing-user.feature b/tests/Integration/features/sharing-user.feature
index 577988be..fe8d6418 100644
--- a/tests/Integration/features/sharing-user.feature
+++ b/tests/Integration/features/sharing-user.feature
@@ -172,3 +172,35 @@ Feature: Sharing user
And The webdav response should have a status code "404"
And user "test2" should see following elements
| /nextcloud2.txt |
+
+ Scenario: Downloading is still blocked when Secure View is enabled
+ Given the following files app config is set
+ | watermark_enabled | yes |
+ Given User "test1" uploads file "data/textfile.txt" to "/foobar.txt"
+ And The webdav response should have a status code "201"
+ And user "test1" shares file "/foobar.txt" with user "test2"
+ And as user "test2"
+ When File "/foobar.txt" should have prop "oc:permissions" equal to "SRGDNVW"
+ When Downloading file "/foobar.txt"
+ Then The webdav response should have a status code "200"
+ When Downloading file "/foobar.txt" with range "1-4"
+ Then The webdav response should have a status code "200"
+ And user "test1" shares file "/foobar.txt" publicly
+ And as user "test2"
+ When Downloading last public shared file with range "1-4"
+ Then The webdav response should have a status code "200"
+ And user "admin" creates global flow with 200
+ | name | Admin flow |
+ | class | OCA\FilesAccessControl\Operation |
+ | entity | OCA\WorkflowEngine\Entity\File |
+ | events | [] |
+ | operation | deny |
+ | checks-0 | {"class":"OCA\\WorkflowEngine\\Check\\FileMimeType", "operator": "is", "value": "text/plain"} |
+ And as user "test2"
+ When File "/foobar.txt" should have prop "oc:permissions" equal to "SRD"
+ When Downloading file "/foobar.txt"
+ Then The webdav response should have a status code "404"
+ When Downloading file "/foobar.txt" with range "1-4"
+ Then The webdav response should have a status code "404"
+ When Downloading last public shared file with range "1-4"
+ Then The webdav response should have a status code "404"
diff --git a/tests/Integration/run.sh b/tests/Integration/run.sh
index a8d5910d..e6ab34b1 100755
--- a/tests/Integration/run.sh
+++ b/tests/Integration/run.sh
@@ -16,6 +16,7 @@ composer install
cp -R ./app "../../../${APP_NAME}_testing"
${ROOT_DIR}/occ app:enable $APP_NAME
${ROOT_DIR}/occ app:enable --force "${APP_NAME}_testing"
+${ROOT_DIR}/occ app:enable --force richdocuments
${ROOT_DIR}/occ app:list | grep $APP_NAME
export TEST_SERVER_URL="http://localhost:8080/"
diff --git a/tests/Unit/StorageWrapperTest.php b/tests/Unit/StorageWrapperTest.php
index a6715e19..8cde9a7a 100644
--- a/tests/Unit/StorageWrapperTest.php
+++ b/tests/Unit/StorageWrapperTest.php
@@ -11,6 +11,7 @@
use OCA\FilesAccessControl\Operation;
use OCA\FilesAccessControl\StorageWrapper;
use OCP\Files\ForbiddenException;
+use OCP\Files\Mount\IMountPoint;
use OCP\Files\Storage\IStorage;
use PHPUnit\Framework\MockObject\MockObject;
use Test\TestCase;
@@ -19,11 +20,20 @@ class StorageWrapperTest extends TestCase {
protected IStorage&MockObject $storage;
protected Operation&MockObject $operation;
+ /** @var IMountPoint|MockObject */
+ protected $mountPoint;
+
protected function setUp(): void {
parent::setUp();
$this->storage = $this->createMock(IStorage::class);
$this->operation = $this->createMock(Operation::class);
+
+ $this->mountPoint = $this->createMock(IMountPoint::class);
+ $this->mountPoint->method('getMountPoint')
+ ->willReturn('mountPoint');
+ $this->mountPoint->method('getStorage')
+ ->willReturn($this->storage);
}
protected function getInstance(array $methods = []): StorageWrapper&MockObject {
@@ -32,6 +42,7 @@ protected function getInstance(array $methods = []): StorageWrapper&MockObject {
[
'storage' => $this->storage,
'mountPoint' => 'mountPoint',
+ 'mount' => $this->mountPoint,
'operation' => $this->operation,
]
])
@@ -54,7 +65,7 @@ public function testCheckFileAccess(string $path, bool $isDir): void {
$this->operation->expects($this->once())
->method('checkFileAccess')
- ->with($storage, $path);
+ ->with($path, $this->mountPoint, $isDir);
self::invokePrivate($storage, 'checkFileAccess', [$path, $isDir]);
}
diff --git a/tests/psalm-baseline.xml b/tests/psalm-baseline.xml
index b17e249b..1feed4d5 100644
--- a/tests/psalm-baseline.xml
+++ b/tests/psalm-baseline.xml
@@ -6,18 +6,10 @@
fileEntity]]>
-
-