From 79816a49aee1fb9bc6a1dacf75be18fc6c57173b Mon Sep 17 00:00:00 2001 From: skjnldsv Date: Tue, 16 Jun 2026 09:25:31 +0200 Subject: [PATCH] fix: detect stable branch version from GITHUB_REF for display_version On stable branches, release = 'latest' for HTML builds since DOCS_RELEASE is only set for PDF/ePub. The previous formula str(version_stable + 1) would produce the wrong display version on stable branch HTML builds (e.g. "35" on stable34 docs instead of "34"). Detect the branch number from GITHUB_REF so each stable branch shows its own version in titles and the picker button. Falls back to str(version_stable + 1) on master where GITHUB_REF does not match the stable pattern, preserving existing master behavior. Signed-off-by: skjnldsv --- conf.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/conf.py b/conf.py index e38f607fa53..9b57fe65457 100644 --- a/conf.py +++ b/conf.py @@ -64,7 +64,13 @@ # latest released stable — CHANGING IT MUST RESULT IN A CHANGE OF THE SYMLINK ON THE LIVE SERVER version_stable = 34 # mapped to https://docs.nextcloud.com/server/stable/ -display_version = release if release != 'latest' else str(version_stable + 1) +import re as _re +_stable_branch = _re.match(r'refs/heads/stable(\d+)$', os.environ.get('GITHUB_REF', '')) +display_version = ( + release if release != 'latest' # PDF/ePub builds (DOCS_RELEASE set) + else _stable_branch.group(1) if _stable_branch # HTML builds on stableNN branches + else str(version_stable + 1) # HTML builds on master +) # Also search for "TODO ON RELEASE" in the rst files