fix(propagator): clean up logs related to item completed

each time an item is completed and the info is forwarded to activities
model, we print an useless warning

makes it more clear by improving a previous log with teh same info but
better log level and make all our code to use teh same way to log
completed items

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Author: mgallien

src/gui/tray/usermodel.cpp

@@ -1629,7 +1629,6 @@ void User::slotItemCompleted(const QString &folder, const SyncFileItemPtr &item)
         return;
     }
 
-    qCWarning(lcActivity) << "Item " << item->_file << " retrieved resulted in " << item->_errorString;
     processCompletedSyncItem(folderInstance, item);
 }
 

src/libsync/bulkpropagatordownloadjob.cpp

@@ -59,7 +59,7 @@ PropagatorJob::JobParallelism BulkPropagatorDownloadJob::parallelism() const
 
 void BulkPropagatorDownloadJob::finalizeOneFile(const SyncFileItemPtr &file)
 {
-    Q_EMIT propagator()->itemCompleted(file, ErrorCategory::GenericError);
+    propagator()->emitItemCompleted(file, ErrorCategory::GenericError);
 }
 
 void BulkPropagatorDownloadJob::start()
@@ -159,7 +159,7 @@ void BulkPropagatorDownloadJob::abortWithError(SyncFileItemPtr item, SyncFileIte
     if (item) {
         item->_errorString = error;
         item->_status = status;
-        Q_EMIT propagator()->itemCompleted(item, ErrorCategory::GenericError);
+        propagator()->emitItemCompleted(item, ErrorCategory::GenericError);
     }
     done(status);
 }

src/libsync/bulkpropagatorjob.cpp

@@ -628,7 +628,7 @@ void BulkPropagatorJob::done(SyncFileItemPtr item,
 
     handleJobDoneErrors(item, status);
 
-    Q_EMIT propagator()->itemCompleted(item, category);
+    propagator()->emitItemCompleted(item, category);
 }
 
 QMap<QByteArray, QByteArray> BulkPropagatorJob::headers(SyncFileItemPtr item) const

src/libsync/owncloudpropagator.cpp

@@ -276,12 +276,7 @@ void PropagateItemJob::done(const SyncFileItem::Status statusArg, const QString
         break;
     }
 
-    if (_item->hasErrorStatus()) {
-        qCWarning(lcPropagator) << "Could not complete propagation of" << _item->destination() << "by" << this << "with status" << _item->_status << "and error:" << _item->_errorString;
-    } else {
-        qCInfo(lcPropagator) << "Completed propagation of" << _item->destination() << "by" << this << "with status" << _item->_status;
-    }
-    Q_EMIT propagator()->itemCompleted(_item, category);
+    propagator()->emitItemCompleted(_item, category);
     Q_EMIT finished(_item->_status);
 
     if (_item->_status == SyncFileItem::FatalError) {
@@ -928,6 +923,16 @@ void OwncloudPropagator::scheduleNextJobImpl()
     }
 }
 
+void OwncloudPropagator::emitItemCompleted(const SyncFileItemPtr &item, ErrorCategory category)
+{
+    if (item->hasErrorStatus()) {
+        qCWarning(lcPropagator) << "Could not complete propagation of" << item->destination() << "by" << this << "with status" << item->_status << "and error:" << item->_errorString;
+    } else {
+        qCInfo(lcPropagator) << "Completed propagation of" << item->destination() << "by" << this << "with status" << item->_status;
+    }
+    Q_EMIT itemCompleted(item, category);
+}
+
 void OwncloudPropagator::reportProgress(const SyncFileItem &item, qint64 bytes)
 {
     Q_EMIT progress(item, bytes);

src/libsync/owncloudpropagator.h

@@ -641,8 +641,9 @@ class OWNCLOUDSYNC_EXPORT OwncloudPropagator : public QObject
 
     [[nodiscard]] bool isInBulkUploadBlackList(const QString &file) const;
 
-private Q_SLOTS:
+    void emitItemCompleted(const OCC::SyncFileItemPtr &item, OCC::ErrorCategory category);
 
+private Q_SLOTS:
     void abortTimeout()
     {
         // Abort synchronously and finish