fix(macOS): disable index store for nested xcodebuild invocations

The Xcode scheme drives the developer build through a legacy target with
passBuildSettingsInEnvironment, so the outer build exports its settings —
COMPILER_INDEX_STORE_ENABLE=Default among them — into Craft.sh and on down to
the xcodebuild invocations that build the Finder Sync and File Provider
extensions, which pick them up as setting overrides. INDEX_DATA_STORE_DIR is
not exported with them, and those invocations override SYMROOT without a
derived data path, so in Debug the index store is enabled with nowhere to
write and clang is handed a valueless -index-store-path. It swallows the
argument behind it, which for the Realm package is the include path carrying
realm-core's headers, and the extension fails to build on

    RLMUtil.hpp:23:9: fatal error: 'realm/array.hpp' file not found

Release builds never saw this: COMPILER_INDEX_STORE_ENABLE=Default leaves the
index store off there.

Pass COMPILER_INDEX_STORE_ENABLE=NO on the xcodebuild command lines, where it
outranks the inherited environment, and drop the index store variables in
Craft.sh so a build started from the scheme sees the same environment as one
started from a terminal.

Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: i2h3

shell_integration/MacOSX/CMakeLists.txt

@@ -24,6 +24,14 @@ if(APPLE)
     # hardcoded default in Build.xcconfig. A branded build signed by a different team would
     # then point the extension at an app group it does not own, while the client — which takes
     # the team from CMake — points at the right one, and the two could never reach each other.
+    # COMPILER_INDEX_STORE_ENABLE has to be forced off: the Xcode scheme drives these builds
+    # through a legacy target with passBuildSettingsInEnvironment, so every setting of the outer
+    # build — including COMPILER_INDEX_STORE_ENABLE=Default — is exported into the environment
+    # and picked up here as a setting override. INDEX_DATA_STORE_DIR is not exported with it, and
+    # these invocations override SYMROOT without a derived data path, so in Debug the index store
+    # is enabled with nowhere to write: clang is then handed a bare "-index-store-path" that eats
+    # the following argument. For the Realm package that argument is the include path carrying
+    # realm-core's headers, and the extension fails to build on 'realm/array.hpp' file not found.
     add_custom_target( mac_overlayplugin ALL
         xcodebuild
         ARCHS=${CMAKE_OSX_ARCHITECTURES}
@@ -32,6 +40,7 @@ if(APPLE)
         -target FinderSyncExt
         -configuration ${XCODE_TARGET_CONFIGURATION}
         "SYMROOT=${CMAKE_CURRENT_BINARY_DIR}"
+        "COMPILER_INDEX_STORE_ENABLE=NO"
         "MARKETING_VERSION=${MIRALL_VERSION}"
         "CURRENT_PROJECT_VERSION=${MIRALL_VERSION_BUILD}"
         "OC_OEM_SHARE_ICNS=${OC_OEM_SHARE_ICNS}"
@@ -55,6 +64,7 @@ if(APPLE)
         -target ${OSX_FINDERSYNC_BROKER_TARGET}
         -configuration ${XCODE_TARGET_CONFIGURATION}
         "SYMROOT=${CMAKE_CURRENT_BINARY_DIR}"
+        "COMPILER_INDEX_STORE_ENABLE=NO"
         "MARKETING_VERSION=${MIRALL_VERSION}"
         "CURRENT_PROJECT_VERSION=${MIRALL_VERSION_BUILD}"
         "OC_APPLICATION_NAME=${APPLICATION_NAME}"
@@ -72,6 +82,7 @@ if(APPLE)
             -target FileProviderExt 
             -configuration ${XCODE_TARGET_CONFIGURATION}
             "SYMROOT=${CMAKE_CURRENT_BINARY_DIR}"
+            "COMPILER_INDEX_STORE_ENABLE=NO"
             "MARKETING_VERSION=${MIRALL_VERSION}"
             "CURRENT_PROJECT_VERSION=${MIRALL_VERSION_BUILD}"
             "OC_APPLICATION_EXECUTABLE_NAME=${APPLICATION_EXECUTABLE}"
@@ -90,6 +101,7 @@ if(APPLE)
             -target FileProviderUIExt
             -configuration ${XCODE_TARGET_CONFIGURATION}
             "SYMROOT=${CMAKE_CURRENT_BINARY_DIR}"
+            "COMPILER_INDEX_STORE_ENABLE=NO"
             "MARKETING_VERSION=${MIRALL_VERSION}"
             "CURRENT_PROJECT_VERSION=${MIRALL_VERSION_BUILD}"
             "OC_APPLICATION_EXECUTABLE_NAME=${APPLICATION_EXECUTABLE}"

shell_integration/MacOSX/NextcloudIntegration/NextcloudDev/Craft.sh

@@ -29,6 +29,18 @@ else
     exit 1
 fi
 
+# Xcode exports the settings of the build that started this script into the environment, and
+# every nested xcodebuild down the line takes them as setting overrides. The index store ones
+# travel without INDEX_DATA_STORE_DIR, which makes the extension builds pass clang a bare
+# -index-store-path that swallows the argument behind it. Drop them so a build started from the
+# scheme sees the same environment as one started from a terminal.
+unset COMPILER_INDEX_STORE_ENABLE
+unset INDEX_ENABLE_DATA_STORE
+unset INDEX_DATA_STORE_DIR
+unset INDEX_ENABLE_OPTIMIZATION_LEVEL_OVERRIDE
+unset INDEX_STORE_COMPRESS
+unset INDEX_STORE_ONLY_PROJECT_FILES
+
 swift run mac-crafter \
     --build-path="$DESKTOP_CLIENT_PROJECT_ROOT/build" \
     --product-path="/Applications" \