Skip to content

Commit f378743

Browse files
committed
update psalm stubs and unit tests
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
1 parent 530539d commit f378743

5 files changed

Lines changed: 37 additions & 5 deletions

File tree

‎lib/Listeners/ParticipantCleanupListener.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public function handle(Event $event): void {
5252

5353
if ($event instanceof RemovingCircleMemberEvent) {
5454
$member = $event->getMember();
55-
if ($member !== null && $member->getUserType() === Member::TYPE_USER) {
55+
if ($member->getUserType() === Member::TYPE_USER) {
5656
$this->teamBoardService->handleMemberLeftTeam(
5757
$event->getCircle()->getSingleId(),
5858
$member->getUserId()

‎tests/stub.phpstub‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,16 @@ namespace OCA\Circles\Model {
7373

7474
public function getLevel(): int {}
7575
public function getUserType(): int{}
76+
public function getUserId(): string {}
7677
}
7778

7879
class Circle {
7980
public function getUniqueId(): string {}
8081
public function getDisplayName(): string {}
8182
public function getOwner(): string {}
8283
public function getSingleId(): string {}
84+
/** @return Member[] */
85+
public function getMembers(int $limit = 0): array {}
8386
public function getInheritedMembers(): array {}
8487
public function getInitiator(): Member {}
8588
}
@@ -93,6 +96,11 @@ namespace OCA\Circles\Events {
9396
public function __construct(FederatedEvent $federatedEvent, array $results) {}
9497
abstract public function getCircle(): \OCA\Circles\Model\Circle {}
9598
}
99+
100+
class RemovingCircleMemberEvent extends \OCP\EventDispatcher\Event {
101+
public function getCircle(): \OCA\Circles\Model\Circle {}
102+
public function getMember(): \OCA\Circles\Model\Member {}
103+
}
96104
}
97105
namespace OCA\Circles\Model\Probes {
98106
class CircleProbe {

‎tests/unit/Db/BoardTest.php‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ public function testJsonSerialize() {
3535
'activeSessions' => [],
3636
'ETag' => $board->getETag(),
3737
'shareToken' => null,
38-
'externalId' => null
38+
'externalId' => null,
39+
'teamId' => null,
3940
], $board->jsonSerialize());
4041
}
4142

@@ -61,7 +62,8 @@ public function testUnfetchedValues() {
6162
'activeSessions' => [],
6263
'ETag' => $board->getETag(),
6364
'shareToken' => null,
64-
'externalId' => null
65+
'externalId' => null,
66+
'teamId' => null,
6567
], $board->jsonSerialize());
6668
}
6769

@@ -85,7 +87,8 @@ public function testSetLabels() {
8587
'activeSessions' => [],
8688
'ETag' => $board->getETag(),
8789
'shareToken' => null,
88-
'externalId' => null
90+
'externalId' => null,
91+
'teamId' => null,
8992
], $board->jsonSerialize());
9093
}
9194
public function testSetAcl() {
@@ -117,7 +120,8 @@ public function testSetShared() {
117120
'activeSessions' => [],
118121
'ETag' => $board->getETag(),
119122
'shareToken' => null,
120-
'externalId' => null
123+
'externalId' => null,
124+
'teamId' => null,
121125
], $board->jsonSerialize());
122126
}
123127
}

‎tests/unit/Service/BoardServiceTest.php‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@
2626

2727
namespace OCA\Deck\Service;
2828

29+
if (!class_exists(\OCA\Circles\Model\Circle::class)) {
30+
require_once __DIR__ . '/../stubs/CirclesCircle.php';
31+
}
32+
2933
use OC\Federation\CloudFederationFactory;
3034
use OC\Federation\CloudFederationProviderManager;
3135
use OC\Federation\CloudIdManager;

‎tests/unit/stubs/CirclesCircle.php‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
/**
6+
* SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
7+
* SPDX-License-Identifier: AGPL-3.0-or-later
8+
*/
9+
10+
namespace OCA\Circles\Model;
11+
12+
/**
13+
* Minimal stand-in for unit tests when the Circles app is not installed.
14+
*/
15+
class Circle {
16+
}

0 commit comments

Comments
 (0)