Clean up review findings

- Name the sentinel order in CardOcsController instead of a magic 999
- Drop unreachable stackAddCardAtTop case from ConfigService::get()
- Restore the stronger visibility assertion in the label e2e test

Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>

Author: theoholl

cypress/e2e/cardFeatures.js

@@ -395,7 +395,7 @@ describe('Card', function () {
 			cy.get(`.card:contains("${newCardTitle}")`)
 				.scrollIntoView({ block: 'center' })
 				.find('.labels li:contains("Later")')
-				.should('exist')
+				.should('be.visible')
 			cy.get(`.card:contains("${newCardTitle}")`).find('.labels li:contains("Action needed")')
 				.should('not.exist')
 		})

lib/Controller/CardOcsController.php

@@ -21,6 +21,12 @@
 use OCP\IRequest;
 
 class CardOcsController extends OCSController {
+	/**
+	 * Sentinel order used when the client does not request a specific position.
+	 * Cards created with this order are appended to the end of the stack.
+	 */
+	private const DEFAULT_ORDER = 999;
+
 	public function __construct(
 		string $appName,
 		IRequest $request,
@@ -36,7 +42,7 @@ public function __construct(
 
 	#[NoAdminRequired]
 	#[PublicPage]
-	public function create(string $title, int $stackId, ?int $boardId = null, ?string $type = 'plain', ?string $owner = null, ?int $order = 999, ?string $description = '', $duedate = null, $startdate = null, ?array $labels = [], ?array $users = [], ?string $color = null) {
+	public function create(string $title, int $stackId, ?int $boardId = null, ?string $type = 'plain', ?string $owner = null, ?int $order = self::DEFAULT_ORDER, ?string $description = '', $duedate = null, $startdate = null, ?array $labels = [], ?array $users = [], ?string $color = null) {
 		if ($boardId) {
 			$board = $this->boardService->find($boardId, false);
 			if ($board->getExternalId()) {
@@ -48,7 +54,8 @@ public function create(string $title, int $stackId, ?int $boardId = null, ?strin
 		if (!$owner) {
 			$owner = $this->userId;
 		}
-		$card = $this->cardService->create($title, $stackId, $type, $order, $owner, $description, $duedate, $startdate, $color, insertAtPosition: $order !== 999);
+		// An explicit order means the client wants the card at that position, so shift the surrounding cards
+		$card = $this->cardService->create($title, $stackId, $type, $order, $owner, $description, $duedate, $startdate, $color, insertAtPosition: $order !== self::DEFAULT_ORDER);
 
 		// foreach ($labels as $label) {
 		// 	$this->assignLabel($card->getId(), $label);

lib/Service/ConfigService.php

@@ -91,8 +91,6 @@ public function get(string $key) {
 					return false;
 				}
 				return (bool)$this->config->getUserValue($this->getUserId(), Application::APP_ID, 'cardIdBadge', false);
-			case 'stackAddCardAtTop':
-				return $this->isStackAddCardAtTopEnabled();
 		}
 		return false;
 	}