fix: improve request 4xx error handling (#228)

* fix: improve request 4xx error handling

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>

* chore: rename RequestException4xx to FatalRequestException

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>

* fix: extend FatalRequestException from RuntimeException

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>

---------

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>

Author: kyteinsky

lib/BackgroundJobs/ActionJob.php

@@ -10,6 +10,7 @@
 namespace OCA\ContextChat\BackgroundJobs;
 
 use OCA\ContextChat\Db\QueueActionMapper;
+use OCA\ContextChat\Exceptions\FatalRequestException;
 use OCA\ContextChat\Logger;
 use OCA\ContextChat\Service\DiagnosticService;
 use OCA\ContextChat\Service\LangRopeService;
@@ -125,6 +126,9 @@ protected function run($argument): void {
 					}
 					$this->diagnosticService->sendHeartbeat(static::class, $this->getId());
 					$this->actionMapper->removeFromQueue($entity);
+				} catch (FatalRequestException $e) {
+					$this->logger->warning('Error performing action "' . $entity->getType() . '" and removing it from queue: ' . $e->getMessage(), ['exception' => $e]);
+					$this->actionMapper->removeFromQueue($entity);
 				} catch (\RuntimeException $e) {
 					$this->logger->warning('Error performing action "' . $entity->getType() . '": ' . $e->getMessage(), ['exception' => $e]);
 				}

lib/Exceptions/FatalRequestException.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+
+namespace OCA\ContextChat\Exceptions;
+
+/**
+ * For 4xx responses from the context_chat_backend
+ */
+class FatalRequestException extends \RuntimeException {
+}

lib/Service/LangRopeService.php

@@ -8,6 +8,7 @@
 namespace OCA\ContextChat\Service;
 
 use OCA\ContextChat\AppInfo\Application;
+use OCA\ContextChat\Exceptions\FatalRequestException;
 use OCA\ContextChat\Exceptions\RetryIndexException;
 use OCA\ContextChat\Logger;
 use OCA\ContextChat\Public\IContentProvider;
@@ -42,6 +43,7 @@ public function __construct(
 	 * @param string|null $contentType
 	 * @return array
 	 * @throws RuntimeException
+	 * @throws FatalRequestException
 	 */
 	private function requestToExApp(
 		string $route,
@@ -128,13 +130,6 @@ private function requestToExApp(
 			$params,
 			$options,
 		);
-		if (is_array($response) && isset($response['error'])) {
-			throw new RuntimeException('Error during request to Context Chat Backend (ExApp): ' . $response['error']);
-		}
-		if (is_array($response)) {
-			// this should never happen since app_api only returns errors in an array
-			throw new RuntimeException('Error during request to Context Chat Backend (ExApp): response is not a valid response object');
-		}
 
 		$resContentType = $response->getHeader('Content-Type');
 		if (strpos($resContentType, 'application/json') !== false) {
@@ -164,14 +159,22 @@ private function requestToExApp(
 			}
 
 			if ($response->getStatusCode() >= 500) {
-				// only throw for 5xx errors
 				throw new RuntimeException(
 					'Error received from Context Chat Backend (ExApp) with status code '
 					. $response->getStatusCode()
 					. ': '
 					. (isset($finalBody['error']) ? $finalBody['error'] : 'unknown error')
 				);
 			}
+
+			if ($response->getStatusCode() >= 400) {
+				throw new FatalRequestException(
+					'Error received from Context Chat Backend (ExApp) with status code '
+					. $response->getStatusCode()
+					. ': '
+					. (isset($finalBody['error']) ? $finalBody['error'] : json_encode($finalBody))
+				);
+			}
 		}
 
 		return $finalBody;
@@ -301,7 +304,17 @@ public function indexSources(array $sources): array {
 			];
 		}, $sources);
 
-		$response = $this->requestToExApp('/loadSources', 'PUT', $params, 'multipart/form-data');
+		try {
+			$response = $this->requestToExApp('/loadSources', 'PUT', $params, 'multipart/form-data');
+		} catch (FatalRequestException $e) {
+			// do not retry on 4xx errors
+			$this->logger->warning('Error while indexing sources: ' . $e->getMessage(), [
+				'exception' => $e,
+				'sourceIds' => array_map(fn (Source $source) => $source->reference, $sources),
+			]);
+			return ['loaded_sources' => [], 'sources_to_retry' => []];
+		}
+
 		if (
 			!isset($response['loaded_sources']) || !is_array($response['loaded_sources'])
 			|| !isset($response['sources_to_retry']) || !is_array($response['sources_to_retry'])