fix: unify allowSocialSync frontend type

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>

Author: hamza221

lib/AppInfo/Application.php

@@ -22,10 +22,6 @@
 class Application extends App implements IBootstrap {
 	public const APP_ID = 'contacts';
 
-	public const AVAIL_SETTINGS = [
-		'allowSocialSync' => 'yes',
-	];
-
 	public function __construct() {
 		parent::__construct(self::APP_ID);
 	}

lib/Settings/AdminSettings.php

@@ -8,37 +8,25 @@
 namespace OCA\Contacts\Settings;
 
 use OCA\Contacts\AppInfo\Application;
+use OCA\Contacts\Service\SocialApiService;
 use OCP\AppFramework\Http\TemplateResponse;
 use OCP\AppFramework\Services\IInitialState;
-use OCP\IConfig;
 use OCP\Settings\ISettings;
 
 class AdminSettings implements ISettings {
-	protected $appName;
-
-	/**
-	 * Admin constructor.
-	 *
-	 * @param IConfig $config
-	 * @param IL10N $l
-	 */
 	public function __construct(
-		private IConfig $config,
 		private IInitialState $initialState,
+		private SocialApiService $socialApiService,
 	) {
-		$this->appName = Application::APP_ID;
 	}
 
 	/**
 	 * @return TemplateResponse
 	 */
 	#[\Override]
 	public function getForm() {
-		foreach (Application::AVAIL_SETTINGS as $key => $default) {
-			$data = $this->config->getAppValue($this->appName, $key, $default);
-			$this->initialState->provideInitialState($key, $data);
-		}
-		return new TemplateResponse($this->appName, 'settings/admin');
+		$this->initialState->provideInitialState('allowSocialSync', $this->socialApiService->syncAllowedByAdmin());
+		return new TemplateResponse(Application::APP_ID, 'settings/admin');
 	}
 
 	/**

src/components/AdminSettings.vue

@@ -26,7 +26,7 @@ export default {
 	name: 'AdminSettings',
 	data() {
 		return {
-			allowSocialSync: loadState('contacts', 'allowSocialSync', false),
+			allowSocialSync: loadState('contacts', 'allowSocialSync', true),
 		}
 	},
 

tests/unit/Settings/AdminSettingsTest.php

@@ -0,0 +1,50 @@
+<?php
+
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Contacts\Settings;
+
+use ChristophWurst\Nextcloud\Testing\TestCase;
+use OCA\Contacts\Service\SocialApiService;
+use OCP\AppFramework\Http\TemplateResponse;
+use OCP\AppFramework\Services\IInitialState;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\MockObject\MockObject;
+
+class AdminSettingsTest extends TestCase {
+	private AdminSettings $settings;
+
+	/** @var IInitialState|MockObject */
+	private $initialState;
+
+	/** @var SocialApiService|MockObject */
+	private $socialApiService;
+
+	protected function setUp(): void {
+		parent::setUp();
+		$this->initialState = $this->createMock(IInitialState::class);
+		$this->socialApiService = $this->createMock(SocialApiService::class);
+		$this->settings = new AdminSettings($this->initialState, $this->socialApiService);
+	}
+
+	public static function allowSocialSyncProvider(): array {
+		return [[true], [false]];
+	}
+
+	#[DataProvider('allowSocialSyncProvider')]
+	public function testGetFormProvidesBooleanInitialState(bool $allowed): void {
+		$this->socialApiService
+			->method('syncAllowedByAdmin')
+			->willReturn($allowed);
+		$this->initialState
+			->expects($this->once())
+			->method('provideInitialState')
+			->with('allowSocialSync', $allowed);
+
+		$form = $this->settings->getForm();
+		$this->assertInstanceOf(TemplateResponse::class, $form);
+	}
+}