fix(appointments): validate all config values

Signed-off-by: Kumar Saurabh <kumarsaurabh27d@gmail.com>

Author: Kumar-s75

lib/Controller/AppointmentConfigController.php

@@ -103,9 +103,34 @@ private function validateAvailability(array $availability): void {
 	/**
 	 * @throws InvalidArgumentException
 	 */
-	private function validateDurations(int $length, int $increment): void {
-		if ($length <= 0 || $increment <= 0) {
-			throw new InvalidArgumentException('Length and increment must be greater than zero');
+	private function validateConfigValues(
+		int $length,
+		int $increment,
+		int $preparationDuration,
+		int $followupDuration,
+		int $timeBeforeNextSlot,
+		?int $dailyMax,
+		?int $start,
+		?int $end,
+		?int $futureLimit,
+	): void {
+		if ($length <= 0) {
+			throw new InvalidArgumentException('Length must be greater than zero');
+		}
+		if ($increment < 5 * 60) {
+			throw new InvalidArgumentException('Increment must be at least 5 minutes');
+		}
+		if ($preparationDuration < 0 || $followupDuration < 0 || $timeBeforeNextSlot < 0) {
+			throw new InvalidArgumentException('Durations must not be negative');
+		}
+		if ($dailyMax !== null && $dailyMax <= 0) {
+			throw new InvalidArgumentException('Daily maximum must be greater than zero');
+		}
+		if ($futureLimit !== null && $futureLimit <= 0) {
+			throw new InvalidArgumentException('Future limit must be greater than zero');
+		}
+		if ($start !== null && $end !== null && $start >= $end) {
+			throw new InvalidArgumentException('Start must be before end');
 		}
 	}
 
@@ -154,7 +179,7 @@ public function create(
 			return JsonResponse::fail();
 		}
 		try {
-			$this->validateDurations($length, $increment);
+			$this->validateConfigValues($length, $increment, $preparationDuration, $followupDuration, $timeBeforeNextSlot, $dailyMax, $start, $end, $futureLimit);
 			$this->validateAvailability($availability);
 		} catch (InvalidArgumentException $e) {
 			return JsonResponse::fail($e->getMessage(), Http::STATUS_UNPROCESSABLE_ENTITY);
@@ -233,7 +258,7 @@ public function update(
 			return JsonResponse::fail(null, Http::STATUS_NOT_FOUND);
 		}
 		try {
-			$this->validateDurations($length, $increment);
+			$this->validateConfigValues($length, $increment, $preparationDuration, $followupDuration, $timeBeforeNextSlot, $dailyMax, $start, $end, $futureLimit);
 			$this->validateAvailability($availability);
 		} catch (InvalidArgumentException $e) {
 			return JsonResponse::fail($e->getMessage(), Http::STATUS_UNPROCESSABLE_ENTITY);

tests/php/unit/Controller/AppointmentConfigControllerTest.php

@@ -163,6 +163,37 @@ public function testCreateWithInvalidIncrement(): void {
 		self::assertEquals(422, $response->getStatus());
 	}
 
+	/**
+	 * @dataProvider invalidConfigValuesProvider
+	 */
+	public function testCreateWithInvalidConfigValues(array $values): void {
+		$this->service->expects(self::never())
+			->method('create');
+
+		$response = $this->controller->create(
+			'Test',
+			'Test',
+			'Test',
+			'PUBLIC',
+			'test',
+			$this->availability,
+			...$values,
+		);
+
+		self::assertEquals(422, $response->getStatus());
+	}
+
+	public static function invalidConfigValuesProvider(): array {
+		return [
+			'negative preparation duration' => [[5 * 60, 5 * 60, -1, 0, 0, null, null, null, null]],
+			'negative follow-up duration' => [[5 * 60, 5 * 60, 0, -1, 0, null, null, null, null]],
+			'negative buffer' => [[5 * 60, 5 * 60, 0, 0, -1, null, null, null, null]],
+			'zero daily maximum' => [[5 * 60, 5 * 60, 0, 0, 0, 0, null, null, null]],
+			'zero future limit' => [[5 * 60, 5 * 60, 0, 0, 0, null, null, null, 0]],
+			'end before start' => [[5 * 60, 5 * 60, 0, 0, 0, null, 2, 1, null]],
+		];
+	}
+
 	public function testCreate(): void {
 		$appointment = new AppointmentConfig();
 		$appointment->setName('Test');