fix: guard against stale getTask() and getNotifyReady() calls

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Author: julien-nc

src/assistant.js

@@ -290,6 +290,10 @@ export async function openAssistantForm({
 
 			if ([TASK_STATUS_STRING.scheduled, TASK_STATUS_STRING.running].includes(task?.status)) {
 				getTask(task.id).then(response => {
+					if (task.id !== view.selectedTaskId) {
+						console.debug('[assistant] ignoring stale getTask response for task', task.id, 'selected is', view.selectedTaskId)
+						return
+					}
 					const updatedTask = response.data?.ocs?.data?.task
 
 					if (![TASK_STATUS_STRING.scheduled, TASK_STATUS_STRING.running].includes(updatedTask?.status)) {
@@ -303,6 +307,9 @@ export async function openAssistantForm({
 					}
 
 					getNotifyReady(task.id).then(response => {
+						if (task.id !== view.selectedTaskId) {
+							return
+						}
 						view.isNotifyEnabled = !!response.data?.ocs?.data?.id
 					}).catch(error => {
 						console.error('[assistant] get task notification status error', error)
@@ -922,6 +929,10 @@ export async function openAssistantTask(
 
 		if ([TASK_STATUS_STRING.scheduled, TASK_STATUS_STRING.running].includes(task?.status)) {
 			getTask(task.id).then(response => {
+				if (task.id !== view.selectedTaskId) {
+					console.debug('[assistant] ignoring stale getTask response for task', task.id, 'selected is', view.selectedTaskId)
+					return
+				}
 				const updatedTask = response.data?.ocs?.data?.task
 
 				if (![TASK_STATUS_STRING.scheduled, TASK_STATUS_STRING.running].includes(updatedTask?.status)) {
@@ -935,6 +946,9 @@ export async function openAssistantTask(
 				}
 
 				getNotifyReady(task.id).then(response => {
+					if (task.id !== view.selectedTaskId) {
+						return
+					}
 					view.isNotifyEnabled = !!response.data?.ocs?.data?.id
 				}).catch(error => {
 					console.error('[assistant] get task notification status error', error)

src/views/AssistantPage.vue

@@ -258,6 +258,10 @@ export default {
 
 			if ([TASK_STATUS_STRING.scheduled, TASK_STATUS_STRING.running].includes(task?.status)) {
 				getTask(task.id).then(response => {
+					if (task.id !== this.task.id) {
+						console.debug('[assistant] ignoring stale getTask response for task', task.id, 'selected is', this.task.id)
+						return
+					}
 					const updatedTask = response.data?.ocs?.data?.task
 
 					if (![TASK_STATUS_STRING.scheduled, TASK_STATUS_STRING.running].includes(updatedTask?.status)) {