fix potential issues when switching tasks (reset status) and fix canSubmit computed (vue3 dynamic computed dependencies)

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Author: julien-nc

src/assistant.js

@@ -257,6 +257,7 @@ export async function openAssistantForm({
 			view.showSyncTaskRunning = false
 			view.isNotifyEnabled = false
 			view.loading = false
+			view.taskStatus = task.status
 
 			view.selectedTaskTypeId = task.type
 			view.inputs = task.input
@@ -273,6 +274,7 @@ export async function openAssistantForm({
 						view.inputs = updatedTask.input
 						view.outputs = updatedTask.status === TASK_STATUS_STRING.successful ? updatedTask.output : null
 						view.selectedTaskId = updatedTask.id
+						view.taskStatus = updatedTask.status
 						lastTask = updatedTask
 						return
 					}
@@ -340,6 +342,7 @@ export async function openAssistantForm({
 			view.isNotifyEnabled = false
 			view.outputs = null
 			view.selectedTaskId = null
+			view.taskStatus = null
 			lastTask = null
 		})
 		modalMountPoint.addEventListener('background-notify', (data) => {
@@ -768,6 +771,7 @@ export async function openAssistantTask(
 		view.showSyncTaskRunning = false
 		view.isNotifyEnabled = false
 		view.loading = false
+		view.taskStatus = task.status
 
 		view.selectedTaskTypeId = task.type
 		view.inputs = task.input
@@ -784,6 +788,7 @@ export async function openAssistantTask(
 					view.inputs = updatedTask.input
 					view.outputs = updatedTask.status === TASK_STATUS_STRING.successful ? updatedTask.output : null
 					view.selectedTaskId = updatedTask.id
+					view.taskStatus = updatedTask.status
 					lastTask = updatedTask
 					return
 				}
@@ -850,6 +855,7 @@ export async function openAssistantTask(
 		view.isNotifyEnabled = false
 		view.outputs = null
 		view.selectedTaskId = null
+		view.taskStatus = null
 		lastTask = null
 	})
 	modalMountPoint.addEventListener('background-notify', (data) => {

src/components/AssistantTextProcessingForm.vue

@@ -377,22 +377,23 @@ export default {
 			return this.selectedTaskType
 		},
 		canSubmit() {
+			const inputs = this.myInputs
 			if (this.taskStatus === TASK_STATUS_STRING.running) {
 				return false
 			}
 			// otherwise, check that none of the properties of myInputs are empty
-			console.debug('[assistant] canSubmit', this.myInputs)
-			if (Object.keys(this.myInputs).length === 0) {
+			console.debug('[assistant] canSubmit', inputs)
+			if (Object.keys(inputs).length === 0) {
 				return false
 			}
 			const taskType = this.selectedTaskType
 			// check that all fields required by the task type are defined
 			return Object.keys(taskType.inputShape).every(k => {
-				if (this.myInputs[k] === null || this.myInputs[k] === undefined) {
+				if (inputs[k] === null || inputs[k] === undefined) {
 					return false
 				}
 				const fieldType = taskType.inputShape[k].type
-				const value = this.myInputs[k]
+				const value = inputs[k]
 				return ([SHAPE_TYPE_NAMES.Text, SHAPE_TYPE_NAMES.Enum].includes(fieldType)
 						&& typeof value === 'string'
 						&& !!value?.trim()

src/views/AssistantPage.vue

@@ -233,6 +233,7 @@ export default {
 						this.task.input = updatedTask.input
 						this.task.output = updatedTask.status === TASK_STATUS_STRING.successful ? updatedTask.output : null
 						this.task.id = updatedTask.id
+						this.task.status = updatedTask.status
 						return
 					}