enh: stop polling task position when we stop polling the task (task finished or failed)

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Author: julien-nc

src/assistant.js

@@ -233,13 +233,15 @@ export async function openAssistantForm({
 						view.loading = false
 						view.showSyncTaskRunning = false
 						view.taskPosition = null
+						cancelTaskPositionPolling()
 						emit('assistant:task:updated', finishedTask)
 					}).catch(error => {
 						console.debug('[assistant] poll error', error.message)
 						if (error.message === 'task-not-found') {
 							view.loading = false
 							view.showSyncTaskRunning = false
 							view.taskPosition = null
+							cancelTaskPositionPolling()
 							view.isNotifyEnabled = false
 							view.outputs = null
 							view.selectedTaskId = null
@@ -342,13 +344,15 @@ export async function openAssistantForm({
 						view.loading = false
 						view.showSyncTaskRunning = false
 						view.taskPosition = null
+						cancelTaskPositionPolling()
 						emit('assistant:task:updated', finishedTask)
 					}).catch(error => {
 						console.debug('[assistant] poll error', error)
 						if (error.message === 'task-not-found') {
 							view.loading = false
 							view.showSyncTaskRunning = false
 							view.taskPosition = null
+							cancelTaskPositionPolling()
 							view.isNotifyEnabled = false
 							view.outputs = null
 							view.selectedTaskId = null
@@ -843,6 +847,7 @@ export async function openAssistantTask(
 					view.loading = false
 					view.showSyncTaskRunning = false
 					view.taskPosition = null
+					cancelTaskPositionPolling()
 					emit('assistant:task:updated', finishedTask)
 				}).catch(error => {
 					console.debug('[assistant] poll error', error)
@@ -851,6 +856,7 @@ export async function openAssistantTask(
 						view.loading = false
 						view.showSyncTaskRunning = false
 						view.taskPosition = null
+						cancelTaskPositionPolling()
 						view.isNotifyEnabled = false
 						view.selectedTaskId = null
 						lastTask = null
@@ -948,13 +954,15 @@ export async function openAssistantTask(
 					view.loading = false
 					view.showSyncTaskRunning = false
 					view.taskPosition = null
+					cancelTaskPositionPolling()
 					emit('assistant:task:updated', finishedTask)
 				}).catch(error => {
 					console.debug('[assistant] poll error', error)
 					if (error.message === 'task-not-found') {
 						view.loading = false
 						view.showSyncTaskRunning = false
 						view.taskPosition = null
+						cancelTaskPositionPolling()
 						view.isNotifyEnabled = false
 						view.outputs = null
 						view.selectedTaskId = null

src/views/AssistantPage.vue

@@ -198,13 +198,16 @@ export default {
 						this.loading = false
 						this.showSyncTaskRunning = false
 						this.taskPosition = null
+						// the position polling would stop on the next request but why not stopping it right now
+						cancelTaskPositionPolling()
 						emit('assistant:task:updated', finishedTask)
 					}).catch(error => {
 						console.debug('[assistant] poll error', error)
 						if (error.message === 'task-not-found') {
 							this.loading = false
 							this.showSyncTaskRunning = false
 							this.taskPosition = null
+							cancelTaskPositionPolling()
 							this.isNotifyEnabled = false
 							this.task.status = TASK_STATUS_STRING.unknown
 							this.task.output = null
@@ -294,13 +297,15 @@ export default {
 						this.loading = false
 						this.showSyncTaskRunning = false
 						this.taskPosition = null
+						cancelTaskPositionPolling()
 						emit('assistant:task:updated', finishedTask)
 					}).catch(error => {
 						console.debug('Assistant poll error', error)
 						if (error.message === 'task-not-found') {
 							this.loading = false
 							this.showSyncTaskRunning = false
 							this.taskPosition = null
+							cancelTaskPositionPolling()
 							this.isNotifyEnabled = false
 							this.task.status = TASK_STATUS_STRING.unknown
 							this.task.output = null