Merge pull request #16483 from nextcloud/jtr/build-deprecated-Account-warnings

build(User/Account): update deprecation notes and add to overrides

Author: AndyScherzinger

app/src/main/java/com/nextcloud/client/account/AnonymousUser.kt

@@ -49,8 +49,16 @@ internal data class AnonymousUser(private val accountType: String) :
     override val server = Server(URI.create(""), MainApp.MINIMUM_SUPPORTED_SERVER_VERSION)
     override val isAnonymous = true
 
+    @Deprecated(
+        "Temporary workaround: Legacy Android Account access. Refactor code to use User object " +
+            "directly instead of platform Account."
+    )
     override fun toPlatformAccount(): Account = Account(accountName, accountType)
 
+    @Deprecated(
+        "Temporary workaround: Legacy OwnCloudAccount access. Refactor code to use User object " +
+            "directly instead of OwnCloudAccount."
+    )
     override fun toOwnCloudAccount(): OwnCloudAccount = OwnCloudAccount(Uri.EMPTY, OwnCloudBasicCredentials("", ""))
 
     override fun nameEquals(user: User?): Boolean = user?.accountName.equals(accountName, true)

app/src/main/java/com/nextcloud/client/account/MockUser.kt

@@ -44,8 +44,16 @@ data class MockUser(override val accountName: String, val accountType: String) :
     override val server = Server(URI.create(""), MainApp.MINIMUM_SUPPORTED_SERVER_VERSION)
     override val isAnonymous = false
 
+    @Deprecated(
+        "Temporary workaround: Legacy Android Account access. Refactor code to use User object " +
+            "directly instead of platform Account."
+    )
     override fun toPlatformAccount(): Account = Account(accountName, accountType)
 
+    @Deprecated(
+        "Temporary workaround: Legacy OwnCloudAccount access. Refactor code to use User object " +
+            "directly instead of OwnCloudAccount."
+    )
     override fun toOwnCloudAccount(): OwnCloudAccount = OwnCloudAccount(Uri.EMPTY, OwnCloudBasicCredentials("", ""))
 
     override fun nameEquals(user: User?): Boolean = user?.accountName.equals(accountName, true)

app/src/main/java/com/nextcloud/client/account/RegisteredUser.kt

@@ -41,8 +41,16 @@ internal data class RegisteredUser(
         return account.name
     }
 
+    @Deprecated(
+        "Temporary workaround: Legacy Android Account access. Refactor code to use User object " +
+            "directly instead of platform Account."
+    )
     override fun toPlatformAccount(): Account = account
 
+    @Deprecated(
+        "Temporary workaround: Legacy OwnCloudAccount access. Refactor code to use User object " +
+            "directly instead of OwnCloudAccount."
+    )
     override fun toOwnCloudAccount(): OwnCloudAccount = ownCloudAccount
 
     override fun nameEquals(user: User?): Boolean = nameEquals(user?.accountName)

app/src/main/java/com/nextcloud/client/account/User.kt

@@ -27,7 +27,10 @@ interface User :
      *
      * @return Account instance that is associated with this User object.
      */
-    @Deprecated("Temporary workaround")
+    @Deprecated(
+        "Temporary workaround: Legacy Android Account access. Refactor code to use User object " +
+            "directly instead of platform Account."
+    )
     override fun toPlatformAccount(): Account
 
     /**
@@ -39,7 +42,10 @@ interface User :
      *
      * @return OwnCloudAccount instance that is associated with this User object.
      */
-    @Deprecated("Temporary workaround")
+    @Deprecated(
+        "Temporary workaround: Legacy OwnCloudAccount access. Refactor code to use User object " +
+            "directly instead of OwnCloudAccount."
+    )
     fun toOwnCloudAccount(): OwnCloudAccount
 
     /**