wip

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Author: alperozturk96

app/src/androidTest/java/com/owncloud/android/files/FileMenuFilterIT.kt

@@ -69,6 +69,7 @@ class FileMenuFilterIT : AbstractIT() {
         every { mockComponentsGetter.operationsServiceBinder } returns mockOperationsServiceBinder
         every { mockStorageManager.getFileById(any()) } returns OCFile("/")
         every { mockStorageManager.getFolderContent(any(), any()) } returns ArrayList<OCFile>()
+        every { mockStorageManager.isReadOnly(any()) } returns false
         every { mockArbitraryDataProvider.getValue(any<User>(), any()) } returns ""
         editorUtils = EditorUtils(mockArbitraryDataProvider)
     }
@@ -363,6 +364,63 @@ class FileMenuFilterIT : AbstractIT() {
         }
     }
 
+    @Test
+    fun filter_readOnlyFile_hidesModifyingActions() {
+        configureCapability(
+            OCCapability().apply {
+                endToEndEncryption = CapabilityBooleanType.TRUE
+                filesLockingVersion = "1.0"
+            }
+        )
+
+        every { mockStorageManager.isReadOnly(any()) } returns true
+
+        val file = OCFile("/readOnly.txt").apply {
+            permissions = FULL_PERMISSIONS
+        }
+
+        launchActivity<TestActivity>().use {
+            it.onActivity { activity ->
+                val filterFactory = FileMenuFilter.Factory(mockStorageManager, activity, editorUtils)
+
+                val toHide = filterFactory
+                    .newInstance(file, mockComponentsGetter, true, user)
+                    .getToHide(false)
+
+                READ_ONLY_HIDDEN_ACTIONS.forEach { action ->
+                    assertTrue(toHide.contains(action))
+                }
+            }
+        }
+    }
+
+    @Test
+    fun filter_writableFile_keepsModifyingActions() {
+        configureCapability(
+            OCCapability().apply {
+                filesLockingVersion = "1.0"
+            }
+        )
+
+        val file = OCFile("/writable.txt").apply {
+            permissions = FULL_PERMISSIONS
+        }
+
+        launchActivity<TestActivity>().use {
+            it.onActivity { activity ->
+                val filterFactory = FileMenuFilter.Factory(mockStorageManager, activity, editorUtils)
+
+                val toHide = filterFactory
+                    .newInstance(file, mockComponentsGetter, true, user)
+                    .getToHide(false)
+
+                WRITABLE_VISIBLE_ACTIONS.forEach { action ->
+                    assertFalse(toHide.contains(action))
+                }
+            }
+        }
+    }
+
     private data class ExpectedLockVisibilities(val lockFile: Boolean, val unlockFile: Boolean)
 
     private fun configureCapability(capability: OCCapability) {
@@ -398,6 +456,29 @@ class FileMenuFilterIT : AbstractIT() {
     }
 
     companion object {
+        private const val FULL_PERMISSIONS = "RGDNVW"
+
+        private val READ_ONLY_HIDDEN_ACTIONS = listOf(
+            R.id.action_remove_file,
+            R.id.action_rename_file,
+            R.id.action_move_or_copy,
+            R.id.action_edit,
+            R.id.action_encrypted,
+            R.id.action_unset_encrypted,
+            R.id.action_lock_file,
+            R.id.action_unlock_file,
+            R.id.action_favorite,
+            R.id.action_unset_favorite
+        )
+
+        private val WRITABLE_VISIBLE_ACTIONS = listOf(
+            R.id.action_remove_file,
+            R.id.action_rename_file,
+            R.id.action_move_or_copy,
+            R.id.action_lock_file,
+            R.id.action_favorite
+        )
+
         private const val OFFICE_MIMETYPE =
             "application/vnd.openxmlformats-officedocument.wordprocessingml.document"
 

app/src/androidTest/java/com/owncloud/android/utils/EncryptionUtilsV2IT.kt

@@ -791,7 +791,11 @@ class EncryptionUtilsV2IT : EncryptionIT() {
 
         val signature = encryptionUtilsV2.getMessageSignature(enc1Cert, enc1PrivateKey, encrypted)
 
-        val result = encryptionUtilsV2.verifyMetadata(encrypted, metadataFile, 0, signature)
+        val tampered = encrypted.copy(
+            metadata = encrypted.metadata.copy(ciphertext = encrypted.metadata.ciphertext.reversed())
+        )
+
+        val result = encryptionUtilsV2.verifyMetadata(tampered, metadataFile, 0, signature)
 
         assertFalse(result)
     }