Skip to content

Commit 5bcfd32

Browse files
committed
wip
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
1 parent 3abef04 commit 5bcfd32

2 files changed

Lines changed: 12 additions & 24 deletions

File tree

app/src/main/java/com/owncloud/android/ui/adapter/albums/AlbumsAdapter.kt

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ import com.owncloud.android.databinding.AlbumsGridItemBinding
2020
import com.owncloud.android.databinding.AlbumsListItemBinding
2121
import com.owncloud.android.datamodel.FileDataStorageManager
2222
import com.owncloud.android.datamodel.OCFile
23-
import com.owncloud.android.datamodel.ThumbnailsCacheManager
24-
import com.owncloud.android.lib.common.utils.Log_OC
2523
import com.owncloud.android.lib.resources.albums.PhotoAlbumEntry
2624
import com.owncloud.android.utils.DisplayUtils
2725

@@ -34,7 +32,6 @@ class AlbumsAdapter(
3432
private val gridView: Boolean = true
3533
) : RecyclerView.Adapter<RecyclerView.ViewHolder>() {
3634
private var albumList: MutableList<PhotoAlbumEntry> = mutableListOf()
37-
private val asyncTasks: MutableList<ThumbnailsCacheManager.ThumbnailGenerationTask> = ArrayList()
3835

3936
override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): RecyclerView.ViewHolder = if (gridView) {
4037
AlbumGridItemViewHolder(AlbumsGridItemBinding.inflate(LayoutInflater.from(parent.context), parent, false))
@@ -76,7 +73,6 @@ class AlbumsAdapter(
7673
ocLocal = nFile
7774
}
7875

79-
8076
thumbnailGenerator.setThumbnail(ocLocal, gridViewHolder.thumbnail, gridView, true)
8177
} else {
8278
gridViewHolder.thumbnail.setImageResource(R.drawable.file_image)
@@ -87,14 +83,7 @@ class AlbumsAdapter(
8783
}
8884

8985
fun cancelAllPendingTasks() {
90-
for (task in asyncTasks) {
91-
task.cancel(true)
92-
if (task.getMethod != null) {
93-
Log_OC.d("AlbumsAdapter", "cancel: abort get method directly")
94-
task.getMethod.abort()
95-
}
96-
}
97-
asyncTasks.clear()
86+
thumbnailGenerator.fileThumbnailGenerator.cancelPendingTasks()
9887
}
9988

10089
@SuppressLint("NotifyDataSetChanged")

app/src/main/java/com/owncloud/android/ui/fragment/albums/AlbumSharingBottomSheet.kt

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,16 @@ import com.google.android.material.bottomsheet.BottomSheetBehavior
1818
import com.google.android.material.bottomsheet.BottomSheetDialog
1919
import com.google.android.material.bottomsheet.BottomSheetDialogFragment
2020
import com.nextcloud.android.common.ui.theme.utils.ColorRole
21-
import com.nextcloud.client.account.CurrentAccountProvider
2221
import com.nextcloud.client.di.Injectable
2322
import com.nextcloud.utils.date.DateFormatPattern
2423
import com.nextcloud.utils.extensions.setVisibleIf
2524
import com.nextcloud.utils.thumbnail.ThumbnailGenerator
2625
import com.owncloud.android.R
26+
import com.owncloud.android.databinding.AlbumImageThumbnailBinding
2727
import com.owncloud.android.databinding.AlbumShareActionBinding
2828
import com.owncloud.android.databinding.AlbumSharingBottomSheetBinding
2929
import com.owncloud.android.datamodel.FileDataStorageManager
3030
import com.owncloud.android.datamodel.OCFile
31-
import com.owncloud.android.datamodel.SyncedFolderProvider
32-
import com.owncloud.android.datamodel.ThumbnailsCacheManager
3331
import com.owncloud.android.lib.resources.albums.PhotoAlbumEntry
3432
import com.owncloud.android.utils.DisplayUtils
3533
import com.owncloud.android.utils.theme.ViewThemeUtils
@@ -45,20 +43,12 @@ class AlbumSharingBottomSheet(
4543
@Inject
4644
lateinit var viewThemeUtils: ViewThemeUtils
4745

48-
@Inject
49-
lateinit var currentUserProvider: CurrentAccountProvider
50-
5146
@Inject
5247
lateinit var storageManager: FileDataStorageManager
5348

54-
@Inject
55-
lateinit var syncedFolderProvider: SyncedFolderProvider
56-
5749
@Inject
5850
lateinit var thumbnailGenerator: ThumbnailGenerator
5951

60-
private val thumbnailAsyncTasks = mutableListOf<ThumbnailsCacheManager.ThumbnailGenerationTask>()
61-
6252
private var _binding: AlbumSharingBottomSheetBinding? = null
6353
val binding
6454
get() = _binding!!
@@ -119,7 +109,7 @@ class AlbumSharingBottomSheet(
119109
return
120110
}
121111

122-
thumbnailGenerator.setThumbnail(getOrCreateFile(album), hideVideoOverlay = true, view = binding.albumImageLayout)
112+
loadThumbnail(getOrCreateFile(album), binding.albumImageLayout)
123113
}
124114

125115
private fun showPlaceholder() = with(binding.albumImageLayout) {
@@ -134,6 +124,15 @@ class AlbumSharingBottomSheet(
134124
remoteId = album.lastPhoto.toString()
135125
}
136126

127+
private fun loadThumbnail(file: OCFile, target: AlbumImageThumbnailBinding) {
128+
thumbnailGenerator.setThumbnail(
129+
file,
130+
target.thumbnail,
131+
hideVideoOverlay = true,
132+
shimmer = target.thumbnailShimmer
133+
)
134+
}
135+
137136
private fun initializeImageCollage() {
138137
val files = fileList?.takeIf { it.isNotEmpty() } ?: return
139138
val collage = this.collage ?: return

0 commit comments

Comments
 (0)