Skip to content

Commit 32c88af

Browse files
committed
wip
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
1 parent f32b98d commit 32c88af

6 files changed

Lines changed: 12 additions & 12 deletions

File tree

app/lint.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,11 @@
7676
<ignore path="build" />
7777
</issue>
7878

79+
<!-- Dagger factories generated for media3 @UnstableApi types cannot carry an @OptIn annotation. -->
80+
<issue id="UnsafeOptInUsageError" severity="error">
81+
<ignore path="build" />
82+
</issue>
83+
7984
<issue id="ObsoleteLintCustomCheck" severity="warning">
8085
<ignore path="**/fragment-1.2.5/**/lint.jar" />
8186
<ignore path="**/work-runtime-2.**/**/lint.jar" />

app/src/main/java/com/nextcloud/client/player/ui/PlayerActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ class PlayerActivity :
182182
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
183183
it.setAutoEnterEnabled(true)
184184
}
185-
getSourceRectHint().let(it::setSourceRectHint)
185+
it.setSourceRectHint(getSourceRectHint())
186186
it.build()
187187
}
188188

app/src/main/res/layout/player_audio_file_fragment.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
android:id="@+id/icon"
1919
android:layout_width="0dp"
2020
android:layout_height="0dp"
21+
android:importantForAccessibility="no"
2122
android:layout_marginTop="@dimen/player_audio_album_cover_margin_vertical"
2223
android:layout_marginBottom="@dimen/player_audio_album_cover_margin_vertical"
2324
android:src="@drawable/player_ic_audio"
@@ -32,6 +33,7 @@
3233
android:id="@+id/album_cover"
3334
android:layout_width="0dp"
3435
android:layout_height="0dp"
36+
android:importantForAccessibility="no"
3537
android:layout_marginTop="@dimen/player_audio_album_cover_margin_vertical"
3638
android:layout_marginBottom="@dimen/player_audio_album_cover_margin_vertical"
3739
custom:layout_constraintBottom_toTopOf="@id/title"

app/src/main/res/layout/player_video_file_fragment.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,14 @@
1515
android:layout_width="@dimen/player_file_icon_size"
1616
android:layout_height="@dimen/player_file_icon_size"
1717
android:layout_gravity="center"
18+
android:importantForAccessibility="no"
1819
android:src="@drawable/player_ic_video" />
1920

2021
<ImageView
2122
android:id="@+id/thumbnail"
2223
android:layout_width="match_parent"
23-
android:layout_height="match_parent" />
24+
android:layout_height="match_parent"
25+
android:importantForAccessibility="no" />
2426

2527
<SurfaceView
2628
android:id="@+id/surfaceView"

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -400,8 +400,6 @@
400400
<string name="pass_code_removed">Passcode deleted</string>
401401
<string name="pass_code_stored">Passcode stored</string>
402402

403-
<string name="media_notif_ticker">%1$s music player</string>
404-
<string name="media_state_playing">%1$s (playing)</string>
405403
<string name="media_err_unsupported">Unsupported media codec</string>
406404
<string name="media_err_io">Could not read the media file</string>
407405
<string name="media_err_malformed">The media file has incorrect encoding</string>
@@ -1266,8 +1264,6 @@
12661264
<string name="fourHours">4 hours</string>
12671265
<string name="thisWeek">This week</string>
12681266
<string name="drawer_item_gallery">Media</string>
1269-
<string name="player_stop">stop</string>
1270-
<string name="player_toggle">toggle</string>
12711267
<string name="choose_which_file">Choose which file to keep!</string>
12721268
<string name="wrong_storage_path">Data storage folder does not exist!</string>
12731269
<string name="wrong_storage_path_desc">This might be due to a backup restore on another device. Falling back to default. Please check settings to adjust data storage folder.</string>
@@ -1552,7 +1548,7 @@
15521548
<string name="player_error_source_not_found">Source not found</string>
15531549
<string name="player_media_controls_close_action_title">Close</string>
15541550
<string name="player_last_modified">Modified: %s</string>
1555-
<string name="player_control_view_repeat_button_content_description">Shuffle button</string>
1551+
<string name="player_control_view_repeat_button_content_description">Repeat button</string>
15561552
<string name="player_control_view_previous_button_content_description">Previous button</string>
15571553
<string name="player_control_view_play_pause_button_content_description">Play/Pause button</string>
15581554
<string name="player_control_view_next_button_content_description">Next button</string>

app/src/main/res/values/styles.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -231,11 +231,6 @@
231231
<item name="android:windowLightNavigationBar">false</item>
232232
</style>
233233

234-
<style name="Theme.ownCloud.Media" parent="Theme.Material3.DayNight.NoActionBar">
235-
<item name="android:windowLayoutInDisplayCutoutMode">shortEdges</item>
236-
<item name="android:colorControlHighlight">@color/primary</item>
237-
</style>
238-
239234
<style name="ToolbarStyle.Overflow" parent="@style/Widget.AppCompat.ActionButton.Overflow">
240235
<item name="android:tint">@android:color/white</item>
241236
</style>

0 commit comments

Comments
 (0)