Skip to content

Commit 32927bf

Browse files
committed
fix test
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
1 parent e97f37a commit 32927bf

3 files changed

Lines changed: 14 additions & 12 deletions

File tree

app/src/main/java/com/nextcloud/client/jobs/autoUpload/FileSystemRepository.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class FileSystemRepository(
3434
const val BATCH_SIZE = 50
3535
}
3636

37-
fun deleteAutoUploadEntityAndUploadEntity(syncedFolder: SyncedFolder, localPath: String, entity: FilesystemEntity) {
37+
fun deleteAutoUploadAndUploadEntity(syncedFolder: SyncedFolder, localPath: String, entity: FilesystemEntity) {
3838
Log_OC.d(TAG, "deleting auto upload entity and upload entity")
3939

4040
val file = File(localPath)
@@ -62,13 +62,13 @@ class FileSystemRepository(
6262
val file = File(path)
6363
if (!file.exists()) {
6464
Log_OC.w(TAG, "Ignoring file for upload (doesn't exist): $path")
65-
deleteAutoUploadEntityAndUploadEntity(syncedFolder, path, entity)
65+
deleteAutoUploadAndUploadEntity(syncedFolder, path, entity)
6666
} else if (!SyncedFolderUtils.isQualifiedFolder(file.parent)) {
6767
Log_OC.w(TAG, "Ignoring file for upload (unqualified folder): $path")
68-
deleteAutoUploadEntityAndUploadEntity(syncedFolder, path, entity)
68+
deleteAutoUploadAndUploadEntity(syncedFolder, path, entity)
6969
} else if (!SyncedFolderUtils.isFileNameQualifiedForAutoUpload(file.name)) {
7070
Log_OC.w(TAG, "Ignoring file for upload (unqualified file): $path")
71-
deleteAutoUploadEntityAndUploadEntity(syncedFolder, path, entity)
71+
deleteAutoUploadAndUploadEntity(syncedFolder, path, entity)
7272
} else {
7373
Log_OC.d(TAG, "Adding path to upload: $path")
7474

@@ -186,7 +186,7 @@ class FileSystemRepository(
186186
if (fileModified <= 0L) {
187187
Log_OC.d(TAG, "file is deleted, skipping: $localPath")
188188
entity?.let {
189-
deleteAutoUploadEntityAndUploadEntity(syncedFolder, localPath, entity)
189+
deleteAutoUploadAndUploadEntity(syncedFolder, localPath, entity)
190190
}
191191
return
192192
}

app/src/main/java/com/owncloud/android/operations/UploadFileOperation.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1049,7 +1049,7 @@ private RemoteOperationResult normalUpload(OwnCloudClient client) {
10491049
try {
10501050
// request a shared lock instead of exclusive one, since we are just reading file
10511051
fileLock = channel.tryLock(0L, Long.MAX_VALUE, true);
1052-
Log_OC.d(TAG ,"file locked");
1052+
Log_OC.d(TAG ,"🔒" + "file locked");
10531053
} catch (OverlappingFileLockException e) {
10541054
// if another thread has the lock, current thread can still read the file.
10551055
Log_OC.e(TAG, "shared lock overlap detected; proceeding safely.");
@@ -1089,7 +1089,7 @@ private RemoteOperationResult normalUpload(OwnCloudClient client) {
10891089
size = new File(mFile.getStoragePath()).length();
10901090
}
10911091
} catch (Exception exception) {
1092-
Log_OC.e(TAG, "normalUpload, size cannot be determined from channel: " + exception);
1092+
Log_OC.e(TAG, "size cannot be determined from channel: " + exception);
10931093
size = new File(mFile.getStoragePath()).length();
10941094
}
10951095

@@ -1149,7 +1149,7 @@ private RemoteOperationResult normalUpload(OwnCloudClient client) {
11491149
if (fileLock != null && fileLock.isValid()) {
11501150
try {
11511151
fileLock.release();
1152-
Log_OC.d(TAG ,"file lock released");
1152+
Log_OC.d(TAG ,"🔓" + "file lock released");
11531153
} catch (IOException ignored) {
11541154
Log_OC.e(TAG, "failed to unlock file with path " + mOriginalStoragePath);
11551155
}
@@ -1160,7 +1160,7 @@ private RemoteOperationResult normalUpload(OwnCloudClient client) {
11601160
if (channel != null) {
11611161
try {
11621162
channel.close();
1163-
Log_OC.d(TAG ,"file channel closed");
1163+
Log_OC.d(TAG ,"📢" + "file channel closed");
11641164
} catch (IOException ignored) {
11651165
Log_OC.e(TAG, "failed to close file channel");
11661166
}
@@ -1171,7 +1171,7 @@ private RemoteOperationResult normalUpload(OwnCloudClient client) {
11711171
if (fileInputStream != null) {
11721172
try {
11731173
fileInputStream.close();
1174-
Log_OC.d(TAG ,"file input stream closed");
1174+
Log_OC.d(TAG ,"📝" + "file input stream closed");
11751175
} catch (IOException ignored) {
11761176
Log_OC.e(TAG, "failed to close file input stream");
11771177
}
@@ -1181,7 +1181,7 @@ private RemoteOperationResult normalUpload(OwnCloudClient client) {
11811181

11821182
if (temporalFile != null && !originalFile.equals(temporalFile)) {
11831183
boolean isTempFileDeleted = temporalFile.delete();
1184-
Log_OC.d(TAG, "normalUpload, temp folder deletion: " + isTempFileDeleted);
1184+
Log_OC.d(TAG, "temp folder deletion: " + isTempFileDeleted);
11851185
}
11861186

11871187
if (result == null) {

app/src/test/java/com/owncloud/android/utils/AutoUploadHelperTest.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import com.nextcloud.client.preferences.SubFolderRule
1515
import com.nextcloud.utils.extensions.shouldSkipFile
1616
import com.owncloud.android.datamodel.MediaFolderType
1717
import com.owncloud.android.datamodel.SyncedFolder
18+
import com.owncloud.android.datamodel.UploadsStorageManager
1819
import io.mockk.clearAllMocks
1920
import io.mockk.mockk
2021
import org.junit.After
@@ -36,14 +37,15 @@ class AutoUploadHelperTest {
3637
private val mockContext: Context = mockk(relaxed = true)
3738

3839
private lateinit var repo: FileSystemRepository
40+
private val mockUploadsStorageManager: UploadsStorageManager = mockk(relaxed = true)
3941

4042
@Before
4143
fun setup() {
4244
tempDir = Files.createTempDirectory("auto_upload_test_").toFile()
4345
tempDir.mkdirs()
4446
assertTrue("Failed to create temp directory", tempDir.exists())
4547

46-
repo = FileSystemRepository(mockDao, mockContext)
48+
repo = FileSystemRepository(mockDao, mockUploadsStorageManager, mockContext)
4749
}
4850

4951
@After

0 commit comments

Comments
 (0)