Merge pull request #16807 from nextcloud/fix/file-list-recommended-files-invalid-index

fix(file-list): updating recommended files

Author: alperozturk96

app/src/main/java/com/owncloud/android/ui/adapter/OCFileListAdapter.java

@@ -131,7 +131,7 @@ public class OCFileListAdapter extends RecyclerView.Adapter<RecyclerView.ViewHol
     private final long footerId = UUID.randomUUID().getLeastSignificantBits();
     private final long headerId = UUID.randomUUID().getLeastSignificantBits();
 
-    private ArrayList<OCFile> recommendedFiles = new ArrayList<>();
+    private List<OCFile> recommendedFiles = new ArrayList<>();
     private RecommendedFilesAdapter recommendedFilesAdapter;
     private final OCFileListAdapterHelper helper = new OCFileListAdapterHelper();
     private final OverlayManager overlayManager;
@@ -703,14 +703,10 @@ private void setVisibilityOfMoreOption(Object holder) {
     }
 
     @SuppressLint("NotifyDataSetChanged")
-    public void updateRecommendedFiles(ArrayList<OCFile> recommendedFiles) {
-        this.recommendedFiles = recommendedFiles;
-
-        if (recommendedFiles == null || recommendedFiles.isEmpty()) {
-            notifyDataSetChanged();
-        } else {
-            notifyItemChanged(0);
-        }
+    public void updateRecommendedFiles(@NonNull List<OCFile> value) {
+        recommendedFiles.clear();
+        recommendedFiles.addAll(value);
+        notifyDataSetChanged();
     }
 
     private void applyChipVisuals(Chip chip, Tag tag) {

app/src/main/java/com/owncloud/android/ui/adapter/RecommendedFilesAdapter.kt

@@ -15,7 +15,7 @@ import com.owncloud.android.datamodel.OCFile
 
 class RecommendedFilesAdapter(
     private val fileListAdapter: OCFileListAdapter,
-    private val recommendations: ArrayList<OCFile>
+    private val recommendations: List<OCFile>
 ) : RecyclerView.Adapter<OCFileListRecommendedItemViewHolder>() {
 
     fun getItemPosition(file: OCFile): Int = recommendations.indexOf(file)