improve get user info

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Author: alperozturk96

library/src/main/java/com/owncloud/android/lib/resources/users/GetUserInfoRemoteOperation.kt

@@ -2,114 +2,99 @@
  * Nextcloud Android Library
  *
  * SPDX-FileCopyrightText: 2017-2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-FileCopyrightText: 2026 Alper Ozturk <alper.ozturk@nextcloud.com>
  * SPDX-FileCopyrightText: 2017 Tobias Kaminsky <tobias@kaminsky.me>
  * SPDX-License-Identifier: MIT
  */
-package com.owncloud.android.lib.resources.users;
-
-import com.google.gson.reflect.TypeToken;
-import com.nextcloud.common.NextcloudClient;
-import com.nextcloud.operations.GetMethod;
-import com.owncloud.android.lib.common.Quota;
-import com.owncloud.android.lib.common.UserInfo;
-import com.owncloud.android.lib.common.operations.RemoteOperationResult;
-import com.owncloud.android.lib.common.utils.Log_OC;
-import com.owncloud.android.lib.ocs.ServerResponse;
-import com.owncloud.android.lib.resources.OCSRemoteOperation;
-
-import org.apache.commons.httpclient.HttpStatus;
-
-import java.util.HashMap;
+package com.owncloud.android.lib.resources.users
+
+import com.google.gson.reflect.TypeToken
+import com.nextcloud.common.NextcloudClient
+import com.nextcloud.operations.GetMethod
+import com.owncloud.android.lib.common.Quota
+import com.owncloud.android.lib.common.UserInfo
+import com.owncloud.android.lib.common.operations.RemoteOperationResult
+import com.owncloud.android.lib.common.utils.Log_OC
+import com.owncloud.android.lib.ocs.ServerResponse
+import com.owncloud.android.lib.resources.OCSRemoteOperation
+import org.apache.commons.httpclient.HttpStatus
 
 /**
- * Gets information (id, display name, and e-mail address and many other things) about the user logged in.
- *
- * @author masensio
- * @author David A. Velasco
- * @author Mario Danic
+ * Gets information (id, display name, e-mail address and many other things) about the user logged in.
  */
-public class GetUserInfoRemoteOperation extends OCSRemoteOperation<UserInfo> {
-
-    private static final String TAG = GetUserInfoRemoteOperation.class.getSimpleName();
-
-    // OCS Route
-    private static final String OCS_ROUTE_SELF = "/ocs/v2.php/cloud/user";
+class GetUserInfoRemoteOperation : OCSRemoteOperation<UserInfo>() {
+    @Suppress("TooGenericExceptionCaught")
+    override fun run(client: NextcloudClient): RemoteOperationResult<UserInfo> {
+        val getMethod = GetMethod(client.baseUri.toString() + OCS_ROUTE_SELF + JSON_FORMAT, true)
+        getMethod.addRequestHeader(CONTENT_TYPE, JSON_UTF8_ENCODED)
+
+        return try {
+            val status = client.execute(getMethod)
+            if (status != HttpStatus.SC_OK) {
+                return failure(getMethod, status)
+            }
 
-    /**
-     * Quota return value for a not computed space value.
-     */
-    public static final long SPACE_NOT_COMPUTED = -1;
+            parseUserInfo(getMethod)?.let { success(getMethod, it) } ?: missingUserInfoFailure(getMethod)
+        } catch (e: Exception) {
+            failure(e)
+        } finally {
+            getMethod.releaseConnection()
+        }
+    }
 
-    /**
-     * Quota return value for unknown space value.
-     */
-    public static final long SPACE_UNKNOWN = -2;
+    private fun parseUserInfo(method: GetMethod): UserInfo? =
+        getServerResponse(method, object : TypeToken<ServerResponse<UserInfo>>() {})?.ocs?.data
 
-    /**
-     * Quota return value for unlimited space.
-     */
-    public static final long SPACE_UNLIMITED = -3;
+    private fun success(
+        method: GetMethod,
+        userInfo: UserInfo
+    ): RemoteOperationResult<UserInfo> =
+        RemoteOperationResult<UserInfo>(true, method).apply {
+            resultData = userInfo.withResolvedQuota()
+        }
 
     /**
-     * Quota return value for quota information not available.
+     * A missing quota, or a quota of 0, means the server did not report one — it is not an actual limit of zero.
      */
-    public static final long QUOTA_LIMIT_INFO_NOT_AVAILABLE = Long.MIN_VALUE;
-
-    @Override
-    public RemoteOperationResult<UserInfo> run(NextcloudClient client) {
-        RemoteOperationResult<UserInfo> result;
-        int status;
-        GetMethod get = null;
-
-        String url = client.getBaseUri() + OCS_ROUTE_SELF;
-
-        // get the user
-        try {
+    private fun UserInfo.withResolvedQuota(): UserInfo =
+        copy(quota = quota?.takeIf { it.quota != 0L } ?: Quota(QUOTA_LIMIT_INFO_NOT_AVAILABLE))
+
+    private fun failure(
+        method: GetMethod,
+        status: Int
+    ): RemoteOperationResult<UserInfo> {
+        val response = method.getResponseBodyAsString()
+        val message = if (response.isEmpty()) "" else "; response message: $response"
+        Log_OC.e(TAG, "Failed response while getting user information, status code: $status$message")
+        return RemoteOperationResult(false, method)
+    }
 
-            get = new GetMethod(url, true);
-            HashMap<String, String> map = new HashMap<>();
-            map.put("format", "json");
+    private fun missingUserInfoFailure(method: GetMethod): RemoteOperationResult<UserInfo> {
+        Log_OC.e(TAG, "User information missing in response")
+        return RemoteOperationResult(false, method)
+    }
 
-            get.setQueryString(map);
-            status = client.execute(get);
+    @Suppress("DEPRECATION")
+    private fun failure(e: Exception): RemoteOperationResult<UserInfo> =
+        RemoteOperationResult<UserInfo>(e).also {
+            Log_OC.e(TAG, "Exception while getting user information: " + it.logMessage, it.exception)
+        }
 
-            if (isSuccess(status)) {
-                ServerResponse<UserInfo> ocsResponse = getServerResponse(get, new TypeToken<>() {});
+    companion object {
+        private val TAG = GetUserInfoRemoteOperation::class.java.simpleName
 
-                if (ocsResponse != null) {
-                    UserInfo userInfo = ocsResponse.ocs.data;
+        private const val OCS_ROUTE_SELF = "/ocs/v2.php/cloud/user"
 
-                    if (userInfo.getQuota() == null || userInfo.getQuota().getQuota() == 0) {
-                        userInfo.setQuota(new Quota(QUOTA_LIMIT_INFO_NOT_AVAILABLE));
-                    }
+        private const val JSON_UTF8_ENCODED = "application/json; charset=utf-8"
 
-                    result = new RemoteOperationResult<>(true, get);
-                    result.setResultData(userInfo);
-                } else {
-                    result = new RemoteOperationResult<>(false, get);
-                }
-            } else {
-                result = new RemoteOperationResult<>(false, get);
-                String response = get.getResponseBodyAsString();
-                Log_OC.e(TAG, "Failed response while getting user information");
-                if (response.isEmpty()) {
-                    Log_OC.e(TAG, "*** status code: " + status);
-                } else {
-                    Log_OC.e(TAG, "*** status code: " + status + "; response message: " + response);
-                }
-            }
-        } catch (Exception e) {
-            result = new RemoteOperationResult<>(e);
-            Log_OC.e(TAG, "Exception while getting OC user information", e);
-        } finally {
-            if (get != null) {
-                get.releaseConnection();
-            }
-        }
-        return result;
-    }
+        /**
+         * Quota return value for unlimited space.
+         */
+        const val SPACE_UNLIMITED = -3L
 
-    private boolean isSuccess(int status) {
-        return (status == HttpStatus.SC_OK);
+        /**
+         * Quota return value for quota information not available.
+         */
+        const val QUOTA_LIMIT_INFO_NOT_AVAILABLE = Long.MIN_VALUE
     }
 }