fix: Remove user memoization

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>

Author: Koc

lib/CurrentUser.php

@@ -17,13 +17,6 @@
 
 class CurrentUser {
 
-	/** @var string|null */
-	protected $identifier = null;
-	/** @var string|false|null */
-	protected $cloudId = false;
-	/** @var string|false|null */
-	protected $sessionUser = false;
-
 	public function __construct(
 		protected readonly IUserSession $userSession,
 		protected readonly IRequest $request,
@@ -46,25 +39,21 @@ public function getUserIdentifier(): string {
 
 		$uid = $this->getUID();
 		if ($uid !== null) {
-			$this->identifier = $uid;
-			return $this->identifier;
+			return $uid;
 		}
 
 		$cloudId = $this->getCloudIDFromToken();
 		if ($cloudId !== null) {
-			$this->identifier = $cloudId;
-			return $this->identifier;
+			return $cloudId;
 		}
 
 		$nickname = htmlspecialchars($this->request->getHeader('X-NC-Nickname'));
 		if ($nickname !== '') {
-			$this->identifier = $nickname . ' (' . $this->l10nFactory->get('comments')->t('remote user') . ')';
-			return $this->identifier;
+			return $nickname . ' (' . $this->l10nFactory->get('comments')->t('remote user') . ')';
 		}
 
 		// Nothing worked, fallback to empty string
-		$this->identifier = '';
-		return $this->identifier;
+		return '';
 	}
 
 	/**
@@ -79,8 +68,7 @@ public function getUID(): ?string {
 				$this->sessionUser = null;
 			}
 		}
-
-		return $this->sessionUser;
+		return null;
 	}
 
 	/**
@@ -95,8 +83,6 @@ public function getCloudId(): ?string {
 				$this->cloudId = $this->getCloudIDFromToken();
 			}
 		}
-
-		return $this->cloudId;
 	}
 
 	/**

tests/CurrentUserTest.php

@@ -87,7 +87,6 @@ public static function dataGetUserIdentifier(): array {
 			[null, null, null, ''],
 			[null, 'uid', '-1', 'uid'],
 			[null, null, 'token', 'token'],
-			['cached', -1, -1, 'cached'],
 		];
 	}
 
@@ -98,8 +97,6 @@ public function testGetUserIdentifier(?string $cachedIdentifier, string|int|null
 			'getCloudIDFromToken',
 		]);
 
-		self::invokePrivate($instance, 'identifier', [$cachedIdentifier]);
-
 		$instance->expects($uidResult !== -1 ? $this->once() : $this->never())
 			->method('getUID')
 			->willReturn($uidResult);