refactor: Modernize code and remove long AI generated comment

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Author: CarlSchwan

lib/Controller/APIv2Controller.php

@@ -19,6 +19,7 @@
 use OCP\Activity\IFilter;
 use OCP\Activity\IManager;
 use OCP\AppFramework\Http;
+use OCP\AppFramework\Http\Attribute\NoAdminRequired;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\OCSController;
 use OCP\Files\FileInfo;
@@ -94,36 +95,33 @@ protected function validateParameters(string $filter, int $since, int $limit, bo
 	}
 
 	/**
-	 * @NoAdminRequired
-	 *
 	 * @param string $search Only return activities whose file path contains this substring
 	 * @param int $from Only return activities at or after this Unix timestamp
 	 * @param int $to Only return activities at or before this Unix timestamp
 	 * @param string $actor Only return activities authored by this account
 	 */
+	#[NoAdminRequired]
 	public function getDefault(int $since = 0, int $limit = 50, bool $previews = false, string $object_type = '', int $object_id = 0, string $sort = 'desc', string $search = '', int $from = 0, int $to = 0, string $actor = ''): DataResponse {
 		return $this->get('all', $since, $limit, $previews, $object_type, $object_id, $sort, $search, $from, $to, $actor);
 	}
 
 	/**
-	 * @NoAdminRequired
-	 *
 	 * @param string $search Only return activities whose file path contains this substring
 	 * @param int $from Only return activities at or after this Unix timestamp
 	 * @param int $to Only return activities at or before this Unix timestamp
 	 * @param string $actor Only return activities authored by this account
 	 */
+	#[NoAdminRequired]
 	public function getFilter(string $filter, int $since = 0, int $limit = 50, bool $previews = false, string $object_type = '', int $object_id = 0, string $sort = 'desc', string $search = '', int $from = 0, int $to = 0, string $actor = ''): DataResponse {
 		return $this->get($filter, $since, $limit, $previews, $object_type, $object_id, $sort, $search, $from, $to, $actor);
 	}
 
 	/**
-	 * @NoAdminRequired
-	 *
 	 * @param string $object_type Object type to count downloads for (must be 'files')
 	 * @param int $object_id File ID
 	 * @return DataResponse
 	 */
+	#[NoAdminRequired]
 	public function getDownloadCount(string $object_type = 'files', int $object_id = 0): DataResponse {
 		$user = $this->userSession->getUser();
 		if (!$user instanceof IUser) {
@@ -141,10 +139,9 @@ public function getDownloadCount(string $object_type = 'files', int $object_id =
 	}
 
 	/**
-	 * @NoAdminRequired
-	 *
-	 * @return DataResponse
+	 * @return DataResponse<Http::STATUS_OK, list<array{id: string, name: string, icon: string, priority: int}>, array{}>
 	 */
+	#[NoAdminRequired]
 	public function listFilters(): DataResponse {
 		$filters = $this->activityManager->getFilters();
 

lib/Data.php

@@ -360,24 +360,6 @@ public function get(GroupHelper $groupHelper, UserSettings $userSettings, string
 	/**
 	 * Narrow a stream query down to a date range, a file path search term
 	 * and/or the account that authored the activity.
-	 *
-	 * Every restriction is added with andWhere() so they compose with the
-	 * filter, object and pagination conditions the caller has already applied.
-	 *
-	 * On scalability: the date range is served by the existing
-	 * `activity_user_time` (affecteduser, timestamp) index, so it is a plain
-	 * index range scan and actually makes the query cheaper the narrower it
-	 * gets. The search term is a substring match and therefore cannot use an
-	 * index; it stays bounded because every stream query is already anchored to
-	 * a single `affecteduser`, and combining it with a date range narrows the
-	 * scan further. That is also why very short terms are rejected upfront in
-	 * {@see SearchCriteria::create()}.
-	 *
-	 * The actor restriction is served by `activity_filter_by`
-	 * (affecteduser, user, timestamp), so it stays index-ordered too. It
-	 * composes with the `self` and `by` filters, which restrict the same
-	 * column: `by` combined with an actor yields everyone else's activity
-	 * narrowed to that one account.
 	 */
 	private function applySearchCriteria(IQueryBuilder $query, SearchCriteria $criteria): void {
 		if ($criteria->from !== null) {