Skip to content

Commit 1e083ed

Browse files
come-nccome-nc
authored
Merge pull request #2858 from nextcloud/fix/remove-new-psalm-rules
Suppress MissingPureAnnotation and MissingImmutableAnnotation
2 parents 4b6f370 + fca0468 commit 1e083ed

2 files changed

Lines changed: 3 additions & 184 deletions

File tree

‎psalm.xml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
<directory name="vendor-bin/psalm/vendor" />
2222
</extraFiles>
2323
<issueHandlers>
24+
<MissingPureAnnotation errorLevel="suppress"/>
25+
<MissingImmutableAnnotation errorLevel="suppress"/>
2426
<UndefinedClass>
2527
<errorLevel type="suppress">
2628
<referencedClass name="Doctrine\DBAL\Platforms\AbstractMySQLPlatform" />

‎tests/psalm-baseline.xml‎

Lines changed: 1 addition & 184 deletions
Original file line numberDiff line numberDiff line change
@@ -1,57 +1,17 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<files psalm-version="7.0.0-beta19@7e751c06a756fa64dc4c759c09fe4a173afcb433">
2+
<files psalm-version="6.15.1@28dc127af1b5aecd52314f6f645bafc10d0e11f9">
33
<file src="lib/BackgroundJob/RemoteActivity.php">
4-
<MissingPureAnnotation>
5-
<code><![CDATA[run]]></code>
6-
<code><![CDATA[translateType]]></code>
7-
</MissingPureAnnotation>
84
<UndefinedClass>
95
<code><![CDATA[ClientException]]></code>
106
</UndefinedClass>
117
</file>
12-
<file src="lib/Capabilities.php">
13-
<MissingPureAnnotation>
14-
<code><![CDATA[getCapabilities]]></code>
15-
</MissingPureAnnotation>
16-
</file>
17-
<file src="lib/Command/SendEmails.php">
18-
<MissingImmutableAnnotation>
19-
<code><![CDATA[SendEmails]]></code>
20-
</MissingImmutableAnnotation>
21-
</file>
22-
<file src="lib/Consumer.php">
23-
<MissingPureAnnotation>
24-
<code><![CDATA[__construct]]></code>
25-
</MissingPureAnnotation>
26-
</file>
278
<file src="lib/Controller/RemoteActivityController.php">
28-
<MissingPureAnnotation>
29-
<code><![CDATA[getSubject]]></code>
30-
<code><![CDATA[translateType]]></code>
31-
</MissingPureAnnotation>
329
<UndefinedClass>
3310
<code><![CDATA[$storage]]></code>
3411
<code><![CDATA[Wrapper]]></code>
3512
</UndefinedClass>
3613
</file>
37-
<file src="lib/CurrentUser.php">
38-
<MissingPureAnnotation>
39-
<code><![CDATA[__construct]]></code>
40-
</MissingPureAnnotation>
41-
</file>
42-
<file src="lib/Dashboard/ActivityWidget.php">
43-
<MissingPureAnnotation>
44-
<code><![CDATA[__construct]]></code>
45-
<code><![CDATA[getIconClass]]></code>
46-
<code><![CDATA[getId]]></code>
47-
<code><![CDATA[getOrder]]></code>
48-
<code><![CDATA[getReloadInterval]]></code>
49-
</MissingPureAnnotation>
50-
</file>
5114
<file src="lib/Data.php">
52-
<MissingPureAnnotation>
53-
<code><![CDATA[__construct]]></code>
54-
</MissingPureAnnotation>
5515
<UndefinedDocblockClass>
5616
<code><![CDATA[$favoriteFilter->filterFavorites($query);]]></code>
5717
</UndefinedDocblockClass>
@@ -60,26 +20,8 @@
6020
<InvalidArrayOffset>
6121
<code><![CDATA[[$user->getEMailAddress() => $user->getDisplayName()]]]></code>
6222
</InvalidArrayOffset>
63-
<MissingPureAnnotation>
64-
<code><![CDATA[__construct]]></code>
65-
</MissingPureAnnotation>
66-
</file>
67-
<file src="lib/Extension/Files.php">
68-
<MissingImmutableAnnotation>
69-
<code><![CDATA[Files]]></code>
70-
</MissingImmutableAnnotation>
71-
</file>
72-
<file src="lib/Extension/Files_Sharing.php">
73-
<MissingImmutableAnnotation>
74-
<code><![CDATA[Files_Sharing]]></code>
75-
</MissingImmutableAnnotation>
7623
</file>
7724
<file src="lib/FilesHooks.php">
78-
<MissingPureAnnotation>
79-
<code><![CDATA[__construct]]></code>
80-
<code><![CDATA[getUserRelativePath]]></code>
81-
<code><![CDATA[getVisiblePath]]></code>
82-
</MissingPureAnnotation>
8325
<UndefinedClass>
8426
<code><![CDATA[$this->teamManager]]></code>
8527
<code><![CDATA[$this->teamManager]]></code>
@@ -95,129 +37,4 @@
9537
<code><![CDATA[$rules]]></code>
9638
</UndefinedDocblockClass>
9739
</file>
98-
<file src="lib/FilesHooksStatic.php">
99-
<MissingPureAnnotation>
100-
<code><![CDATA[getHooks]]></code>
101-
</MissingPureAnnotation>
102-
</file>
103-
<file src="lib/Filter/AllFilter.php">
104-
<MissingPureAnnotation>
105-
<code><![CDATA[__construct]]></code>
106-
<code><![CDATA[allowedApps]]></code>
107-
<code><![CDATA[filterTypes]]></code>
108-
<code><![CDATA[getIdentifier]]></code>
109-
<code><![CDATA[getPriority]]></code>
110-
</MissingPureAnnotation>
111-
</file>
112-
<file src="lib/Filter/ByFilter.php">
113-
<MissingPureAnnotation>
114-
<code><![CDATA[__construct]]></code>
115-
<code><![CDATA[allowedApps]]></code>
116-
<code><![CDATA[filterTypes]]></code>
117-
<code><![CDATA[getIdentifier]]></code>
118-
<code><![CDATA[getPriority]]></code>
119-
</MissingPureAnnotation>
120-
</file>
121-
<file src="lib/Filter/SelfFilter.php">
122-
<MissingPureAnnotation>
123-
<code><![CDATA[__construct]]></code>
124-
<code><![CDATA[allowedApps]]></code>
125-
<code><![CDATA[filterTypes]]></code>
126-
<code><![CDATA[getIdentifier]]></code>
127-
<code><![CDATA[getPriority]]></code>
128-
</MissingPureAnnotation>
129-
</file>
130-
<file src="lib/GroupHelper.php">
131-
<MissingPureAnnotation>
132-
<code><![CDATA[__construct]]></code>
133-
<code><![CDATA[getEvents]]></code>
134-
<code><![CDATA[resetEvents]]></code>
135-
<code><![CDATA[setL10n]]></code>
136-
</MissingPureAnnotation>
137-
</file>
138-
<file src="lib/Listener/SetUserDefaults.php">
139-
<MissingPureAnnotation>
140-
<code><![CDATA[__construct]]></code>
141-
</MissingPureAnnotation>
142-
</file>
143-
<file src="lib/Listener/ShareEventListener.php">
144-
<MissingPureAnnotation>
145-
<code><![CDATA[__construct]]></code>
146-
</MissingPureAnnotation>
147-
</file>
148-
<file src="lib/Listener/UserDeleted.php">
149-
<MissingPureAnnotation>
150-
<code><![CDATA[__construct]]></code>
151-
</MissingPureAnnotation>
152-
</file>
153-
<file src="lib/MailQueueHandler.php">
154-
<MissingPureAnnotation>
155-
<code><![CDATA[__construct]]></code>
156-
</MissingPureAnnotation>
157-
</file>
158-
<file src="lib/Migration/Version2006Date20170808155040.php">
159-
<MissingPureAnnotation>
160-
<code><![CDATA[changeSchema]]></code>
161-
</MissingPureAnnotation>
162-
</file>
163-
<file src="lib/Migration/Version2006Date20170919095939.php">
164-
<MissingPureAnnotation>
165-
<code><![CDATA[changeSchema]]></code>
166-
<code><![CDATA[getColumnsByTable]]></code>
167-
</MissingPureAnnotation>
168-
</file>
169-
<file src="lib/Migration/Version2011Date20201006132544.php">
170-
<MissingPureAnnotation>
171-
<code><![CDATA[__construct]]></code>
172-
</MissingPureAnnotation>
173-
</file>
174-
<file src="lib/Migration/Version2011Date20201006132546.php">
175-
<MissingPureAnnotation>
176-
<code><![CDATA[__construct]]></code>
177-
</MissingPureAnnotation>
178-
</file>
179-
<file src="lib/NotificationGenerator.php">
180-
<MissingPureAnnotation>
181-
<code><![CDATA[__construct]]></code>
182-
<code><![CDATA[getID]]></code>
183-
<code><![CDATA[getName]]></code>
184-
</MissingPureAnnotation>
185-
</file>
186-
<file src="lib/Settings/Admin.php">
187-
<MissingPureAnnotation>
188-
<code><![CDATA[__construct]]></code>
189-
<code><![CDATA[getPriority]]></code>
190-
<code><![CDATA[getSection]]></code>
191-
</MissingPureAnnotation>
192-
</file>
193-
<file src="lib/Settings/AdminSection.php">
194-
<MissingPureAnnotation>
195-
<code><![CDATA[__construct]]></code>
196-
<code><![CDATA[getID]]></code>
197-
<code><![CDATA[getPriority]]></code>
198-
</MissingPureAnnotation>
199-
</file>
200-
<file src="lib/Settings/Personal.php">
201-
<MissingPureAnnotation>
202-
<code><![CDATA[getPriority]]></code>
203-
<code><![CDATA[getSection]]></code>
204-
</MissingPureAnnotation>
205-
</file>
206-
<file src="lib/Settings/PersonalSection.php">
207-
<MissingPureAnnotation>
208-
<code><![CDATA[__construct]]></code>
209-
<code><![CDATA[getID]]></code>
210-
<code><![CDATA[getPriority]]></code>
211-
</MissingPureAnnotation>
212-
</file>
213-
<file src="lib/UserSettings.php">
214-
<MissingPureAnnotation>
215-
<code><![CDATA[__construct]]></code>
216-
</MissingPureAnnotation>
217-
</file>
218-
<file src="lib/ViewInfoCache.php">
219-
<MissingPureAnnotation>
220-
<code><![CDATA[__construct]]></code>
221-
</MissingPureAnnotation>
222-
</file>
22340
</files>

0 commit comments

Comments
 (0)