test(dialog): move component tests out of lib and cover more cases

- Move the Playwright component tests to tests/ct/ so they are outside the
  library's rootDir (they import fixtures outside lib, which broke the build
  and ts:check).
- Add Share.setRecipientPermission / selectRecipientPreset unit tests.
- Add SharePanel tab-bar tests (hidden once a recipient exists).
- Rename the recipient remove action to "Remove participant" and add left
  padding to the recipient list.

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Author: skjnldsv

lib/dialog/api/share.spec.ts

@@ -22,6 +22,8 @@ vi.mock('./sharing.ts', () => ({
 	updateShareProperty: vi.fn(),
 	updateSharePermission: vi.fn(),
 	selectSharePermissionPreset: vi.fn(),
+	updateShareRecipientPermission: vi.fn(),
+	selectShareRecipientPermissionPreset: vi.fn(),
 	updateShareState: vi.fn(),
 	searchRecipients: vi.fn(),
 	deleteShare: vi.fn(),
@@ -119,6 +121,20 @@ describe('Share', () => {
 		expect(mocked.updateSharePermission).toHaveBeenCalledWith('abc', 'C', false)
 	})
 
+	it('setRecipientPermission forwards recipient identity, permission and flag', async () => {
+		const instance = await makeShare()
+		mocked.updateShareRecipientPermission.mockResolvedValue(share())
+		await instance.setRecipientPermission('R', 'bob', 'C', true, 'inst')
+		expect(mocked.updateShareRecipientPermission).toHaveBeenCalledWith('abc', 'R', 'bob', 'C', true, 'inst')
+	})
+
+	it('selectRecipientPreset forwards recipient identity and preset', async () => {
+		const instance = await makeShare()
+		mocked.selectShareRecipientPermissionPreset.mockResolvedValue(share())
+		await instance.selectRecipientPreset('R', 'bob', 'PresetX')
+		expect(mocked.selectShareRecipientPermissionPreset).toHaveBeenCalledWith('abc', 'R', 'bob', 'PresetX', undefined)
+	})
+
 	it('addSource forwards the class and value', async () => {
 		const instance = await makeShare()
 		mocked.addShareSource.mockResolvedValue(share())

lib/dialog/components/RecipientList.vue

@@ -33,5 +33,6 @@ const recipients = computed(() => props.share.recipients.filter((recipient) => r
 	display: flex;
 	flex-direction: column;
 	gap: calc(var(--default-grid-baseline) * 3);
+	padding-inline-start: calc(var(--default-grid-baseline) * 2);
 }
 </style>

lib/dialog/components/RecipientRow.vue

@@ -40,7 +40,7 @@
 				<template #icon>
 					<NcIconSvgWrapper :svg="IconDelete" :size="20" />
 				</template>
-				{{ t('Remove') }}
+				{{ t('Remove participant') }}
 			</NcActionButton>
 		</NcActions>
 

lib/dialog/components/SharePanel.spec.ts

@@ -8,7 +8,7 @@ import type { SharingShare } from '../types/api.ts'
 import { flushPromises, shallowMount } from '@vue/test-utils'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 import SharePanel from './SharePanel.vue'
-import { PROPERTY_EXPIRATION, PROPERTY_PASSWORD, RECIPIENT_TYPE_TOKEN, SOURCE_TYPE_NODE } from '../constants.ts'
+import { PROPERTY_EXPIRATION, PROPERTY_PASSWORD, RECIPIENT_TYPE_TOKEN, RECIPIENT_TYPE_USER, SOURCE_TYPE_NODE } from '../constants.ts'
 import { ShareDialogTab } from '../types/ui.ts'
 
 const PRESET_VIEW = 'preset-view'
@@ -143,6 +143,30 @@ describe('SharePanel presets and permissions', () => {
 	})
 })
 
+describe('SharePanel tab bar', () => {
+	const recipient = {
+		class: RECIPIENT_TYPE_USER,
+		value: 'bob',
+		instance: null,
+		display_name: 'Bob',
+		icon: null,
+		secret: { updatable: false },
+		initiator: null,
+		permission_preset: null,
+		permissions: [],
+	}
+
+	it('shows the share-type tabs when there are no recipients', () => {
+		const { wrapper } = mountPanel()
+		expect(wrapper.findComponent({ name: 'NcRadioGroup' }).exists()).toBe(true)
+	})
+
+	it('hides the share-type tabs once a recipient exists', () => {
+		const { wrapper } = mountPanel(schema({ recipients: [recipient] }))
+		expect(wrapper.findComponent({ name: 'NcRadioGroup' }).exists()).toBe(false)
+	})
+})
+
 describe('SharePanel recipient sync', () => {
 	it('adds a token recipient when opening on the Anyone tab', async () => {
 		const { share } = mountPanel(schema(), { shareDialogTab: ShareDialogTab.Anyone })

package.json

@@ -46,8 +46,8 @@
     "lint": "eslint",
     "lint:fix": "eslint --fix",
     "test": "vitest run",
-    "test:ct": "playwright test -c playwright-ct.config.ts",
     "test:coverage": "vitest run --coverage",
+    "test:ct": "playwright test -c playwright-ct.config.ts",
     "test:watch": "vitest run --watch",
     "ts:check": "vue-tsc --noEmit",
     "watch": "vite --mode development build --watch"

playwright-ct.config.ts

@@ -6,7 +6,7 @@
 import { defineConfig, devices } from '@playwright/experimental-ct-vue'
 
 export default defineConfig({
-	testDir: './lib',
+	testDir: './tests/ct',
 	// Component tests are named *.ct.ts so Vitest (which globs *.spec/*.test)
 	// ignores them and only Playwright picks them up.
 	testMatch: '**/*.ct.ts',

…dialog/components/PermissionEditor.ct.ts tests/ct/PermissionEditor.ct.tslib/dialog/components/PermissionEditor.ct.ts renamed to tests/ct/PermissionEditor.ct.ts lib/dialog/components/PermissionEditor.ct.ts renamed to tests/ct/PermissionEditor.ct.ts

@@ -4,7 +4,7 @@
  */
 
 import { expect, test } from '@playwright/experimental-ct-vue'
-import PermissionEditor from './PermissionEditor.vue'
+import PermissionEditor from '../../lib/dialog/components/PermissionEditor.vue'
 
 const baseProps = {
 	presetOptions: [{ value: 'View', label: 'Can view' }, { value: 'custom', label: 'Can…' }],

lib/dialog/components/RecipientList.ct.ts tests/ct/RecipientList.ct.tslib/dialog/components/RecipientList.ct.ts renamed to tests/ct/RecipientList.ct.ts

@@ -4,7 +4,7 @@
  */
 
 import { expect, test } from '@playwright/experimental-ct-vue'
-import Fixture from '../../../tests/ct/fixtures/RecipientListFixture.vue'
+import Fixture from './fixtures/RecipientListFixture.vue'
 
 test('renders a row per recipient, excluding the link (token)', async ({ mount }) => {
 	const component = await mount(Fixture)

lib/dialog/components/RecipientRow.ct.ts tests/ct/RecipientRow.ct.tslib/dialog/components/RecipientRow.ct.ts renamed to tests/ct/RecipientRow.ct.ts

@@ -4,7 +4,7 @@
  */
 
 import { expect, test } from '@playwright/experimental-ct-vue'
-import Fixture from '../../../tests/ct/fixtures/RecipientRowFixture.vue'
+import Fixture from './fixtures/RecipientRowFixture.vue'
 
 test('shows the recipient name and a static preset subtitle', async ({ mount }) => {
 	const component = await mount(Fixture)
@@ -20,7 +20,7 @@ test('removes the recipient from the menu', async ({ mount, page }) => {
 	}
 	const component = await mount(Fixture, { on: { removed: onRemoved } })
 	await component.getByRole('button', { name: 'Recipient actions' }).click()
-	await page.getByRole('menuitem', { name: 'Remove' }).click()
+	await page.getByRole('menuitem', { name: 'Remove participant' }).click()
 	expect(removed).toBe(true)
 })