Skip to content

Motor constants setter only called when full motor constants object is supplied instead of at attribute change #507

Description

@tkevinbest

@senthurayyappan I found an issue with how I did this. The setter method is only called when assigning entirely new motor_constants objects. If you try to just write to one of them like osl.ankle.MOTOR_CONSTANTS.NM_PER_AMP = .1, the setter logic doesn't get called. I think we can fix this with __setattr__ overloads or something like that...

Originally posted by @tkevinbest in #489 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions