Skip to content

mcp-manager: allowInputRequired passthrough on callTool / readResource / getPrompt options (G10) #28

Description

@kauandotnet

Found while adapting control-plane-api to consume the new surface from #24 (dogfood commit 364f527). Per the upstream-first policy, the app kept its own code at these seams and the gap is recorded here instead of being patched around in packages/. Condensed from the neutrality audit in the #24 PR description.

G10 — The manager's convenience methods drop allowInputRequired. McpRuntimeToolCallOptions carries only { signal?, toolDefinition? }, and the manager builds the client call from exactly those - there is no passthrough for @nestm/mcp-client's allowInputRequired: true (a real, typed option on the client runtime); readResource/getPrompt on the port take a bare signal and have the same hole. Elicitation-capable callers (e.g. a hub/gateway adapter) must therefore stay on raw withClientRuntime leases, re-opening a lease per request purely to reach one option — exactly the hand-rolling the callTool options split (#24) was meant to remove. Requested: add readonly allowInputRequired?: boolean to McpRuntimeToolCallOptions, and give readResource/getPrompt an options-object overload carrying the same field.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions