Advanced Twitter Client

[neerajakshid]

Advanced Twitter Client app is almost complete. I am half way working on Direct Messages, but couldn't find time to complete today.. Except that all other user stories are ready to review.

Please review. /cc @codepathreview @codepath

[codepathreview]

👍 Excellent work, appreciate all the efforts that you put in these assignments outside of your full-time job. A few notes after checking out the code:

• Glad to see you properly hooked up each of the different timelines to infinitely paginate.
• Nice to see you played around with styling the sliding tab strip
• Great effort on making the app look twitter branded
• Nice to see you have progress bars displayed during background tasks
• Nice use of tag to setup the ability to click the profile image and view a user's profile
• Nice job getting the Favorite/Retweet/Search features working.
• Consider notifying users about Failures (ex. home timeline load failure)
• For a future exercise, challenge yourself to clean up a bit of your code using inheritance by putting major code in the base class - TweetListFragment and having HomeFragment, MentionsFragment, etc extend from the base class. Currently, all your logic is inside the TweetListFragment, which makes it very confusing to step through. For example, the scroll listener could be set in the base class and then the "onLoadMore" could call an abstract method which is defined separately in the extended class. This approach could be used to move almost all the logic into the base except for certain key abstract methods.

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp, we are going to have a public demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.

[neerajakshid]

Thanks for the review.. I thought of cleaning up the Fragments after completing all the features.. Finally, I dint get time to do that.. Going further I will consider your last review point and start thinking up about cleaning the code at very early stages of development..