Skip to content
This repository was archived by the owner on May 7, 2020. It is now read-only.
This repository was archived by the owner on May 7, 2020. It is now read-only.

Refresh Button not Displaying in Some Courses on 3.5 #50

Description

@dustinbrisebois

We observed some instances of courses, the refresh button is not available.

When we looked at it we noticed that by changing the logic in block_fn_marking.php on line 373 from:

if ($cachedatalast === false) { $humantime = get_string('lastrefreshrequired', 'block_fn_marking'); $showrefreshbutton = true; $this->content->items = array(); $this->content->icons = array(); **} else if ($cachedatalast > 0) {** $humantime = get_string('lastrefreshtime', 'block_fn_marking', block_fn_marking_human_timing($cachedatalast)); $showrefreshbutton = true; } else { $humantime = get_string('lastrefreshupdating', 'block_fn_marking'); $showrefreshbutton = false; }

to:

if ($cachedatalast === false) { $humantime = get_string('lastrefreshrequired', 'block_fn_marking'); $showrefreshbutton = true; $this->content->items = array(); $this->content->icons = array(); **} else if ($cachedatalast >= 0) {** $humantime = get_string('lastrefreshtime', 'block_fn_marking', block_fn_marking_human_timing($cachedatalast)); $showrefreshbutton = true; } else { $humantime = get_string('lastrefreshupdating', 'block_fn_marking'); $showrefreshbutton = false; }

It appears that the system is checking a global value for when the last time the user commited a refresh somewhere else in the site, this is causing the fresh timer not to pass with a positive value.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions