Skip to content

OIDC discovery endpoints not validated against issuer host #11

Description

@dcmcand

Summary

TokenEndpoint and DeviceAuthEndpoint from the OIDC discovery document are used without validating they share the same host as the issuer URL. A compromised discovery document could redirect token requests to an attacker-controlled endpoint.

Location

  • cli/internal/auth/device_flow.go (line 84+)

Risk

Device code and token are sent to endpoints from an untrusted discovery document. An attacker who controls the discovery response can steal auth tokens.

Suggested fix

Validate that all endpoints from the discovery document share the same scheme+host as the issuer URL.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    securitySecurity vulnerability or hardening

    Type

    No type

    Fields

    Priority

    None yet

    Start date

    None yet

    Target date

    None yet

    Size

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions