On pull_request events, build-image.yaml tags pushed images with type=sha computed from the merge commit, not the head commit. Two consequences:
- A pin committed inside the PR (the
values.yaml bump that points e2e at the PR build) can never name the build of the commit that contains it — the pin has to be added after the build, pointing at an earlier merge-commit sha.
- Any subsequent push touching
images/** builds a new sha while values.yaml still pins the old one, so e2e goes green against stale image content with no signal anywhere.
#241 dodged this only by ordering the pin as the last commit. Possible directions: have e2e fail if the pinned sha does not correspond to the current head's build, tag PR builds with the head sha as well, or have a workflow re-sync the pin on each push.
Raised in review of #241 (review).
On
pull_requestevents,build-image.yamltags pushed images withtype=shacomputed from the merge commit, not the head commit. Two consequences:values.yamlbump that points e2e at the PR build) can never name the build of the commit that contains it — the pin has to be added after the build, pointing at an earlier merge-commit sha.images/**builds a new sha whilevalues.yamlstill pins the old one, so e2e goes green against stale image content with no signal anywhere.#241 dodged this only by ordering the pin as the last commit. Possible directions: have e2e fail if the pinned sha does not correspond to the current head's build, tag PR builds with the head sha as well, or have a workflow re-sync the pin on each push.
Raised in review of #241 (review).