Skip to content

Commit e583ae5

Browse files
committed
stream logs while helm chart is deploying
1 parent 893d23f commit e583ae5

3 files changed

Lines changed: 21 additions & 22 deletions

File tree

‎.github/workflows/test.yaml‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -29,26 +29,26 @@ jobs:
2929
run: helm dependency update
3030

3131
- name: Deploy chart
32-
run: |
33-
helm install nebari . \
34-
--namespace default \
35-
--wait \
36-
--timeout 10m
37-
38-
- name: Wait for hub pod
39-
run: |
40-
kubectl wait --for=condition=ready pod \
41-
-l component=hub \
42-
--timeout=300s
32+
run: helm install data-science-pack . --namespace default
4333

44-
- name: Wait for proxy pod
34+
- name: Wait for pods with progress
4535
run: |
46-
kubectl wait --for=condition=ready pod \
47-
-l component=proxy \
48-
--timeout=300s
49-
50-
- name: Verify pods running
51-
run: kubectl get pods
36+
for i in {1..60}; do
37+
echo "=== Attempt $i/60 ==="
38+
kubectl get pods
39+
echo "--- Hub logs (last 10 lines) ---"
40+
kubectl logs -l component=hub --tail=10 2>/dev/null || echo "(not ready)"
41+
echo "--- Proxy logs (last 5 lines) ---"
42+
kubectl logs -l component=proxy --tail=5 2>/dev/null || echo "(not ready)"
43+
if kubectl wait --for=condition=ready pod -l component=hub --timeout=5s 2>/dev/null && \
44+
kubectl wait --for=condition=ready pod -l component=proxy --timeout=5s 2>/dev/null; then
45+
echo "All pods ready!"
46+
exit 0
47+
fi
48+
sleep 5
49+
done
50+
echo "Timeout waiting for pods"
51+
exit 1
5252
5353
- name: Test JupyterHub endpoint
5454
run: |

‎README.md‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ A Helm chart for deploying JupyterHub with [jhub-apps](https://github.com/nebari
1111
- JupyterHub with Nebari's custom images
1212
- jhub-apps integration for deploying data science applications
1313
- Dummy authenticator for local development (OAuth/Keycloak configurable for production)
14-
- Optional shared storage (RWX PVC)
1514

1615
## Quick Start
1716

@@ -20,7 +19,7 @@ A Helm chart for deploying JupyterHub with [jhub-apps](https://github.com/nebari
2019
```bash
2120
helm repo add nebari https://nebari-dev.github.io/nebari-data-science-pack
2221
helm repo update
23-
helm install nebari nebari/nebari-data-science-pack
22+
helm install data-science-pack nebari/nebari-data-science-pack
2423
```
2524

2625
### Install from Source
@@ -29,7 +28,7 @@ helm install nebari nebari/nebari-data-science-pack
2928
git clone https://github.com/nebari-dev/nebari-data-science-pack.git
3029
cd nebari-data-science-pack
3130
helm dependency update
32-
helm install nebari . --namespace default
31+
helm install data-science-pack . --namespace default
3332
```
3433

3534
### Access JupyterHub

‎Tiltfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ allow_k8s_contexts('k3d-nebari-dev')
2323
# Note: helm() skips chart hooks (like image-puller), which is fine for local dev
2424
k8s_yaml(helm(
2525
'.',
26-
name='nebari',
26+
name='data-science-pack',
2727
namespace='default',
2828
))
2929

0 commit comments

Comments
 (0)