Skip to content

Replace hardcoded #fff with a theme variable (dark-mode) #69

Description

@nbkdoesntknowcoding

Several components hardcode #fff for on-accent text instead of a theme variable, which can break in dark mode / future theming.

Where (offenders found):

  • apps/web/src/components/settings/GetCommunityLicense.tsx
  • apps/web/src/components/settings/ApiKeys.tsx
  • apps/web/src/components/settings/DevSettings.tsx
  • apps/web/src/components/app/NotificationsPage.tsx
  • apps/web/src/components/app/ErrorBoundary.tsx
  • apps/web/src/components/access/JoinRequestsInbox.tsx

What to do: Replace hardcoded #fff/#ffffff on-accent text with the existing on-accent CSS variable (see components/theme/ for the token; e.g. var(--on-ink) or equivalent). Keep the visual result identical in light mode.

Done when: no hardcoded white remains in those files and the buttons/badges look unchanged in light mode.

Size: M


New here? The README has a ~90-second self-host quickstart to run the app locally. Comment on the issue if you want pointers — happy to help.

Metadata

Metadata

Assignees

No one assigned

    Labels

    help-wantedExtra attention is welcomesize/MMedium: a day or souiFrontend / UI / UX work

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions