more changes to test code and smaller fixes found by tests

Author: Daniel-Nashed

.gitignore

@@ -1,5 +1,7 @@
 .env
 bin/*
 *.exe
-testing/perftest/perftest
-testing/functest/functest
+testing/bin/*
+!testing/bin/README.md
+testing/perftest/bin/
+testing/functest/bin/

src/main.go

@@ -298,7 +298,7 @@ func handleLookup(w http.ResponseWriter, r *http.Request) {
 
     ip := r.PathValue("ip")
 
-    if ip == "" {
+    if ip == "" || !IsValidIP(ip) {
         w.Header().Set("X-Blocklist-Status", "error")
         w.WriteHeader(http.StatusBadRequest)
         logHttpReq(r, start, ReqType, "Error")
@@ -390,6 +390,12 @@ func handleAuth(w http.ResponseWriter, r *http.Request) {
 
     ip := r.PathValue("ip")
 
+    if ip == "" || !IsValidIP(ip) {
+        w.WriteHeader(http.StatusBadRequest)
+        logHttpReq(r, start, ReqType, "Error")
+        return
+    }
+
     _, blocked := ipTableLookup(ip)
 
     if blocked {
@@ -399,7 +405,7 @@ func handleAuth(w http.ResponseWriter, r *http.Request) {
     }
 
     logHttpReq(r, start, ReqType, "NotBlocked")
-    w.WriteHeader(http.StatusNoContent)
+    w.WriteHeader(http.StatusOK)
 }
 
 func handlePut(w http.ResponseWriter, r *http.Request) {

testing/bin/README.md

@@ -0,0 +1,3 @@
+Compiled test binaries are written here — this directory is intentionally tracked in git to ensure it exists after a fresh clone.
+
+Binaries are excluded via .gitignore.

testing/functest/main.go

@@ -87,7 +87,7 @@ func lookupIP(lookupBase, ip string) (LookupResponse, int, error) {
     }
     defer resp.Body.Close()
 
-    if resp.StatusCode == http.StatusNoContent {
+    if resp.StatusCode != http.StatusOK {
         return LookupResponse{Blocked: false}, resp.StatusCode, nil
     }
 

testing/functest/test,sh

@@ -0,0 +1,2 @@
+go build -buildvcs=false -o ../bin/functest
+../bin/functest

testing/perftest/test,sh

@@ -0,0 +1,2 @@
+go build -buildvcs=false -o ../bin/perftest
+../bin/perftest