From 3b108eedbe63c6ada2c4c74188a483146c609dc6 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 4 Jun 2026 08:27:52 +0000 Subject: [PATCH 1/2] Initial plan From eee89fd20aa5dbc8fec86d35244d029b97e169d1 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 4 Jun 2026 08:29:52 +0000 Subject: [PATCH 2/2] Fix rollover-unsafe millis() timeout in scannerGraphic.ino Replace `unsigned long inputTimeout = millis() + 7000` / `millis() < inputTimeout` with a subtraction-based elapsed-time check: `unsigned long inputTimeout = millis()` / `millis() - inputTimeout < 7000`. With unsigned arithmetic the subtraction wraps correctly across the ~49.7-day millis() rollover boundary, so the 7-second wait is always correct regardless of when the sketch starts. --- examples/scannerGraphic/scannerGraphic.ino | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/scannerGraphic/scannerGraphic.ino b/examples/scannerGraphic/scannerGraphic.ino index ddbed5a1b..8b4d2fd55 100644 --- a/examples/scannerGraphic/scannerGraphic.ino +++ b/examples/scannerGraphic/scannerGraphic.ino @@ -217,10 +217,10 @@ void setup(void) { // set the data rate #ifdef DEBUGGING - unsigned long inputTimeout = millis() + 7000; + unsigned long inputTimeout = millis(); Serial.print(F("Select your Data Rate. ")); Serial.println(F("Enter '1' for 1Mbps, '2' for 2Mbps, '3' for 250kbps. Defaults to 1 Mbps.")); - while (!Serial.available() && millis() < inputTimeout) { + while (!Serial.available() && millis() - inputTimeout < 7000) { // Wait for user input. Timeout after 7 seconds. } char dataRate = !Serial.available() ? '1' : Serial.parseInt();