Skip to content

OrdinaryCallingFormat returns None in s3.lookup() #30

Description

@jvivian

Hey there,

In s3-multipart-download.py you repeat the connect_s3() call
https://github.com/mumrah/s3-multipart/blob/master/s3-mp-download.py#L110-L113

which causes this to happen:

DEBUG:s3-mp-download:CLI args: Namespace(dest='./test', force=False, max_tries=5, num_processes=2, quiet=False, secure=True, split=32, src='s3://cgl-driver-projects/test/test', verbose=True)
DEBUG:s3-mp-download:split_rs: SplitResult(scheme='s3', netloc='cgl-driver-projects', path='/test/test', query='', fragment='')
Traceback (most recent call last):
  File "../../s3-multipart/s3-mp-download.py", line 170, in <module>
    main(**arg_dict)
  File "../../s3-multipart/s3-mp-download.py", line 115, in main
    raise ValueError("'%s' is not a valid bucket" % split_rs.netloc)
ValueError: 'cgl-driver-projects' is not a valid bucket

If i remove the OrdinaryCallingFormat() call, which I know let's you select buckets with dots, then it works no problem.

Unrelated, and I think this may be a boto issue, but https://github.com/mumrah/s3-multipart/blob/master/s3-mp-download.py#L116 fails if I don't provide a src that has an extension. e.g. s3://bucket/test/test fails, but s3://bucket/test/test.txt succeeds.

Thanks

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions