Skip to content

Commit ba73d2e

Browse files
majiayu000claude
majiayu000
and
claude
authored
fix: Failed to download checksums.txt when using launch to install localai (#7788)
* fix: add retry logic and fallback for checksums.txt download - Add HTTP client with 30s timeout to ReleaseManager - Implement downloadFileWithRetry with 3 attempts and exponential backoff - Allow manual checksum placement at ~/.localai/checksums/checksums-<version>.txt - Continue installation with warning if checksum download/verification fails - Add test for HTTPClient initialization - Fix linter error in systray_manager.go Fixes #7385 Signed-off-by: majiayu000 <1835304752@qq.com> * fix: add retry logic and improve checksums.txt download handling This commit addresses issue #7385 by implementing: - Retry logic (3 attempts) for checksum file downloads - Fallback to manually placed checksum files - Option to proceed with installation if checksums unavailable (with warnings) - Fixed resource leaks in download retry loop - Added configurable HTTP client with 30s timeout The installation will now be more resilient to network issues while maintaining security through checksum verification when available. Signed-off-by: majiayu000 <1835304752@qq.com> * fix: check for existing checksum file before downloading This commit addresses the review feedback from mudler on PR #7788. The code now checks if there's already a checksum file (either manually placed or previously downloaded) and honors that, skipping download entirely in such case. Changes: - Check for existing checksum file at ~/.localai/checksums/checksums-<version>.txt first - Check for existing downloaded checksum file at binary path - Only attempt to download if no existing checksum file is found - This prevents unnecessary network requests and honors user-placed checksums Signed-off-by: majiayu000 <1835304752@qq.com> 🤖 Generated with Claude Code Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> --------- Signed-off-by: majiayu000 <1835304752@qq.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 5926972 commit ba73d2e

3 files changed

Lines changed: 93 additions & 33 deletions

File tree

‎cmd/launcher/internal/release_manager.go‎

Lines changed: 89 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ type ReleaseManager struct {
4949
ChecksumsPath string
5050
// MetadataPath is where version metadata is stored
5151
MetadataPath string
52+
// HTTPClient is the HTTP client used for downloads
53+
HTTPClient *http.Client
5254
}
5355

5456
// NewReleaseManager creates a new release manager
@@ -65,14 +67,17 @@ func NewReleaseManager() *ReleaseManager {
6567
CurrentVersion: internal.PrintableVersion(),
6668
ChecksumsPath: checksumsPath,
6769
MetadataPath: metadataPath,
70+
HTTPClient: &http.Client{
71+
Timeout: 30 * time.Second,
72+
},
6873
}
6974
}
7075

7176
// GetLatestRelease fetches the latest release information from GitHub
7277
func (rm *ReleaseManager) GetLatestRelease() (*Release, error) {
7378
url := fmt.Sprintf("https://api.github.com/repos/%s/%s/releases/latest", rm.GitHubOwner, rm.GitHubRepo)
7479

75-
resp, err := http.Get(url)
80+
resp, err := rm.HTTPClient.Get(url)
7681
if err != nil {
7782
return nil, fmt.Errorf("failed to fetch latest release: %w", err)
7883
}
@@ -125,18 +130,43 @@ func (rm *ReleaseManager) DownloadRelease(version string, progressCallback func(
125130
rm.GitHubOwner, rm.GitHubRepo, version, version)
126131

127132
checksumPath := filepath.Join(rm.BinaryPath, "checksums.txt")
128-
if err := rm.downloadFile(checksumURL, checksumPath, nil); err != nil {
129-
return fmt.Errorf("failed to download checksums: %w", err)
133+
manualChecksumPath := filepath.Join(rm.ChecksumsPath, fmt.Sprintf("checksums-%s.txt", version))
134+
135+
// First, check if there's already a checksum file (either manually placed or previously downloaded)
136+
// and honor that, skipping download entirely in such case
137+
var downloadErr error
138+
if _, err := os.Stat(manualChecksumPath); err == nil {
139+
log.Printf("Using existing checksums from: %s", manualChecksumPath)
140+
checksumPath = manualChecksumPath
141+
} else if _, err := os.Stat(checksumPath); err == nil {
142+
log.Printf("Using existing checksums from: %s", checksumPath)
143+
} else {
144+
// No existing checksum file found, try to download
145+
downloadErr = rm.downloadFile(checksumURL, checksumPath, nil)
146+
147+
if downloadErr != nil {
148+
log.Printf("Warning: failed to download checksums: %v", downloadErr)
149+
log.Printf("Warning: Checksum verification will be skipped. For security, you can manually place checksums at: %s", manualChecksumPath)
150+
log.Printf("Download checksums from: %s", checksumURL)
151+
// Continue without verification - log warning but don't fail
152+
}
130153
}
131154

132-
// Verify the checksum
133-
if err := rm.VerifyChecksum(localPath, checksumPath, binaryName); err != nil {
134-
return fmt.Errorf("checksum verification failed: %w", err)
135-
}
155+
// Verify the checksum if we have a checksum file
156+
if _, err := os.Stat(checksumPath); err == nil {
157+
if err := rm.VerifyChecksum(localPath, checksumPath, binaryName); err != nil {
158+
return fmt.Errorf("checksum verification failed: %w", err)
159+
}
160+
log.Printf("Checksum verification successful")
136161

137-
// Save checksums persistently for future verification
138-
if err := rm.saveChecksums(version, checksumPath, binaryName); err != nil {
139-
log.Printf("Warning: failed to save checksums: %v", err)
162+
// Save checksums persistently for future verification
163+
if downloadErr == nil {
164+
if err := rm.saveChecksums(version, checksumPath, binaryName); err != nil {
165+
log.Printf("Warning: failed to save checksums: %v", err)
166+
}
167+
}
168+
} else {
169+
log.Printf("Warning: Proceeding without checksum verification")
140170
}
141171

142172
// Make the binary executable
@@ -168,34 +198,61 @@ func (rm *ReleaseManager) GetBinaryName(version string) string {
168198

169199
// downloadFile downloads a file from a URL to a local path with optional progress callback
170200
func (rm *ReleaseManager) downloadFile(url, filepath string, progressCallback func(float64)) error {
171-
resp, err := http.Get(url)
172-
if err != nil {
173-
return err
174-
}
175-
defer resp.Body.Close()
201+
return rm.downloadFileWithRetry(url, filepath, progressCallback, 3)
202+
}
176203

177-
if resp.StatusCode != http.StatusOK {
178-
return fmt.Errorf("bad status: %s", resp.Status)
179-
}
204+
// downloadFileWithRetry downloads a file from a URL with retry logic
205+
func (rm *ReleaseManager) downloadFileWithRetry(url, filepath string, progressCallback func(float64), maxRetries int) error {
206+
var lastErr error
180207

181-
out, err := os.Create(filepath)
182-
if err != nil {
183-
return err
184-
}
185-
defer out.Close()
208+
for attempt := 1; attempt <= maxRetries; attempt++ {
209+
if attempt > 1 {
210+
log.Printf("Retrying download (attempt %d/%d): %s", attempt, maxRetries, url)
211+
time.Sleep(time.Duration(attempt) * time.Second)
212+
}
213+
214+
resp, err := rm.HTTPClient.Get(url)
215+
if err != nil {
216+
lastErr = err
217+
continue
218+
}
186219

187-
// Create a progress reader if callback is provided
188-
var reader io.Reader = resp.Body
189-
if progressCallback != nil && resp.ContentLength > 0 {
190-
reader = &progressReader{
191-
Reader: resp.Body,
192-
Total: resp.ContentLength,
193-
Callback: progressCallback,
220+
if resp.StatusCode != http.StatusOK {
221+
resp.Body.Close()
222+
lastErr = fmt.Errorf("bad status: %s", resp.Status)
223+
continue
194224
}
225+
226+
out, err := os.Create(filepath)
227+
if err != nil {
228+
resp.Body.Close()
229+
return err
230+
}
231+
232+
// Create a progress reader if callback is provided
233+
var reader io.Reader = resp.Body
234+
if progressCallback != nil && resp.ContentLength > 0 {
235+
reader = &progressReader{
236+
Reader: resp.Body,
237+
Total: resp.ContentLength,
238+
Callback: progressCallback,
239+
}
240+
}
241+
242+
_, err = io.Copy(out, reader)
243+
resp.Body.Close()
244+
out.Close()
245+
246+
if err != nil {
247+
lastErr = err
248+
os.Remove(filepath)
249+
continue
250+
}
251+
252+
return nil
195253
}
196254

197-
_, err = io.Copy(out, reader)
198-
return err
255+
return fmt.Errorf("failed after %d attempts: %w", maxRetries, lastErr)
199256
}
200257

201258
// saveChecksums saves checksums persistently for future verification

‎cmd/launcher/internal/release_manager_test.go‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"os"
55
"path/filepath"
66
"runtime"
7+
"time"
78

89
. "github.com/onsi/ginkgo/v2"
910
. "github.com/onsi/gomega"
@@ -37,6 +38,8 @@ var _ = Describe("ReleaseManager", func() {
3738
Expect(newRM.GitHubOwner).To(Equal("mudler"))
3839
Expect(newRM.GitHubRepo).To(Equal("LocalAI"))
3940
Expect(newRM.BinaryPath).To(ContainSubstring(".localai"))
41+
Expect(newRM.HTTPClient).ToNot(BeNil())
42+
Expect(newRM.HTTPClient.Timeout).To(Equal(30 * time.Second))
4043
})
4144
})
4245

‎cmd/launcher/internal/systray_manager.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ func (sm *SystrayManager) showStatusDetails(status, version string) {
382382
// showErrorDialog shows a simple error dialog
383383
func (sm *SystrayManager) showErrorDialog(title, message string) {
384384
fyne.DoAndWait(func() {
385-
dialog.ShowError(fmt.Errorf(message), sm.window)
385+
dialog.ShowError(fmt.Errorf("%s", message), sm.window)
386386
})
387387
}
388388

0 commit comments

Comments
 (0)